0035848: The Discount Subtype "Apply Average Price" does not calculate the average of the products but discounts one entire product

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035848

Retail Modules

Discounts and Promotions

public

2017-04-26 13:26

2024-11-07 12:10

Reporter

lorenzofidalgo

Assigned To

rqueralta

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

out of date

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

2015-11-02

Regression introduced in release

RR16Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/0aa75789a053f6fd069baab3ff1509f3a827e40e [^]

Triggers an Emergency Pack

Summary

0035848: The Discount Subtype "Apply Average Price" does not calculate the average of the products but discounts one entire product

Description

The discount type "Buy X pay Y of different product" can apply the Discount Subtype "Apply Average Price". It is supposed it has to calculate the arithmetic mean of the products added to the receipt that belong to that discount and discount that mean. Instead of that, it is just discounting one entire product and no mean is calculated.
I have been able to reproduce this issue from pi to RR16Q1.3. It is not reproducible in RR15Q4.6.
Besides, it must be taken into account that the old code (RR15Q4.6) has some rounding inaccuracies.

Steps To Reproduce

0-Login POS Backend and, using The White Valley Group Admin" role, go to Discounts and Promotions window.
1-Edit the existent "3 x 2 Bottles" record. It must be saved with the following values:
--
Discount/promotion Type: Buy X pay Y of different product
Name: 3 x 2 Bottles
Starting Date: 01-06-2013
Included Products: Only those defined
(In Definition section)
X Units: 3
Y Units: 2
Discount Subtype: Apply Average Price
--
Save that record.
2-Go to Products tab and add the following records if they are not already added:
--
Bottle 1 L
Camel bak 3 L
Plastic bottle
Thermo 1 L
--
3-Go to POS and login as vallblanca.
4-Click SEARCH tab, enter bottle and click search button.
5-Add to the receipt 1x Bottle 1 L and 2x Plastic bottle
6-Realise the the applied discount is not right.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

duplicate of	defect	0057016		closed	radhakrishnan	[24Q4] Wrong discount while applying a 3 x 2 discount with different product and average price rule on POS1
caused by	defect	0031261		closed	jorge-garcia	Promotions are wrong applied if there is more than one promotion for the products