Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035840Openbravo ERPA. Platformpublic2017-04-26 08:352017-05-29 17:43
Reporteralostale 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035840: can't save record after failed save in tabs with a time reference
DescriptionIn tabs having at least one time reference field, the save button gets disabled after trying to save in case the request failed (ie. because a trigger prevented saving with current values).
Steps To Reproduce1. Open Process Request
2. Select Costing Background process
3. Keep Frequency with "02 - Every n minutes"
4. Set to blank "Interval in minutes" field
5. Save
  * OK -> An error message is shown because this is not a valid configuration
  * ERROR -> Save button gets disabled
  * ERROR -> JS error can be seen in dev console
ISC_Combined.js:254 Uncaught TypeError: Cannot read property 'startTime' of undefined
    at _2.formSaved (2e8cfb4….js:11424)
    at _2.formSavedComplete (ISC_Combined.js:12296)
    at _2.$49z (ISC_Combined.js:12296)
    at _2.eval (eval at isc__makeFunction (ISC_Combined.js:45), <anonymous>:3:18)
    at _2.isc_c_Class_fireCallback [as fireCallback] (ISC_Combined.js:254)
    at _2.isc_Class_fireCallback [as fireCallback] (ISC_Combined.js:314)
    at _2.isc_DataSource_fireResponseCallbacks [as fireResponseCallbacks] (ISC_Combined.js:10845)
    at _2.isc_DataSource__completeResponseProcessing [as $38b] (ISC_Combined.js:10842)
    at _2.isc_DataSource__handleJSONReply [as $377] (ISC_Combined.js:10735)
    at _2.isc.B.push.isc.A.$379 (ISC_Combined.js:10745)


​
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035835 closed inigosanchez The scheduler fails to load some scheduled processes when an incorrect configuration should be done 
related to defect 0035944 closed caristu unresponsive ui after uncaught error in EntityPersistenceEventObserver 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-26 08:35alostaleNew Issue
2017-04-26 08:35alostaleAssigned To => platform
2017-04-26 08:35alostaleModules => Core
2017-04-26 08:35alostaleTriggers an Emergency Pack => No
2017-04-26 08:35alostaleRelationship addedrelated to 0035835
2017-04-26 08:58alostaleAssigned Toplatform => alostale
2017-04-26 08:59alostaleStatusnew => acknowledged
2017-04-26 08:59alostaleReview Assigned To => caristu
2017-04-26 09:13hgbotCheckin
2017-04-26 09:13hgbotNote Added: 0096183
2017-04-26 09:13hgbotStatusacknowledged => resolved
2017-04-26 09:13hgbotResolutionopen => fixed
2017-04-26 09:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6d26747ad4df54db30adb2bda42bb62a19821d61 [^]
2017-04-28 08:34caristuNote Added: 0096248
2017-04-28 08:34caristuStatusresolved => closed
2017-04-28 08:34caristuFixed in Version => 3.0PR17Q3
2017-04-28 08:34caristuNote Edited: 0096248bug_revision_view_page.php?bugnote_id=0096248#r15075
2017-05-08 15:28alostaleRelationship addedrelated to 0035944
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096910

Notes
(0096183)
hgbot   
2017-04-26 09:13   
Repository: erp/devel/pi
Changeset: 6d26747ad4df54db30adb2bda42bb62a19821d61
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Apr 26 09:12:52 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d26747ad4df54db30adb2bda42bb62a19821d61 [^]

fixed bug 35840: can't save after failed save in tabs with a time reference

  In tabs having at least one time reference field, the save button gets disabled
  after trying to save in case the request failed.

  Time reference updates data in client to convert value to correct TZ. When record
  fails to be saved in backend, the callback doesn't return the data which was
  expected by this function, trying thus to read a property from an undefined
  variable.

  Now it is checked if data exists before trying to operate with it.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0096248)
caristu   
2017-04-28 08:34   
Code reviewed + tested OK in pi@5e818f0155f5
(0096910)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test