Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035835Openbravo ERPA. Platformpublic2017-04-25 16:222017-05-29 17:43
JONHM 
inigosanchez 
highmajoralways
closedfixed 
5
pi 
3.0PR17Q3 
alostale
Core
No
0035835: The scheduler fails to load some scheduled processes when an incorrect configuration should be done
The process request window allows to save incorrect configurations. When a process with incorrect scheduled configuration is launched an error is thrown.
- As F&B Admin
1) Open [Process Request] window
2) Edit 'Costing Background Process' (which is already scheduled) setting its frequency as "Monthly" let the 'Day in Month' field empty and save the record. (Incorrect configuration is allowed)
3) Unschedule Process and then Reschedule Process. An error is displayed: RESCHED_ERROR For input string: "". In the console you can see:

ERROR org.openbravo.base.OBSchedulerInitializerListener - Quartz Scheduler failed to initialize: java.lang.NumberFormatException: For input string: ""
java.lang.NumberFormatException: For input string: ""
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
    at java.lang.Integer.parseInt(Integer.java:592)
...
Added into ad_process_request_trg trigger the conditions to avoid invalid configurations for the process request.
No tags attached.
related to defect 0035840 closed alostale can't save record after failed save in tabs with a time reference 
related to defect 0035842 closed inigosanchez process scheduling data can be set in an inconsistent state 
Issue History
2017-04-25 16:22JONHMNew Issue
2017-04-25 16:22JONHMAssigned To => platform
2017-04-25 16:22JONHMModules => Core
2017-04-25 16:22JONHMRegression date => 2017-05-16
2017-04-25 16:22JONHMTriggers an Emergency Pack => No
2017-04-26 08:35alostaleRelationship addedrelated to 0035840
2017-04-26 09:01alostaleNote Added: 0096182
2017-04-26 09:01alostaleStatusnew => acknowledged
2017-04-26 09:39alostaleRelationship addedrelated to 0035842
2017-05-08 12:29maiteResolution time => 1494885600
2017-05-08 12:29maiteRegression date2017-05-16 =>
2017-05-10 13:11inigosanchezStatusacknowledged => scheduled
2017-05-10 13:11inigosanchezAssigned Toplatform => inigosanchez
2017-05-10 14:03inigosanchezSummaryThe scheduler fails to load some scheduled processes after tomcat restart => The scheduler fails to load some scheduled processes when an incorrect configuration should be done
2017-05-10 14:03inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=15149#r15149
2017-05-10 14:03inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15151#r15151
2017-05-10 14:03inigosanchezProposed Solution updated
2017-05-13 07:55hgbotCheckin
2017-05-13 07:55hgbotNote Added: 0096573
2017-05-13 07:55hgbotStatusscheduled => resolved
2017-05-13 07:55hgbotResolutionopen => fixed
2017-05-13 07:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33c6f5b78fd885848401360a8852dbff5b4a8cc3 [^]
2017-05-13 07:55inigosanchezReview Assigned To => alostale
2017-05-15 12:53alostaleNote Added: 0096589
2017-05-15 12:53alostaleStatusresolved => closed
2017-05-15 12:53alostaleFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096964

Notes
(0096182)
alostale   
2017-04-26 09:01   
This is due to an incorrect configuration for the process request. There is already a trigger preventing some invalid configurations to be saved, this trigger should be extended to cover this case, and re-checked for more invalid cases if they exist.
(0096573)
hgbot   
2017-05-13 07:55   
Repository: erp/devel/pi
Changeset: 33c6f5b78fd885848401360a8852dbff5b4a8cc3
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Sat May 13 07:54:26 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/33c6f5b78fd885848401360a8852dbff5b4a8cc3 [^]

Fixed issue 35835: Avoid invalid configurations for the process request.

The problem was the scheduler fails to load some scheduled processes when an incorrect
configuration should be done.

There is already a trigger preventing some invalid configurations to be saved. This
trigger has be extended to cover this case and others.

---
M src-db/database/model/triggers/AD_PROCESS_REQUEST_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0096589)
alostale   
2017-05-15 12:53   
code reviewed + tested
(0096964)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test