Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035783Openbravo ERP07. Sales managementpublic2017-04-12 14:042017-04-25 18:58
ngarcia 
markmm82 
immediatemajoralways
closedfixed 
5
 
3.0PR17Q23.0PR17Q2 
aferraz
Core
Production - Confirmed Stable
2017-12-03
3.0PR17Q1
https://code.openbravo.com/erp/devel/pi/rev/9df1ba7871bb [^]
No
0035783: Orders with Invoice Terms different from Customer Schedule After Delivery cannot be invoiced if the bp has an invoice schedule
Sales Orders with Invoice Terms different from Customer Schedule After Delivery (Immediate, After Delivery, After Order Delivered) cannot be invoiced if the business partner has an invoice schedule defined and the order does not fill its requirement

The problem is that the order is not returned by the C_INVOICE_CANDIDATE_V view, the following two changes were wrong

AND (o.invoicerule IN ('I', 'O', 'D', 'S'))

OR (si.invoicefrequency IN ('D', 'W', 'T'))
As group admin role:
   Create a new Invoice Schedule
   Configure it in order a sales order with today's date not to be automatically invoiced. Example being today 12-04-2017
      Day of The Month: 15
      Invoice Cut-Off Day: 13
   Set the Customer Schedule After Delivery Invoice Terms to a customer
   Create a Sales Order to that customer and set its Invoice Terms as Immediate
   Check the order does not appear in the Create Invoices From Orders process
   Create a sales invoice header and check the order is not shown in the Create lines From process
No tags attached.
blocks defect 0035772 closed markmm82 Orders with Invoice Terms different from Customer Schedule After Delivery cannot be invoiced if the bp has an invoice schedule 
Issue History
2017-04-12 18:59markmm82Typedefect => backport
2017-04-12 18:59markmm82Target Version => 3.0PR17Q2
2017-04-25 17:43hgbotCheckin
2017-04-25 17:43hgbotNote Added: 0096164
2017-04-25 17:43hgbotStatusscheduled => resolved
2017-04-25 17:43hgbotResolutionopen => fixed
2017-04-25 17:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/c31ebe580b49e1a22ef010098c7f8566362c7494 [^]
2017-04-25 17:44aferrazReview Assigned To => aferraz
2017-04-25 17:44aferrazNote Added: 0096167
2017-04-25 17:44aferrazStatusresolved => closed
2017-04-25 17:44aferrazFixed in Version => 3.0PR17Q2
2017-04-25 18:58hgbotCheckin
2017-04-25 18:58hgbotNote Added: 0096176

Notes
(0096164)
hgbot   
2017-04-25 17:43   
Repository: erp/backports/3.0PR17Q2
Changeset: c31ebe580b49e1a22ef010098c7f8566362c7494
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Apr 12 12:53:42 2017 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/c31ebe580b49e1a22ef010098c7f8566362c7494 [^]

Fixes issue 35783: Orders with Invoice Terms different from Customer Schedule
After Delivery cannot be invoiced if the bp has an invoice schedule

Sales Orders with Invoice Terms different from Customer Schedule After Delivery
(Immediate, After Delivery, After Order Delivered) cannot be invoiced if the business
partner has an invoice schedule defined and the order does not fill its requirement

The problem is that the order is not returned by the C_INVOICE_CANDIDATE_V view.
To avoid it was fixed the condition that takes into account the invoice rule of
the order and the sales invoice frequency.

---
M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
---
(0096167)
aferraz   
2017-04-25 17:44   
Code review + Testing OK
(0096176)
hgbot   
2017-04-25 18:58   
Repository: erp/backports/3.0PR17Q2
Changeset: 94badfae5504ab2fbf3ad592d48020dc80b9bc41
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 25 18:26:55 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/94badfae5504ab2fbf3ad592d48020dc80b9bc41 [^]

Related to issue 35783: Fix dbcons failure

---
M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
---