Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035782Openbravo ERPA. Platformpublic2017-04-12 17:402017-05-29 17:43
Reportershuehner 
Assigned Toinigosanchez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035782: ant compile.complete.deploy is missing dependencies on core.lib wad.lib trl.lib
DescriptionThat causes compile errors of unsupecting users if some changes are done in i.e. src-core which require recompile to get rest of compile working.

Note:
That has been fixed long time ago in compile.complete but the compile.complete.deploy internally does not reuse this so fix does not auto-apply.
Steps To Reproduce-
Proposed SolutionJust add ant depends
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013425 closed migueldejuana ant compile.complete should depend on core.lib, wad.lib, trl.lib 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-12 17:40shuehnerNew Issue
2017-04-12 17:40shuehnerAssigned To => platform
2017-04-12 17:40shuehnerOBNetwork customer => Yes
2017-04-12 17:40shuehnerModules => Core
2017-04-12 17:40shuehnerTriggers an Emergency Pack => No
2017-04-12 17:41shuehnerResolution time => 1493762400
2017-04-12 17:42shuehnerRelationship addedrelated to 0013425
2017-04-25 16:29inigosanchezStatusnew => scheduled
2017-04-25 16:29inigosanchezAssigned Toplatform => inigosanchez
2017-04-25 16:37inigosanchezReview Assigned To => alostale
2017-04-25 17:10inigosanchezNote Added: 0096162
2017-04-25 17:22inigosanchezNote Edited: 0096162bug_revision_view_page.php?bugnote_id=0096162#r15057
2017-04-25 17:46hgbotCheckin
2017-04-25 17:46hgbotNote Added: 0096169
2017-04-25 17:46hgbotStatusscheduled => resolved
2017-04-25 17:46hgbotResolutionopen => fixed
2017-04-25 17:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5a72ca509c6fe71ebef703eb38159380ba8d5a9d [^]
2017-04-28 08:51alostaleNote Added: 0096251
2017-04-28 08:51alostaleStatusresolved => closed
2017-04-28 08:51alostaleFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096908

Notes
(0096162)
inigosanchez   
2017-04-25 17:10   
(edited on: 2017-04-25 17:22)
Test plan:
- Execute ant compile.complete.deploy > It should be executed core.lib, wad.lib and trl.lib.
- Execute ant compile.complete.development (Openbravo.properties > deploy.mode=class) > It should be executed core.lib, wad.lib and trl.lib.
- Execute ant compile.complete.war (Openbravo.properties > deploy.mode=war) > It should be executed core.lib, wad.lib and trl.lib.
(0096169)
hgbot   
2017-04-25 17:46   
Repository: erp/devel/pi
Changeset: 5a72ca509c6fe71ebef703eb38159380ba8d5a9d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Apr 25 17:34:18 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5a72ca509c6fe71ebef703eb38159380ba8d5a9d [^]

Fixed issue 35782: compile.complete.deploy depend on core.lib,wad.lib,trl.lib

Compile.complete.deploy ant task now is depent on core.lib,wad.lib,trl.lib because if deploy.mode
in Openbravo.properties is configured to class mode compile.complete.development ant task is
executed and now this task depend on core.lib,wad.lib and trl.lib.

On the other hand if deploy.mode in Openbravo.properties is configured to war mode, compile.complete
is executed and this ant task has the dependencies defined properly.

---
M build.xml
---
(0096251)
alostale   
2017-04-28 08:51   
reviewed + tested
(0096908)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test