Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035774Retail ModulesWeb POSpublic2017-04-12 15:032017-06-15 11:29
Reporternataliag 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035774: External Keyboard reads letter K as an enter in iOS
DescriptionExternal Keyboard reads letter K as an enter in iOS
Steps To Reproduce1- Using an iOS device go to "POS Terminal Type" window in backoffice and select the "VBS POS Terminal Type" record, tick the "Use External Input" option.
2- Save changes and go to the POS Terminal.
3- Click on the UPC/EAN field and using a external keyboard insert a code, for example 1234K, it is interpreted that letter K is an enter and only the code 1234 is sent. Then in next scann, if another code is entered, for example, 789,it is sent as k789.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-12 15:03nataliagNew Issue
2017-04-12 15:03nataliagAssigned To => Retail
2017-04-12 15:03nataliagResolution time => 1493762400
2017-04-12 15:03nataliagTriggers an Emergency Pack => No
2017-04-12 15:09heccamIssue Monitored: heccam
2017-04-12 15:13PracticsIssue Monitored: Practics
2017-04-19 16:30jorge-garciaStatusnew => scheduled
2017-04-19 16:30jorge-garciaAssigned ToRetail => jorge-garcia
2017-04-21 10:43hgbotCheckin
2017-04-21 10:43hgbotNote Added: 0096098
2017-04-21 10:43hgbotStatusscheduled => resolved
2017-04-21 10:43hgbotResolutionopen => fixed
2017-04-21 10:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64abad88deff21f9b8305639eb8d21b9cebadc97 [^]
2017-05-08 11:17marvintmNote Added: 0096452
2017-05-08 11:17marvintmStatusresolved => new
2017-05-08 11:17marvintmResolutionfixed => open
2017-05-08 11:17marvintmAssigned Tojorge-garcia => marvintm
2017-05-16 18:40marvintmStatusnew => scheduled
2017-05-17 12:14hgbotCheckin
2017-05-17 12:14hgbotNote Added: 0096637
2017-05-17 12:14hgbotStatusscheduled => resolved
2017-05-17 12:14hgbotResolutionopen => fixed
2017-05-17 12:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64abad88deff21f9b8305639eb8d21b9cebadc97 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/960b78891206fa49463e61ea2cc91e771935917d [^]
2017-05-17 12:14hgbotCheckin
2017-05-17 12:14hgbotNote Added: 0096638
2017-05-19 10:36jorge-garciaNote Added: 0096674
2017-05-19 10:36jorge-garciaStatusresolved => new
2017-05-19 10:36jorge-garciaResolutionfixed => open
2017-05-19 10:43jorge-garciaReview Assigned To => jorge-garcia
2017-05-22 08:42marvintmStatusnew => scheduled
2017-05-29 12:59hgbotCheckin
2017-05-29 12:59hgbotNote Added: 0096852
2017-05-29 12:59hgbotStatusscheduled => resolved
2017-05-29 12:59hgbotResolutionopen => fixed
2017-05-29 12:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/960b78891206fa49463e61ea2cc91e771935917d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/79e760066426c475747a417084c6278297e82f6e [^]
2017-05-31 13:21jorge-garciaNote Added: 0097049
2017-05-31 13:21jorge-garciaStatusresolved => new
2017-05-31 13:21jorge-garciaResolutionfixed => open
2017-05-31 13:21jorge-garciaNote Edited: 0097049bug_revision_view_page.php?bugnote_id=0097049#r15252
2017-06-02 12:53marvintmStatusnew => scheduled
2017-06-06 11:45hgbotCheckin
2017-06-06 11:45hgbotNote Added: 0097162
2017-06-06 11:45hgbotStatusscheduled => resolved
2017-06-06 11:45hgbotResolutionopen => fixed
2017-06-06 11:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/79e760066426c475747a417084c6278297e82f6e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9ed7057ba7555ed7629b8e9d15bb16a4f23571b9 [^]
2017-06-15 11:29jorge-garciaNote Added: 0097416
2017-06-15 11:29jorge-garciaStatusresolved => closed
2017-06-15 11:29jorge-garciaFixed in Version => RR17Q3

Notes
(0096098)
hgbot   
2017-04-21 10:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 64abad88deff21f9b8305639eb8d21b9cebadc97
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 20 11:03:15 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64abad88deff21f9b8305639eb8d21b9cebadc97 [^]

Fixed issue 35774: External Keyboard reads letter K as an enter in iOS

In IOS, keyboard evetns are different from PC and android.

Added the correct keyboard events for IOS.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0096452)
marvintm   
2017-05-08 11:17   
It seems there are problems with some characters (like some letters such as 'a', or 'd') due to the fact that the keypress event generates slightly different codes. We need to look deeper at this.
(0096637)
hgbot   
2017-05-17 12:14   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 960b78891206fa49463e61ea2cc91e771935917d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 16 18:38:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/960b78891206fa49463e61ea2cc91e771935917d [^]

Fixed issue 35774. Several improvements have been made:
- Refactored code which handles special commands such as +, -, delete line, ... Unified code, and made it extensible.
- Fixed problem with backspace key in iOS
- Fixed problem with focus keeper activation in iOS, by removing setTimeout, and instead using the event.relatedTarget to detect the new component which is being focused.
- Disabled autocapitalize and autocorrect in the focusKeeper to prevent strange errors in iOS.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0096638)
hgbot   
2017-05-17 12:14   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 111d8019bd65c197e80ab5f6853e2856e6ba6f16
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed May 17 09:55:39 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/111d8019bd65c197e80ab5f6853e2856e6ba6f16 [^]

Related to issue 35774. actualChar will be read before executing special actions, to prevent wrong characters which are actually related to actions.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0096674)
jorge-garcia   
2017-05-19 10:36   
The proposed solution is not working on IPad version 9.X.X.

Each time a barcode is scanned an javascript error is shown.
(0096852)
hgbot   
2017-05-29 12:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 79e760066426c475747a417084c6278297e82f6e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu May 25 19:47:48 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/79e760066426c475747a417084c6278297e82f6e [^]

Fixed issue 35774. Removed obsolete call to writeCharacter.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0097049)
jorge-garcia   
2017-05-31 13:21   
There is a problem with changeset[1] and Ipad version 9.X.X

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/960b78891206fa49463e61ea2cc91e771935917d [^]

Now, no javascript error is shown when a keyboard key is pressed. but the value of the key pressed is not shown in point of sale editbox.

The rest of devices works fine (PC, Android, and IOS 10.X.X)
(0097162)
hgbot   
2017-06-06 11:45   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9ed7057ba7555ed7629b8e9d15bb16a4f23571b9
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 05 13:34:54 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9ed7057ba7555ed7629b8e9d15bb16a4f23571b9 [^]

Fixed issue 35774. Restored call to writeCharacter. fromCharCode will be used on iOS 9 and earlier, as keyboardEvent.key is not supported there.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0097416)
jorge-garcia   
2017-06-15 11:29   
Code reviewed and tested in devices:
 * Iphone version 10.X.X
 * Ipad version 9.X.X
 * PC
 * Android tablets