Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035760Openbravo ERP00. Application dictionarypublic2017-04-12 00:182017-05-29 17:43
Reporterletcharren 
Assigned Toinigosanchez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR17Q1 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket46271
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035760: Can not create computed columns in ad_org or ad_client tables
DescriptionCan not create computed columns in ad_org or ad_client tables. When you want to export the changes (generate.entities), the attached error is shown.
Steps To Reproduce1- Create a computed column in table ad_org or in ad_client.
2- Create a field in the organization/client corresponding to the created column.
3- Execute "ant export.database" in order to export changes.
4- The attached error is displayed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? log (6,814) 2017-04-12 00:18
https://issues.openbravo.com/file_download.php?file_id=10669&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-04-12 00:18letcharrenNew Issue
2017-04-12 00:18letcharrenAssigned To => platform
2017-04-12 00:18letcharrenFile Added: log
2017-04-12 00:18letcharrenOBNetwork customer => No
2017-04-12 00:18letcharrenModules => Core
2017-04-12 00:18letcharrenSupport ticket => 46271
2017-04-12 00:18letcharrenResolution time => 1493676000
2017-04-12 00:18letcharrenTriggers an Emergency Pack => No
2017-04-24 12:36maiteOBNetwork customerNo => Yes
2017-05-09 11:33inigosanchezAssigned Toplatform => inigosanchez
2017-05-09 11:33inigosanchezStatusnew => acknowledged
2017-05-10 12:27inigosanchezStatusacknowledged => scheduled
2017-05-10 12:27inigosanchezNote Added: 0096506
2017-05-10 12:30inigosanchezSummaryCan not create computed columns in ad_org table => Can not create computed columns in ad_org or ad_client tables
2017-05-10 12:30inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=15145#r15145
2017-05-10 12:30inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15147#r15147
2017-05-10 12:32inigosanchezReview Assigned To => alostale
2017-05-12 10:14hgbotCheckin
2017-05-12 10:14hgbotNote Added: 0096546
2017-05-12 10:14hgbotStatusscheduled => resolved
2017-05-12 10:14hgbotResolutionopen => fixed
2017-05-12 10:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3d40af5ffd2811557afcefb8791f3de9e9e6e1bc [^]
2017-05-12 10:16inigosanchezFixed in Version => 3.0PR17Q3
2017-05-15 13:17hgbotCheckin
2017-05-15 13:17hgbotNote Added: 0096591
2017-05-15 13:18alostaleNote Added: 0096592
2017-05-15 13:18alostaleStatusresolved => closed
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096962
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096967

Notes
(0096506)
inigosanchez   
2017-05-10 12:27   
Manual tests:

1º.- Normal case > Create computed column for Assets table + Field for the created computed column > ant export.database > Check that ./src-gen/org/openbravo/model/financialmgmt/assetmgmt/Asset_ComputedColumns.java is generated as expects (implements both interfaces).

2º.- Case Org > Create computed column for Organization table + Field for the created computed column > ant export.database > Check that ./src-gen/org/openbravo/model/common/enterprise/Organization_ComputedColumns.java is generated as expects (only implements ClientEnabled).

3º.- Case Client > Create computed column for Client table + Field for the created computed column > ant export.database > Check that ./src-gen/org/openbravo/model/ad/system/Client_ComputedColumns.java is generated as expects (only implements OrganizationEnabled).
(0096546)
hgbot   
2017-05-12 10:14   
Repository: erp/devel/pi
Changeset: 3d40af5ffd2811557afcefb8791f3de9e9e6e1bc
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri May 12 10:13:57 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d40af5ffd2811557afcefb8791f3de9e9e6e1bc [^]

Fixed issue 35760:Can not create computed columns in ad_org or ad_client tables

The problem was that it was not possible to create and export a computed column in ad_org and ad_client tables.
This problem was because computed columns of organization entity should have not organization as a property and
it should have not implement OrganizationEnabled. At the same time, computed columns of client entity should have
not client as a property and it should have not implement ClientEnabled.

In order to fix this problem two changes have been done:
- Now generate entities task is take into account when a computed column is created for Organization or Client
entities. Besides, when the computed column class is created, entityComputedColumns.ftl has the needed logic to
decided if implements ClientEnabled, OrganizationEnabled or both.
- When the Hibernate mapping for the tables and entities are created (DalMappingGenerator),
generateComputedColumnsClassMapping method is take into account when the computed column is for Organization
entity or Client entity.

It is now possible to create a computed column in the ad_org and ad_client tables.

---
M src/org/openbravo/base/gen/GenerateEntitiesTask.java
M src/org/openbravo/base/gen/entityComputedColumns.ftl
M src/org/openbravo/dal/core/DalMappingGenerator.java
---
(0096591)
hgbot   
2017-05-15 13:17   
Repository: erp/devel/pi
Changeset: 658d65dc2006ea6c0c043694c7c2d76714b9183e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon May 15 13:17:01 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/658d65dc2006ea6c0c043694c7c2d76714b9183e [^]

related to bug 35760: can't create computed columns in ad_org or ad_client

  Be more specific when checking whether client/org property should be added to
  computed column mapping.

---
M src/org/openbravo/dal/core/DalMappingGenerator.java
---
(0096592)
alostale   
2017-05-15 13:18   
reviewed + tested
(0096962)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096967)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test