Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035745Retail ModulesWeb POSpublic2017-04-10 17:142018-10-29 11:26
Reportermigueldejuana 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035745: Add a transaction where it is needed
DescriptionThere are some places in the code where saves in the local database must be inside a transaction:

- Inside cancelLayaway listener: Save order and cashup info(add calculateCurrentCash also??)
- Inside voidLayaway listener: Save order, cashup info and calculateCurrentCash
- Inside multiOrdersFunction function: Save order, cashup info, calculateCurrentCash and updateDocumentSequenceWhenOrderSaved
- Inside errorCalbacks of multiOrdersFunction and mainReceiptCloseFunction

Review the code. There should be more cases
Steps To ReproduceSee Description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035703 closed migueldejuana It is possible to count the same ticket twice on the same paymentmethodcashup 
related to defect 0038862 closed migueldejuana Ticket completion should be executed fully inside the same database transaction 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-10 17:14migueldejuanaNew Issue
2017-04-10 17:14migueldejuanaAssigned To => Retail
2017-04-10 17:14migueldejuanaOBNetwork customer => No
2017-04-10 17:14migueldejuanaTriggers an Emergency Pack => No
2017-04-10 17:14migueldejuanaRelationship addedrelated to 0035703
2017-04-11 08:14migueldejuanaPrioritynormal => high
2017-04-11 08:14migueldejuanaSeveritytrivial => major
2017-04-11 08:15migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=14997#r14997
2018-04-05 15:12ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-04-05 15:12ranjith_qualiantech_comStatusnew => scheduled
2018-08-20 07:55ranjith_qualiantech_comRelationship addedrelated to 0038862
2018-10-08 14:47hgbotCheckin
2018-10-08 14:47hgbotNote Added: 0107219
2018-10-08 14:47hgbotStatusscheduled => resolved
2018-10-08 14:47hgbotResolutionopen => fixed
2018-10-08 14:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/693bfc2fe93581ffb9b3db6519a120af7cd91b54 [^]
2018-10-29 11:26marvintmReview Assigned To => marvintm
2018-10-29 11:26marvintmStatusresolved => closed
2018-10-29 11:26marvintmFixed in Version => RR19Q1

Notes
(0107219)
hgbot   
2018-10-08 14:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 693bfc2fe93581ffb9b3db6519a120af7cd91b54
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 08 18:16:38 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/693bfc2fe93581ffb9b3db6519a120af7cd91b54 [^]

Fixed issue 35745 : Added transaction while closing multiorder

* Added transaction while voiding Layaway
* Added transaction while closing cashup

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---