Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035743Openbravo ERP09. Financial managementpublic2017-04-10 13:262017-05-29 17:43
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket46113
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035743: Accounting Templates for payments are not taken into account if the Acct Server Process is scheduled at System level
DescriptionAccounting Templates for payments are not taken into account if the Acct Server Process is scheduled at System level.

Both acctSchemaTableDocTypes and acctSchemaTables lists are empty as the OBQuery.list is filtering by ad_org_id in ('0') and ad_client_id in ('0')
Steps To ReproduceAs system admin role:
   Install the 'Timing of VAT booking for Sales Storno Invoices' module in order to have an accounting template for payments
   Set as Displayed the Accounting Template field in the following tabs:
      General Ledger Configuration - Active tables
      General Ledger Configuration - Active tables - Documents

As group admin role:
   Unschedule the Acct Server Process

1
   Go to General Ledger Configuration and select FIN_Payment table in Active tables window
   Add a record in its Document tab:
      Document Category: AR Receipt
      Accounting Template: Accounting Engine - Financial Payment
   Create a Payment In that should be posted in the configured general ledger
   Configure the financial account to post that payment (In Transit Account)
   Schedule the Acct Server Process and check the Payment In is posted using the template
   (You could put a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value)

   Unpost the payment

As system admin role:
   Schedule the Acct Server Process and check the Payment In is not posted using the template but the common process
   (You could put a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable is empty)

As group admin role:
2
   Unpost the Payment In
   Go to General Ledger Configuration and select FIN_Payment table in Active tables window
   Add the 'Accounting Engine - Financial Payment' as Accounting Template in Active tables tab
   Remove the record in its Document tab:

   Schedule the Acct Server Process and check the Payment In is posted using the template
   (You could put a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value)

   Unpost the payment

As system admin role:
   Schedule the Acct Server Process and check the Payment In is not posted using the template but the common process
   (You could put a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable is empty)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-10 13:26ngarciaNew Issue
2017-04-10 13:26ngarciaAssigned To => Triage Finance
2017-04-10 13:26ngarciaOBNetwork customer => Yes
2017-04-10 13:26ngarciaModules => Core
2017-04-10 13:26ngarciaSupport ticket => 46113
2017-04-10 13:26ngarciaResolution time => 1493676000
2017-04-10 13:26ngarciaTriggers an Emergency Pack => No
2017-04-10 13:26ngarciaIssue Monitored: networkb
2017-04-12 14:36aferrazAssigned ToTriage Finance => AtulOpenbravo
2017-04-17 21:28AtulOpenbravoStatusnew => scheduled
2017-04-18 19:18AtulOpenbravoNote Added: 0096057
2017-04-18 19:19AtulOpenbravoNote Edited: 0096057bug_revision_view_page.php?bugnote_id=0096057#r15036
2017-04-28 16:30hgbotCheckin
2017-04-28 16:30hgbotNote Added: 0096270
2017-04-28 16:30hgbotStatusscheduled => resolved
2017-04-28 16:30hgbotResolutionopen => fixed
2017-04-28 16:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/21e5d56eca66756563f47550f78fe9c004c97fb4 [^]
2017-04-28 16:30hgbotCheckin
2017-04-28 16:30hgbotNote Added: 0096271
2017-04-28 16:32aferrazReview Assigned To => aferraz
2017-04-28 16:32aferrazNote Added: 0096272
2017-04-28 16:32aferrazStatusresolved => closed
2017-04-28 16:32aferrazFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096918
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096919

Notes
(0096057)
AtulOpenbravo   
2017-04-18 19:18   
(edited on: 2017-04-18 19:19)
- Login as system admin role:
- Install the 'Timing of VAT booking for Sales Storno Invoices' module in order to have an accounting template for payments
- Set as Displayed the Accounting Template field in the following tabs:
  - General Ledger Configuration - Active tables
  - General Ledger Configuration - Active tables - Documents

- Login as Group Admin role:
- Unschedule the Acct Server Process

Check 1:

- Go to General Ledger Configuration and select FIN_Payment table in Active tables window
- Add a record in its Document tab:
      Document Category: AR Receipt
      Accounting Template: Accounting Engine - Financial Payment
- Create a Payment In that should be posted in the configured general ledger
- Configure the financial account to post that payment (In Transit Account)
- Schedule the Acct Server Process and check the Payment In is posted using the template by adding a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value.
- Unpost the payment
- Login as System Admin role:
-Schedule the Acct Server Process and check the Payment In is posted using the template by adding breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value.

Check 2:

- Unpost the Payment In
- Go to General Ledger Configuration and select FIN_Payment table in Active tables window.
- Add the 'Accounting Engine - Financial Payment' as Accounting Template in Active tables tab
- Remove the record in its Document tab:
- Schedule the Acct Server Process and check the Payment In is posted using the template by adding a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value.
- Unpost the payment.
- Login as system admin role:
- Schedule the Acct Server Process and check the Payment In is posted using the template by adding a breakpoint in createFact function of DocFinPayment class in order to check strClassname variable has a value.
(0096270)
hgbot   
2017-04-28 16:30   
Repository: erp/devel/pi
Changeset: 21e5d56eca66756563f47550f78fe9c004c97fb4
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Apr 18 22:35:56 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/21e5d56eca66756563f47550f78fe9c004c97fb4 [^]

Fixes issue 35743: Accounting Templates for payments are not taken into
account if the Acct Server Process is scheduled at System level

By default client and organization filters where added while fetching
Accounting Schema Table and Accounting Schema Table Document Type.
In case of scheduling accounting server process at system level above
information was fetched for system client 0 and organization 0 which
gives no results for the accounting schema of business client.
For fetching required data schema id and table id is enough no need
to filter it by client or organization as in the other classes
for eg: DocInvoice.java

---
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
(0096271)
hgbot   
2017-04-28 16:30   
Repository: erp/devel/pi
Changeset: 48dc3283427f311b5c0bf188f0a482e33c942f2d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Apr 28 15:39:00 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/48dc3283427f311b5c0bf188f0a482e33c942f2d [^]

Related to issue 35743: Update copyright

---
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
(0096272)
aferraz   
2017-04-28 16:32   
Code review + Testing OK
(0096918)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096919)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test