Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035700Retail ModulesMulti order paymentpublic2017-04-05 12:182017-05-08 11:41
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035700: [Synchronized Mode] Fix some errors when using Pay Open Tickets
DescriptionWith Synchronized Mode enabled, there are several bugs. Pay Open Tickets doesn't update the cashup info in the backend. If Pay Open Tickets process fails synchronizing in backend, the UI gets broken. Etc..
Steps To ReproduceOne example:

- Create 2 receipts but don't pay them
- Open Pay Open Tickets
- Pay them
- Go to backend and open POS Terminal Window --> Cashup history
- Check the info and see that it is not updated
Proposed SolutionReview the whole process with Synchronized Mode enabled.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035744 closed Sandrahuguet Synchronized Mode with Pay Open Tickets has no tests 
related to defect 0035742 closed mtaal Synchronized Mode with Quotation Reject does not show an error when it occurs on the server 
related to defect 0035737 closed mtaal Synchronized Mode is not working fine creating Customer/Customer Address in case an error occurs on the server 
related to defect 0035738 closed mtaal Synchronized Mode is not working in Void Layaway in case an error occurs on the server 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-05 12:18migueldejuanaNew Issue
2017-04-05 12:18migueldejuanaAssigned To => migueldejuana
2017-04-05 12:18migueldejuanaOBNetwork customer => No
2017-04-05 12:18migueldejuanaTriggers an Emergency Pack => No
2017-04-05 12:24hgbotCheckin
2017-04-05 12:24hgbotNote Added: 0095842
2017-04-05 12:24hgbotStatusnew => resolved
2017-04-05 12:24hgbotResolutionopen => fixed
2017-04-05 12:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28fdb6187e95772f453c9ce86428faa3757aa9de [^]
2017-05-08 11:41marvintmReview Assigned To => marvintm
2017-05-08 11:41marvintmStatusresolved => closed
2017-05-08 11:41marvintmFixed in Version => RR17Q3
2017-05-08 11:46migueldejuanaRelationship addedrelated to 0035744
2017-05-08 11:47marvintmRelationship addedrelated to 0035742
2017-05-08 11:47marvintmRelationship addedrelated to 0035737
2017-05-08 11:48marvintmRelationship addedrelated to 0035738

Notes
(0095842)
hgbot   
2017-04-05 12:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 28fdb6187e95772f453c9ce86428faa3757aa9de
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Apr 05 12:23:46 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28fdb6187e95772f453c9ce86428faa3757aa9de [^]

Fixed issue 0035700: [Synchronized Mode] Fix some errors when using Pay Open Tickets

- Show in modalmultiorders gross instead of pending. We could have payments in the order which could change the pending.
- Loading multiorders, remove possible payments from orders created in web POS. We have to load orders without payments to share correctly between all multiOrders.
- When failing processing orders, save isBeingClosed = false value in local database and in orderList.
- Save multiorders and payments status before processing them in order to restore the value if failing.
- For multiorders, trigger 'closed' event and runSyncProcess function just when last order is processed.
- Send order and cashup info in dataordersave.js. After saving the database checkpoint. It is done in the same place for Synchronized and No Synchronized Mode

---
M web/org.openbravo.retail.posterminal/js/components/modalmultiorders.js
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---