Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035698Openbravo ERP09. Financial managementpublic2017-03-06 11:312017-05-17 22:07
Reportervmromanos 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q2Fixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2017-02-23
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/251ea8a24d39 [^]
Triggers an Emergency PackNo
Summary0035698: Payables and Receivable Aging Balance Organization and General Ledger fields
DescriptionSeveral problems in Organization and General Ledger Filters in both Payables and Receivables Aging Schedule Reports.

Organization:
1. Validation similar to "AD_Org is transactions allowed" should be added

General Ledger:
1. Add validation to show only general ledgers available for the selected organization. The values should be updated each time the organization is changed.
Steps To ReproduceAs Openbravo Admin

Go to Payables Aging Schedule report (or Receivables Aging Schedule)
Verify * organization can be selected. This is wrong as this organization can't have transactions
Change org to F&B US.
Verify General Ledger "F&B España" is shown in selector. This is wrong as this general ledger is not available for F&B US
Proposed SolutionReview original code in legacy Aging Balance module and transplant it to the version in core for both reports.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00354333.0PR17Q3 closed nonofrancisco Payables and Receivable Aging Balance Organization and General Ledger fields 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-05 09:15vmromanosTypedefect => backport
2017-04-05 09:15vmromanosTarget Version3.0PR17Q3 => 3.0PR17Q2.1
2017-05-17 21:49aferrazTarget Version3.0PR17Q2.1 => 3.0PR17Q2
2017-05-17 21:53aferrazRegression level => Packaging and release
2017-05-17 21:53aferrazRegression date => 2017-02-23
2017-05-17 21:53aferrazRegression introduced in release => main
2017-05-17 21:53aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/251ea8a24d39 [^]
2017-05-17 22:06hgbotCheckin
2017-05-17 22:06hgbotNote Added: 0096651
2017-05-17 22:06hgbotStatusscheduled => resolved
2017-05-17 22:06hgbotResolutionopen => fixed
2017-05-17 22:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/c87853b86121633e2fb25506bb8fb01b708b0927 [^]
2017-05-17 22:07hgbotCheckin
2017-05-17 22:07hgbotNote Added: 0096652
2017-05-17 22:07aferrazReview Assigned To => aferraz
2017-05-17 22:07aferrazNote Added: 0096653
2017-05-17 22:07aferrazStatusresolved => closed
2017-05-17 22:07aferrazFixed in Version => 3.0PR17Q2

Notes
(0096651)
hgbot   
2017-05-17 22:06   
Repository: erp/backports/3.0PR17Q2
Changeset: c87853b86121633e2fb25506bb8fb01b708b0927
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Tue May 09 13:28:14 2017 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/c87853b86121633e2fb25506bb8fb01b708b0927 [^]

Fixes issue 35698: Aging Balance Organization and GL fields

* The default value of parameter Organization is the one selected when login,
if is transaction allowed, otherwise, the first one in the list of Organizations
with transaction allowed.

* When parameter Organization changes, the selected value of General Ledger
selector is set accordingly.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
A src/org/openbravo/common/actionhandler/AgingGeneralLedgerByOrganizationActionHandler.java
A src/org/openbravo/common/filterexpression/AgingGeneralLedgerFilterExpression.java
A src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0096652)
hgbot   
2017-05-17 22:07   
Repository: erp/backports/3.0PR17Q2
Changeset: 93c55a945cca38e2e4fada8a672ae2271c08d7ae
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed May 17 21:46:10 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/93c55a945cca38e2e4fada8a672ae2271c08d7ae [^]

Related to issue 35698: Code review improvements

- Fix copyrights.
- Improve Account Schema Selector filter expression.
- Improve AgingOrganizationFilterExpression class.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src/org/openbravo/common/actionhandler/AgingGeneralLedgerByOrganizationActionHandler.java
M src/org/openbravo/common/filterexpression/AgingGeneralLedgerFilterExpression.java
M src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0096653)
aferraz   
2017-05-17 22:07   
Code review + Testing OK