Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035690ModulesRemittancepublic2017-04-04 17:032017-04-25 19:41
ReporterSandrahuguet 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customerOBPS
Regression introduced in release
Summary0035690: Performance of Select Payments P&E grid should be improved
DescriptionLoad payments P&E grid from select payments process takes around 6s in a hgvol enviroment.
Steps To Reproduce-Login in the ERP
-Go to Remittance
-Create new header
-Click on 'Select Payments', notice that select payments P&E grid takes around 6s in a hgvol enviroment
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035664 closed markmm82 Openbravo ERP Performance of Add Multiple Payments P&E grid should be improved 
related to defect 0024540 closed eduardo_Argal Modules The financial account in which is deposited the remittance is wrong 
related to defect 0024583 closed Sandrahuguet Modules Protested Payment can not be included in other Remittance using "Select Payments" process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-04 17:03SandrahuguetNew Issue
2017-04-04 17:03SandrahuguetAssigned To => Triage Finance
2017-04-04 17:03SandrahuguetOBNetwork customer => No
2017-04-04 17:03SandrahuguetRelationship addeddepends on 0035664
2017-04-04 17:03SandrahuguetRelationship deleteddepends on 0035664
2017-04-04 17:03SandrahuguetRelationship addedrelated to 0035664
2017-04-04 17:04SandrahuguetResolution time => 1493071200
2017-04-04 17:04SandrahuguetOBNetwork customerNo => Yes
2017-04-04 19:38aferrazAssigned ToTriage Finance => markmm82
2017-04-06 16:24markmm82Statusnew => scheduled
2017-04-11 16:35aferrazRelationship addedrelated to 0024540
2017-04-11 16:35aferrazRelationship addedrelated to 0024583
2017-04-21 15:42markmm82Note Added: 0096106
2017-04-25 17:57hgbotCheckin
2017-04-25 17:57hgbotNote Added: 0096170
2017-04-25 17:57hgbotStatusscheduled => resolved
2017-04-25 17:57hgbotResolutionopen => fixed
2017-04-25 17:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/baf30ae1a2596bfb89617bc1bae9d0b092d0be5b [^]
2017-04-25 17:57hgbotCheckin
2017-04-25 17:57hgbotNote Added: 0096171
2017-04-25 17:57hgbotCheckin
2017-04-25 17:57hgbotNote Added: 0096172
2017-04-25 18:30aferrazReview Assigned To => aferraz
2017-04-25 18:30aferrazNote Added: 0096174
2017-04-25 18:30aferrazStatusresolved => closed
2017-04-25 19:23hgbotCheckin
2017-04-25 19:23hgbotNote Added: 0096179
2017-04-25 19:41hgbotCheckin
2017-04-25 19:41hgbotNote Added: 0096180
2017-04-25 19:41aferrazNote Deleted: 0096174
2017-04-25 19:41aferrazNote Deleted: 0096172
2017-04-25 19:41aferrazNote Added: 0096181

Notes
(0096106)
markmm82   
2017-04-21 15:42   
Test Plan:
-Login in the ERP
-Go to Remittance
-Create new header
-Click on 'Select Payments', notice that select payments P&E grid load substancially faster in a hgvol enviroment
(0096170)
hgbot   
2017-04-25 17:57   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: baf30ae1a2596bfb89617bc1bae9d0b092d0be5b
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Apr 20 13:31:50 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/baf30ae1a2596bfb89617bc1bae9d0b092d0be5b [^]

Fixes issue 35690: Performance of Select Payments P&E grid should be improved

Load payments P&E grid from select payments process takes around 6s in a hgvol
environment.

To improve the performance was changed the HQL clause to avoid that Hibernate
generates a SQL query with a cross join with the fin_payment table, because the
only reason of ask for the isReceipt value of the payment.

It was improved by including it as a new column isreceipt in the REM_PAYMENT_V
view, and then using it in the HQL.

---
M src-db/database/model/views/REM_PAYMENT_V.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0096171)
hgbot   
2017-04-25 17:57   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 8fcf3481d9a8e3a0ce71898d05fc70d504f75a84
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 25 13:48:07 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/8fcf3481d9a8e3a0ce71898d05fc70d504f75a84 [^]

Related to issue 35690: Run Synchronize Terminology

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0096179)
hgbot   
2017-04-25 19:23   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: f4d779cf38af33abc2011f58375d7e4a5b970c25
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 25 19:22:48 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/f4d779cf38af33abc2011f58375d7e4a5b970c25 [^]

Related to issue 35690: Fix Select Payments HQL where clause after running ST

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0096180)
hgbot   
2017-04-25 19:41   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 65d612883d6a4172d5ecd20955ff3d798043c7fd
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 25 19:38:52 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/65d612883d6a4172d5ecd20955ff3d798043c7fd [^]

Related to issue 35690: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0096181)
aferraz   
2017-04-25 19:41   
Code review + Testing OK