Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035689Openbravo ERP09. Financial managementpublic2017-04-04 16:522017-05-29 17:43
Reportermaite 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket46185
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035689: "Bank Revaluation" accounts defined in Financial Account | Accounting Configuration tab not used
DescriptionInstead of using specific account defined in Financial Account | Accounting Configuration tab, value configured in General Ledger Configuration | Defaults tab is used
Steps To Reproduce0. Access to General Ledger Configuration "F&B España, S.A. US/A/Euro" and set "Bank Revaluation Gain" = 10000 - Capital social ; "Bank Revaluation Loss"= 10100 - Fondo social
1. Access to "Cuenta de Banco - EUR" financial account and define "Transferencia" payment method as "allow payment in multiple currencies" and "In Transit Payment Account" as Upon Payment Use account
2. Verify that proper Bank Revaluation accounts are defined in Accounting Configuration tab for Cuenta de Banco financial account
3. Create new Price List for "F&B España, S.A" organization, "MXN" currency. Add price list version and add "Agua sin Gas 1L" product in Product Price setting price=5.00
4. Register new Purchase Invoice for "F&B España - Región Norte" organization, "Bebidas Alegres, S.L." business aprtner, invoice date=04/04/2017, using previous pricelist and add line for "Agua sin Gas 1L" product. Define conversion in Exchange Rates: from MXN to EUR as rate=2; from MXN to USD as rate=3. Process invoice
5. Register new Payment Out for same org, business partner, payment date= 05/04/2017, "Cuenta de Banco - EUR" financial account, "Transferencia" payment method, currency=MXN and Exchange rate =8. Add previous invoice and process
6. Post payment out and realize that instead of using "Bank Revaluation Loss" account defined in Financial Account | Accounting Configuration tab, the one defined in General Ledger Configuration | Defaults tab is used
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-04 16:52maiteNew Issue
2017-04-04 16:52maiteAssigned To => Triage Finance
2017-04-04 16:52maiteOBNetwork customer => Yes
2017-04-04 16:52maiteModules => Core
2017-04-04 16:52maiteSupport ticket => 46185
2017-04-04 16:52maiteResolution time => 1493071200
2017-04-04 16:52maiteTriggers an Emergency Pack => No
2017-04-04 16:52maiteIssue Monitored: networkb
2017-04-04 19:41aferrazAssigned ToTriage Finance => collazoandy4
2017-05-02 15:35collazoandy4Statusnew => scheduled
2017-05-03 23:26collazoandy4Note Added: 0096360
2017-05-04 13:13hgbotCheckin
2017-05-04 13:13hgbotNote Added: 0096380
2017-05-04 13:13hgbotStatusscheduled => resolved
2017-05-04 13:13hgbotResolutionopen => fixed
2017-05-04 13:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e16423fae9e6882bd819da729263d4714848e3cd [^]
2017-05-04 13:23aferrazReview Assigned To => aferraz
2017-05-04 13:23aferrazNote Added: 0096381
2017-05-04 13:23aferrazStatusresolved => closed
2017-05-04 13:23aferrazFixed in Version => 3.0PR17Q3
2017-05-04 13:51aferrazNote Deleted: 0096381
2017-05-04 13:52hgbotCheckin
2017-05-04 13:52hgbotNote Added: 0096382
2017-05-04 13:52aferrazNote Added: 0096383
2017-05-10 13:44hgbotCheckin
2017-05-10 13:44hgbotNote Added: 0096507
2017-05-10 13:45aferrazNote Deleted: 0096383
2017-05-10 13:45aferrazNote Added: 0096508
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096937
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096938
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096953

Notes
(0096360)
collazoandy4   
2017-05-03 23:26   
Test Plan
  As group admin role
    Go to General Ledger Configuration window
      Select F&B España, S.A. US/A/Euro record
        In The default tab edit the record and set "Bank Revaluation Gain" = 10000 - Capital social and "Bank Revaluation Loss"= 10100 - Fondo social
    Go to Financial Account window and select Cuenta de Banco - EUR record:
      Edit the Payment Method Transferencia and check Make Payments in Multiple Currencies option and In Transit Payment Account as Upon Payment Use account
    Go to Price List window and create a new record:
      Name: Issue Price List
      Currency: MXN
      Create a new record in Price List Version tab:
        Valid From Date: 01-01-2017
      In Product Price tab create a new record:
        Product: Agua sin Gas 1L
        Unit / List Price: 5
    Go to Purchase Invoice window and create a new record
      Business Partner: Bebidas Alegres, S.L.
      Price List: Issue Price List
      Create a new record in Lines tab:
        Product: Agua sin Gas 1L
      Create a new record in Exchange Rates tab:
        To Currency: EUR
        Rate: 2
      Create a new record in Exchange Rates tab:
        To Currency: USD
        Rate: 3
    Process the invoice
    Go to Payment Out and create a new record:
      Paying To: Bebidas Alegres, S.L.
      Currency: MXN
      Exchange Rate: 8
      Clic on Add Details and select previous invoice and process
      In Exchange Rate Tab create a new record:
        To Currency: USD
        Rate: 9
    Post Payment out and check that Bank Revaluation Loss account defined in Financial Account | Accounting Configuration tab is used
(0096380)
hgbot   
2017-05-04 13:13   
Repository: erp/devel/pi
Changeset: e16423fae9e6882bd819da729263d4714848e3cd
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed May 03 17:18:51 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/e16423fae9e6882bd819da729263d4714848e3cd [^]

Fixes issue 35689: Bank Revaluation Loss account defined in FA is not used

The Bank Revaluation Loss account defined in Financial Account | Accounting Configuration
tab is not used in the posting process of payment out document, the general ledger
configuration was used

A new field was added to the AcctServer to get the Financial Account ID when searching
in the account, the Account type in getAccount was change to the ACCTTYPE_ConvertChargeGainAmt
and ACCTTYPE_ConvertChargeLossAmt and also the selectConvertChargeLossAmt and selectConvertChargeGainAmt
methods was changed to get the Bank Account from financial account configuration

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/AcctServer_data.xsql
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
(0096382)
hgbot   
2017-05-04 13:52   
Repository: erp/devel/pi
Changeset: 7fb423e40bc107c6c179c4dd39ad3fb1cb6d9520
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu May 04 13:51:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7fb423e40bc107c6c179c4dd39ad3fb1cb6d9520 [^]

Related to issue 35689: Code review improvements

Set FIN_Financial_Account_ID also in DocFINFinAccTransaction.java.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
---
(0096507)
hgbot   
2017-05-10 13:44   
Repository: erp/devel/pi
Changeset: 4147730ef05b9a945d6a06b52304524234a20ba4
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed May 10 13:43:26 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4147730ef05b9a945d6a06b52304524234a20ba4 [^]

Related to issue 35689: Code review improvements

Set FIN_Financial_Account_ID also in DocFINReconciliation.java.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0096508)
aferraz   
2017-05-10 13:45   
Code review + Testing OK
(0096937)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096938)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096953)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test