0035668: API Change: delete Accounting Dimension window

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035668

Openbravo ERP

00. Application dictionary

public

2017-03-31 12:43

Reporter

vmromanos

Assigned To

dmitry_mezentsev

Priority

normal

Severity

major

Reproducibility

N/A

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR17Q3

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035668: API Change: delete Accounting Dimension window

Description

The Accounting Dimension window is obsolete and hidden (right now even deactivated).

This window is wrongly defined and made a test to fail. After deactivating the window, the same test is failing again because it has been modified to be executed for deactivated windows too (which for me has no sense, but this is another topic).

The best solution for Platform would be to delete this window definition, but this would create an API change (for example if a module creates a field or a tab in this window).

For me it has no sense to break our API so easily because one of our tests is testing inactive windows.
Breaking the API should be the last possibility for us, and only when we get a real benefit for our customers. Here I don't see any benefit, just the opposite.

Besides it would make sense to review & delete other inactive windows too (or even fields, menu entries, etc.) to be consistent with the approach of not having stuff defined in the Application Dictionary that is deactivated.

Steps To Reproduce

Proposed Solution

Additional Information