Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035665Openbravo ERPA. Platformpublic2017-03-31 11:402017-10-03 17:40
Reporterlorenzofidalgo 
Assigned Tocaristu 
PriorityurgentSeverityminorReproducibilitysometimes
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035665: Wrong behaviour filling some fields. In Financial Acc. || Transaction while filling Transaction Date, Accounting Date is deleted
DescriptionThere is a strange behaviour in Financial Acc. || Transaction that involves, at least, "Transaction Date", "Accounting Date" fields. Filling those input fields is not being properly performed (Check attached video).

Until now, it has been impossible to get it manually. But it is an stable error in CI and I have been able to record that regression locally.
One of the failures that is being reproduced in CI is:
https://ci.openbravo.com/view/qa/job/qa-pi-reconciliation-pgsql/695/ [^]

It seems it is the callout what induces that strange refresh in the field where the focus is placed. The "WrongBehaviourEvenWithSleepAdded" attached videos are different automation executions with different static sleeps added to test if it is affected by performance.
Steps To ReproduceCheck attached video to get complete trace.

Attached also an smoke test case (FRM0060_SetDateAfterFICCall.java) where the problem can be reproduced in a stable way.
Proposed SolutionIt seems that the root of the problem is in the test infrastructure itself: for Date items, the text box is cleared before entering the value.

This method is causing problems when trying to set a date value right after the FIC has been invoked.

This use case happens when after editing a field that invokes a callout the focus is immediately placed on a date field. Under this circumstances, the clear method is not working fine because at the same time the blur event of the date is fired. This event is fired by smartclient when disabling the form during the FIC call to calculate the results of the callout.

It must be reviewed if that clear() invokation can be safely removed.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035658 closed inigosanchez Fields redraws in grid view when a numeric field is referenced by a read only logic 
Attached Files? TransactionWronglyFilled (612,982) 2017-03-31 11:40
https://issues.openbravo.com/file_download.php?file_id=10630&type=bug
? WrongBehaviourEvenWithSleepAdded.avi (624,988) 2017-04-04 11:01
https://issues.openbravo.com/file_download.php?file_id=10640&type=bug
? WrongBehaviourEvenWithSleepAdded2 (609,926) 2017-04-04 11:01
https://issues.openbravo.com/file_download.php?file_id=10641&type=bug
? WrongBehaviourEvenWithSleepAdded3 (677,644) 2017-04-04 11:01
https://issues.openbravo.com/file_download.php?file_id=10642&type=bug
? WrongBehaviourEvenWithSleepAdded4 (688,120) 2017-04-04 11:02
https://issues.openbravo.com/file_download.php?file_id=10643&type=bug
? WrongBehaviourEvenWithSleepAdded5 (770,232) 2017-04-04 11:02
https://issues.openbravo.com/file_download.php?file_id=10644&type=bug
? FRM0060_SetDateAfterFICCall.java (4,875) 2017-09-21 19:42
https://issues.openbravo.com/file_download.php?file_id=11090&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-31 11:40lorenzofidalgoNew Issue
2017-03-31 11:40lorenzofidalgoAssigned To => platform
2017-03-31 11:40lorenzofidalgoFile Added: TransactionWronglyFilled
2017-03-31 11:40lorenzofidalgoModules => Core
2017-03-31 11:40lorenzofidalgoRegression level => Automated tests
2017-03-31 11:40lorenzofidalgoRegression introduced in release => pi
2017-03-31 11:40lorenzofidalgoTriggers an Emergency Pack => No
2017-04-04 10:59lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=14944#r14944
2017-04-04 11:01lorenzofidalgoFile Added: WrongBehaviourEvenWithSleepAdded.avi
2017-04-04 11:01lorenzofidalgoFile Added: WrongBehaviourEvenWithSleepAdded2
2017-04-04 11:01lorenzofidalgoFile Added: WrongBehaviourEvenWithSleepAdded3
2017-04-04 11:02lorenzofidalgoFile Added: WrongBehaviourEvenWithSleepAdded4
2017-04-04 11:02lorenzofidalgoFile Added: WrongBehaviourEvenWithSleepAdded5
2017-04-04 11:04lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=14945#r14945
2017-04-07 09:06alostaleRegression levelAutomated tests =>
2017-04-07 09:06alostaleRegression introduced in releasepi =>
2017-04-07 09:06alostalePriorityimmediate => high
2017-04-07 09:06alostaleStatusnew => acknowledged
2017-04-07 09:06alostaleRelationship addedrelated to 0035658
2017-04-07 11:02inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14980#r14980
2017-04-07 11:06inigosanchezNote Added: 0095893
2017-04-07 11:07inigosanchezNote Edited: 0095893bug_revision_view_page.php?bugnote_id=0095893#r14982
2017-06-06 08:46alostalePriorityhigh => urgent
2017-09-19 18:55caristuAssigned Toplatform => caristu
2017-09-19 18:55caristuStatusacknowledged => scheduled
2017-09-21 19:40caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15967#r15967
2017-09-21 19:40caristuProposed Solution updated
2017-09-21 19:42caristuFile Added: FRM0060_SetDateAfterFICCall.java
2017-09-21 19:42caristuProposed Solution updated
2017-09-21 19:42caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15968#r15968
2017-10-03 16:24caristuNote Added: 0099727
2017-10-03 16:24caristuAssigned Tocaristu => lorenzofidalgo
2017-10-03 16:24caristuStatusscheduled => feedback
2017-10-03 17:22lorenzofidalgoNote Added: 0099733
2017-10-03 17:23lorenzofidalgoAssigned Tolorenzofidalgo => caristu
2017-10-03 17:23lorenzofidalgoStatusfeedback => scheduled
2017-10-03 17:40caristuReview Assigned To => caristu
2017-10-03 17:40caristuNote Added: 0099739
2017-10-03 17:40caristuStatusscheduled => closed
2017-10-03 17:40caristuResolutionopen => no change required
2017-10-03 17:40caristuNote Edited: 0099739bug_revision_view_page.php?bugnote_id=0099739#r16031

Notes
(0095893)
inigosanchez   
2017-04-07 11:06   
(edited on: 2017-04-07 11:07)
It seems that this part of code is related with the reported problem (strange refresh in the field where the focus is placed). It should be checked (ob-view-form.js):
  ..........
  setDisabledWhenStillInFIC: function () {
    if (this.inFicCall) {
      this.disableForm(true);
    }
  },
  ..........
(0099727)
caristu   
2017-10-03 16:24   
Waiting for the QA team to confirm that this issue is caused by the behavior of the date items implemented in the test infrastructure itself. See [1].

[1] https://code.openbravo.com/tools/automation/pi-smoke/rev/4812b976e01a [^]
(0099733)
lorenzofidalgo   
2017-10-03 17:22   
I confirm that changeset [1] solves the problem. As we discussed, that malfunctioning was caused by a conflict between that "clear()" method and the callout that was being executed.

[1] https://code.openbravo.com/tools/automation/pi-smoke/rev/4812b976e01a [^]
(0099739)
caristu   
2017-10-03 17:40   
Issue not reproducible in a real environment.

This is an "artificial" issue solved with the following fix[1] in the testing infrastructure.

[1] https://code.openbravo.com/tools/automation/pi-smoke/rev/4812b976e01a [^]