0035655: Do not display Credit to Use grid in Add Payment in case negative payments

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035655

Openbravo ERP

09. Financial management

public

2017-03-30 14:15

2017-03-30 14:18

Reporter

aferraz

Assigned To

Triage Omni OMS

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Professional Appliance

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035655: Do not display Credit to Use grid in Add Payment in case negative payments

Description

Do not display Credit to Use grid in Add Payment in case negative payments.

Steps To Reproduce

1. Register Reversed Purchase Invoice for "Bebidas Alegres". Add line for any product, set qty=-10 and process.
2. Register Payment Out for "Bebidas Alegres" setting Generated Credit=1000. Process payment
3. Register Payment Out for "Bebidas Alegres". Run "Add details" process, select available credit and select only negative invoice line. Choose option "Refund amount to customer" in overpayment action combo and try to process payment.
Error "It is not possible to use credit in negative payments. Please, unselect credit records." will be raised

In order to improve user experience we should avoid selecting credit in this case, instead of raising an error.

Proposed Solution

Using credit in negative payments is not a supported action.
To improve user experience we should avoid selecting credit in this case, instead of raising an error.

When ever we process a purchase or sales invoice we should not display Select Credit Payments popup in case of negative payment.

When ever we change the amount in Add Payment process to a negative amount, we should unselect every record in Credit to Use grid and change the value of credit_to_use_display_logic to false in order to hide Credit to Use grid.

When ever we change the amount in Add Payment process to a positive amount and in case business partner has available credit, we should change the value of credit_to_use_display_logic to true in order to display Credit to Use grid.

Additional Information