Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035636Openbravo ERP07. Sales managementpublic2017-03-28 18:382017-05-29 17:43
ReporterSandrahuguet 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035636: Business partner selector get stuck in create lines from invoice in hgvol environment
DescriptionBusiness partner selector get stuck in create lines from invoice in hgvol environment
Steps To ReproduceIn a hgvol enviroment
-Login in the ERP
-Go to Sales Invoice window
-Create new record
-Select a business partner
-Click on create lines from
-Open business partner selector

Business partner selector get stuck, see screenshoot
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0009897 closed shuehner Business Partner selector is slow with many business partners 
depends on defect 0035210 closed markmm82 sequential scans in c_bpartner using partner selector drop down filter 
Attached Filespng createlinesfrom.png (66,806) 2017-03-28 18:39
https://issues.openbravo.com/file_download.php?file_id=10614&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-03-28 18:38SandrahuguetNew Issue
2017-03-28 18:38SandrahuguetAssigned To => Triage Finance
2017-03-28 18:38SandrahuguetOBNetwork customer => No
2017-03-28 18:38SandrahuguetModules => Core
2017-03-28 18:38SandrahuguetTriggers an Emergency Pack => No
2017-03-28 18:39SandrahuguetFile Added: createlinesfrom.png
2017-03-28 18:40SandrahuguetTag Attached: Performance
2017-03-30 13:44shuehnerOBNetwork customerNo => Yes
2017-03-30 13:44shuehnerResolution time => 1492639200
2017-03-30 13:44shuehnerSeverityminor => major
2017-03-30 20:13markmm82Assigned ToTriage Finance => markmm82
2017-03-30 20:15markmm82Statusnew => acknowledged
2017-04-04 22:57markmm82Statusacknowledged => scheduled
2017-04-12 14:06aferrazRelationship addedrelated to 0035210
2017-04-12 14:08aferrazRelationship addedrelated to 0009897
2017-04-12 14:50aferrazRelationship replaceddepends on 0035210
2017-04-20 19:21markmm82Note Added: 0096096
2017-04-24 18:59hgbotCheckin
2017-04-24 18:59hgbotNote Added: 0096141
2017-04-24 18:59hgbotStatusscheduled => resolved
2017-04-24 18:59hgbotResolutionopen => fixed
2017-04-24 18:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e833242c1051edf0af778d1621f27b44ac1bed3b [^]
2017-04-24 18:59aferrazReview Assigned To => aferraz
2017-04-24 18:59aferrazNote Added: 0096142
2017-04-24 18:59aferrazStatusresolved => closed
2017-04-24 18:59aferrazFixed in Version => 3.0PR17Q3
2017-04-26 16:21aferrazNote Added: 0096200
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096904

Notes
(0096096)
markmm82   
2017-04-20 19:21   
Test Plan:
In a hgvol enviroment
-Login in the ERP
-Go to Sales Invoice window
-Create new record
-Select a business partner
-Click on create lines from
-Open business partner selector

Notice that Business partner selector opens and grid is filled with filtered results.
(0096141)
hgbot   
2017-04-24 18:59   
Repository: erp/devel/pi
Changeset: e833242c1051edf0af778d1621f27b44ac1bed3b
Author: Mark <markmm82 <at> gmail.com>
Date: Sun Apr 16 13:16:12 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/e833242c1051edf0af778d1621f27b44ac1bed3b [^]

Fixes issue 35636: Business partner selector get stuck in create lines from
invoice in hgvol environment

In high volume environment, when the Business Partner selector is opened from Create
lines from process in the Invoice window, it takes too long to load results and as
consequence the browser was stocked.

To improve the performance in this selector, was changed the BusinessPartner_data.xsql
methods to use UPPER instead of C_IGNORE_ACCENT function, this way it uses the index
created in issue 35210 and improves of performance it introduces.

---
M src/org/openbravo/erpCommon/info/BusinessPartner_data.xsql
---
(0096142)
aferraz   
2017-04-24 18:59   
Code review + Testing OK
(0096200)
aferraz   
2017-04-26 16:21   
UPPER function will be used to filter by Business Partner name in Create Lines From process, which unlike C_IGNORE_ACCENT distinguishes between A and Á. Thus, it will behave same as normal BP selectors and will take advantage of index created in 0035210.
(0096904)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test