Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035635Openbravo ERP07. Sales managementpublic2017-03-28 17:552017-06-23 14:34
ReporterSandrahuguet 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionunable to reproduce 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035635: Performance should be improved when select a business partner in a new sales invoice
DescriptionPerformance should be improved when select a business partner in a new sales invoice in a hgvol enviroment.
when selecting bpartner the following log is shown in the openbravo.log:

DEBUG org.openbravo.client.application.window.FormInitializationComponent - Calling callout org.openbravo.erpCommon.ad_callou
cdb72c84 2017-03-28 09:20:07,622 [ajp-bio-127.0.0.1-8009-exec-3] DEBUG org.openbravo.client.application.window.FormInitializationComponent - Calling callout org.openbravo.erpCommon.ad_callou
cdb72c84 2017-03-28 09:20:08,732 [ajp-bio-127.0.0.1-8009-exec-3] DEBUG org.openbravo.client.application.window.FormInitializationComponent - Callout Name: SE_Invoice_BPartner

SE_Invoice_BPartner callout takes around 1s
Steps To ReproduceIn a hgvol enviroment
-As system admin
-Go to session preferences window
-Set org.openbravo.client.application.window.FormInitializationComponent to DEBUG

-Login in the ERP
-Go to Sales Invoice window
-Create new record
-Select a business partner

SE_Invoice_BPartner callout takes around 1s
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to design defect 0036067 closed markmm82 old callouts should be refactored to implement SimpleCallout 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-28 17:55SandrahuguetNew Issue
2017-03-28 17:55SandrahuguetAssigned To => Triage Finance
2017-03-28 17:55SandrahuguetModules => Core
2017-03-28 17:55SandrahuguetTriggers an Emergency Pack => No
2017-03-28 17:55SandrahuguetTag Attached: Performance
2017-03-29 09:58SandrahuguetSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14911#r14911
2017-04-03 13:50aferrazAssigned ToTriage Finance => markmm82
2017-06-02 13:53aferrazAssigned Tomarkmm82 => AtulOpenbravo
2017-06-03 08:06AtulOpenbravoStatusnew => scheduled
2017-06-09 14:17aferrazRelationship addedrelated to 0036067
2017-06-12 13:33AtulOpenbravoNote Added: 0097310
2017-06-12 13:34AtulOpenbravoNote Edited: 0097310bug_revision_view_page.php?bugnote_id=0097310#r15326
2017-06-12 13:46AtulOpenbravoNote Added: 0097311
2017-06-12 13:52AtulOpenbravoNote Added: 0097312
2017-06-12 14:02AtulOpenbravoNote Added: 0097314
2017-06-12 14:09AtulOpenbravoNote Added: 0097316
2017-06-12 14:14AtulOpenbravoNote Edited: 0097314bug_revision_view_page.php?bugnote_id=0097314#r15330
2017-06-12 14:26AtulOpenbravoNote Added: 0097317
2017-06-12 14:27AtulOpenbravoNote Edited: 0097317bug_revision_view_page.php?bugnote_id=0097317#r15332
2017-06-12 14:34AtulOpenbravoNote Added: 0097318
2017-06-12 14:35AtulOpenbravoNote Edited: 0097318bug_revision_view_page.php?bugnote_id=0097318#r15334
2017-06-12 14:41AtulOpenbravoNote Added: 0097319
2017-06-23 14:34aferrazReview Assigned To => aferraz
2017-06-23 14:34aferrazNote Added: 0097617
2017-06-23 14:34aferrazStatusscheduled => closed
2017-06-23 14:34aferrazResolutionopen => unable to reproduce
2017-06-23 14:34aferrazFixed in Version => 3.0PR17Q3

Notes
(0097310)
AtulOpenbravo   
2017-06-12 13:33   
(edited on: 2017-06-12 13:34)
31322 Test Plan

- Create new User with any username and password. Expand More information section and define "Alimentos y Supermercados" as business partner. Define "F&B International Group Admin" in User Roles tab
- Navigate to "Alimentos y Supermercados" business partner and go to Employee tab to define it as "is sales representative"
- Navigate to "Hoteles Buenas Noches, S.A." business partner and go to Customer tab to define its sales representative as "Javier Martín"
- Logout and login with new user
- Access Sales Invoice window.
   - Realize that Sales Representative field is filled with your user as default.
   - Select "Alimentos y Supermercados, S.A" business partner and realize that Sales Representative field is filled with your user.
   - Select "Hoteles Buenas Noches, S.A." business partner and realize that Sales Representative field is filled with "Javier Martín".
   - Select "Restaurantes Luna Llena, S.A." business partner and realize that Sales Representative field is filled with your user.
   
- Navigate to "Alimentos y Supermercados" business partner and go to Employee tab and unselect "is sales representative" checkbox.
- Access Sales Invoice window.
   - Realize that Sales Representative field is empty by default.
   - Select "Alimentos y Supermercados, S.A" business partner and realize that Sales Representative field is empty.
   - Select "Hoteles Buenas Noches, S.A." business partner and realize that Sales Representative field is filled with "Javier Martín".
   - Select "Restaurantes Luna Llena, S.A." business partner and realize that Sales Representative field is empty.
(0097311)
AtulOpenbravo   
2017-06-12 13:46   
14757 Test Plan

- Create a Payment Method.
  - Name: Test 14757 Payment Method
  - Organization: F&B Espana
- Create a Financial Account
  - Organization: F&B Espana
  - Name : Test 14757 Financial Account
  - Type: Bank
  - Currency EUR
- Add "Test 14757 Payment Method" payment method in above Financial Account.
- Go to Business Partner "Hoteles Buenas Noches, S.A." and realize that Customer Tab shows Financial Account as "Cuenta de Banco".
- Create a Sales Invoice for business partner "Hoteles Buenas Noches, S.A.".
- Change payment method to "Test 14757 Payment Method".
- Realize that information message is show as "Automatic actions could not be performed: selected payment method does not belong to the business partner default financial account or the default financial account is not accessible for the invoice's organization."
- Change payment method to "Transferencia". Realize that No message is shown.
(0097312)
AtulOpenbravo   
2017-06-12 13:52   
22673 Test Plan

- Nagivate to Business Partner "Alimentos y Supermercados, S.A", In Customer Tab, set On Hold flag = Yes, Make sure the Sales Invoice flag = Yes.

- Go to Sales Invoice and create a record for business partner "Alimentos y Supermercados, S.A"

- Realize as soon as business partner is selected, informative message is shown as "The business partner Alimentos y Supermercados, S.A is on hold for this document, therefore it is not possible to complete it.
"
- Cancel the invoice.

- Nagivate to Business Partner "Alimentos y Supermercados, S.A", In Customer Tab, set On Hold flag = No.

- Go to back to Sales Invoice and create a record for business partner "Alimentos y Supermercados, S.A". Realize no message is shown.
(0097314)
AtulOpenbravo   
2017-06-12 14:02   
(edited on: 2017-06-12 14:14)
Test Plan

- Nagivate to Business Partner "Alimentos y Supermercados, S.A", In Customer Tab make sure the following are set as below (if not set them)
  - Price List: Tarifa de ventas
  - Sales Representative: Javier Martín
  - Payment Method: Transferencia
  - Payment Terms: 30 days

- Create a Price List with name "01 Sales Price List", Organization: F&B Espana, Sales Price List flag = Yes

- Nagivate to Sales Invoice Window and create new record. Check that
  - Payment Method: Al contado
  - Payment Terms: 120 days
  - Sales Representative = Blank
  - Price List = 01 Sales Price List
  - Business Partner = Blank
  - Partner Address = Blank

- Select Business Partner as "Alimentos y Supermercados, S.A". Realize that as soon as partner is selected following values are set in the invoice header.
  - Payment Method: Transferencia
  - Payment Terms: 30 days
  - Sales Representative = Javier Martín
  - Price List = Tarifa de ventas
  - Partner Address = "La Coruña, C\Pescadores, 87"

Above test plan could be verified in Purchase Invoice for business partner "La Fruta es la Vida, S.L.".

- Navigate to Purchase Invoice and create new record.
- Realize the following
  - Payment Method: Al contado
  - Payment Terms: 120 days
  - Price List = Otros servicios
  - Business Partner = Blank
  - Partner Address = Blank

- Select business partner as "La Fruta es la Vida, S.L.". Realize the following is set as:-
  - Payment Method: Transferencia
  - Payment Terms: 60 days
  - Price List = Tarifa La Fruta es la Vida
  - Partner Address = ".Madrid, Pso. de la Castellana, 154"

- Payment Method, Payment Terms, Price List are the deafult value which comes from Vendor Tab of business partner.
(0097316)
AtulOpenbravo   
2017-06-12 14:09   
Test Plan

- Nagivate to Business Partner "Hoteles Buenas Noches, S.A." and realize that Current balance in the status bar has value 0.
- Create a Sales Invoice with business partner "Hoteles Buenas Noches, S.A.".
- Realize that No message is shown regarding Credit Limit over by.
- Add any line to it. Complete the Invoice with amount lets say 100 EUR.
- Create another Sales Invoice for business partner "Hoteles Buenas Noches, S.A.".
- Realize that as soon as business partner is selected a informative message is shown as

"Info
Note: Credit Limit over by 185.13"

- Check that this is not the case with Purchase Invoice for any business partner.
(0097317)
AtulOpenbravo   
2017-06-12 14:26   
(edited on: 2017-06-12 14:27)
20257 Test Plan

- Using System Administrator Role, Navigate to Windows Tab and Fields. Set Displayed = Yes of the User Contact field in Sales / Purchase Invoice Header Tab.
- Log out and Login with F&B International Group Admin role.
- Navigate to Business Partner "Hoteles Buenas Noches, S.A.".
- In Contact Tab, realize that there is record for "Marcos Pedro".
- Create a Sales Invoice for Business Partner "Hoteles Buenas Noches, S.A.".
- Realize that as soon as business Partner is selected, default value of User Contact is set as "Marcos Pedro".
- Cancel the Sales Invoice.
- Navigate to Business Partner "Hoteles Buenas Noches, S.A.", In Contact Tab,add new record with First Name as "01 Test 20257". Save Record.
- Create a Sales Invoice for Business Partner "Hoteles Buenas Noches, S.A.".
- Realize that as soon as business Partner is selected, User Contact is set as "01 Test 20257". From the list of two contacts first contact is set as default.

Similar test plan is valid for Purchase Invoice.
(0097318)
AtulOpenbravo   
2017-06-12 14:34   
(edited on: 2017-06-12 14:35)
20770 Test Plan

- Create a new Record in Purchase Invoice.
- Realize that Partner Address field is blank.
- Select business partner as "La Fruta es la Vida, S.L."
- Realize that Partner Address is set as ".Madrid, Pso. de la Castellana, 154".
- Cancel Purchase Invoice.
- Navigate to Business Partner "La Fruta es la Vida, S.L.", Location Address Tab.
- Realize that single entry for address with name "Pso. de la Castellana, 154 - - 28567 - Madrid - MADRID - Spain" exists.
- Create one more address with the following details
        - 1st Line: "01 Test 20770 Address"
        - Country : Spain
        - Save Record.

- Now realize that "La Fruta es la Vida, S.L.", business partner has two location address.

- Go back to Purchase Invoice window and create a record. Select business partner "La Fruta es la Vida, S.L.".

- Realize that Partner Address is set with "., 01 Test 20770 Address" value as this is the first value in the address list.

Similar test is valid for Sales Invoice window.
(0097319)
AtulOpenbravo   
2017-06-12 14:41   
23229 Test Plan

- Nagivate to Business Partner "Hoteles Buenas Noches, S.A." and realize that Current balance in the status bar has value 0.
- Create a Sales Invoice with business partner "Hoteles Buenas Noches, S.A.".
- Realize that No message is shown regarding Credit Limit over by.
- Add any line to it. Complete the Invoice with amount lets say 100 EUR.
- Navigate to Business Partner "Hoteles Buenas Noches, S.A.", In Customer Tab, set On Hold flag = Yes, Make Sure Sales Invoice flag = Yes.
- Create another Sales Invoice for business partner "Hoteles Buenas Noches, S.A.".
- Realize that as soon as business partner is selected a informative message is shown as

"Info
The business partner Hoteles Buenas Noches, S.A. is on hold for this document, therefore it is not possible to complete it.
Note: Credit Limit over by 100"

Check that above message includes document hold message along with the Credit Limit over by information.
(0097617)
aferraz   
2017-06-23 14:34   
Checked in BUT machine SE_Invoice_BPartner callout is taking less than one second (around 100 ms.)