Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035631Retail ModulesWeb POSpublic2017-03-28 11:122017-04-28 12:22
Reporteramayavicente 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035631: [SERQA 2676] In step count cash in cash ups it is not possible to enter negative amounts
DescriptionIn step count cash during the cash up process, it is not possible to enter negative amounts
Steps To Reproduce1. Make returns in Card until get a negative amount.
2. Open the menu option cahs up.
3. Go to step 2 of 4: Count Cash.
ERROR: it is not possible to enter a negative amount, for instance, to do a correction in a payment method with a negative total amount.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
causes defect 0039618 closed rqueralta Cash Up goes to Errors While Importing POS Data if the currency has more than 2 decimals and negative total 
Attached Filespatch issue 35631 source posterminal.patch (3,674) 2017-04-03 11:17
https://issues.openbravo.com/file_download.php?file_id=10634&type=bug
patch issue 35631 source mobilecore.patch (1,019) 2017-04-03 11:17
https://issues.openbravo.com/file_download.php?file_id=10635&type=bug
patch issue 35631 test.patch (4,071) 2017-04-03 11:17
https://issues.openbravo.com/file_download.php?file_id=10636&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-28 11:12amayavicenteNew Issue
2017-03-28 11:12amayavicenteAssigned To => Retail
2017-03-28 11:12amayavicenteResolution time => 1491861600
2017-03-28 11:12amayavicenteTriggers an Emergency Pack => No
2017-03-28 11:12amayavicenteTag Attached: SER-QA
2017-03-28 11:43amayavicenteSummary[SERQA 2678] In step count cash in cash ups it is not possible to enter negative amounts => [SERQA 2676] In step count cash in cash ups it is not possible to enter negative amounts
2017-03-29 14:12ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-03-29 14:12ranjith_qualiantech_comStatusnew => scheduled
2017-04-03 11:17ranjith_qualiantech_comFile Added: issue 35631 source posterminal.patch
2017-04-03 11:17ranjith_qualiantech_comFile Added: issue 35631 source mobilecore.patch
2017-04-03 11:17ranjith_qualiantech_comFile Added: issue 35631 test.patch
2017-04-03 13:52hgbotCheckin
2017-04-03 13:52hgbotNote Added: 0095801
2017-04-03 13:53hgbotCheckin
2017-04-03 13:53hgbotNote Added: 0095802
2017-04-03 13:53hgbotStatusscheduled => resolved
2017-04-03 13:53hgbotResolutionopen => fixed
2017-04-03 13:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/899ed523bfa156f269cab857c8fe5d0573f7718c [^]
2017-04-03 14:00hgbotCheckin
2017-04-03 14:00hgbotNote Added: 0095803
2017-04-07 14:36marvintmNote Added: 0095916
2017-04-07 14:36marvintmStatusresolved => new
2017-04-07 14:36marvintmResolutionfixed => open
2017-04-10 07:28ranjith_qualiantech_comStatusnew => scheduled
2017-04-10 10:48hgbotCheckin
2017-04-10 10:48hgbotNote Added: 0095930
2017-04-10 10:48hgbotStatusscheduled => resolved
2017-04-10 10:48hgbotResolutionopen => fixed
2017-04-10 10:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/899ed523bfa156f269cab857c8fe5d0573f7718c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb771ad2a6b524fbead359791900a14a30b93c12 [^]
2017-04-11 16:13marvintmNote Added: 0095988
2017-04-11 16:13marvintmStatusresolved => new
2017-04-11 16:13marvintmResolutionfixed => open
2017-04-12 07:02ranjith_qualiantech_comStatusnew => scheduled
2017-04-12 12:54hgbotCheckin
2017-04-12 12:54hgbotNote Added: 0096025
2017-04-12 12:54hgbotStatusscheduled => resolved
2017-04-12 12:54hgbotResolutionopen => fixed
2017-04-12 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb771ad2a6b524fbead359791900a14a30b93c12 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/264c8c163463402ea5d3cf3f27504c646235c82e [^]
2017-04-12 12:55hgbotCheckin
2017-04-12 12:55hgbotNote Added: 0096026
2017-04-28 12:22marvintmReview Assigned To => marvintm
2017-04-28 12:22marvintmStatusresolved => closed
2017-04-28 12:22marvintmFixed in Version => RR17Q3
2018-11-13 15:48ngarciaRelationship addedcauses 0039618
2018-12-28 09:03ngarciaRelationship addedcauses 0039861
2018-12-28 09:14ngarciaRelationship deletedcauses 0039861

Notes
(0095801)
hgbot   
2017-04-03 13:52   
Repository: tools/automation/pi-mobile
Changeset: a0d04e77f681a76dd59b18610118f89d5ad9f0d9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 03 17:21:32 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a0d04e77f681a76dd59b18610118f89d5ad9f0d9 [^]

Verifies issue 35631 : Added automated test 'I35631_VerifyCashupKeyboard'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I35631_VerifyCashupKeyboard.java
---
(0095802)
hgbot   
2017-04-03 13:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 899ed523bfa156f269cab857c8fe5d0573f7718c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 03 17:22:00 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/899ed523bfa156f269cab857c8fe5d0573f7718c [^]

Fixes issue 35631 : Enabled Negative Symbol in Cashup Keyboard

* In Cashup Step 2, Negative Amount should not be allowed for Cash payment methods

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/closecash/view/closekeyboard.js
---
(0095803)
hgbot   
2017-04-03 14:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c0f7d11e99f8524df1c8804bcd90685d0c291e2e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 03 17:21:36 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0f7d11e99f8524df1c8804bcd90685d0c291e2e [^]

Related to issue 35631 : Enabled Minus key in Cashup Keyboard

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0095916)
marvintm   
2017-04-07 14:36   
The change in the UI side is correct. However, when you specify a negative counted amount, and at the same time automate the movement of the payment method, the cashup process generates a transaction in the payment method financial account with negative withdrawal amount, and a transaction in the bank account with negative deposit amount.

Instead, it should generate a transaction in the payment method financial account with positive deposit amount, and a transaction in the bank account with positive withdrawal amount.
(0095930)
hgbot   
2017-04-10 10:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb771ad2a6b524fbead359791900a14a30b93c12
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 10 14:08:12 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb771ad2a6b524fbead359791900a14a30b93c12 [^]

Fixes issue 35631 : Transaction should be updated if any negative payments are present

* If there are negative payment from payment methods then payment method fin. transaction should be updated with positive deposit amount instead of negative withdrawal amount
  and for bank account transaction, it should be update with positive withdrawal amount instead of negative deposit amount

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0095988)
marvintm   
2017-04-11 16:13   
Now the amount correctly goes to either the deposit or the payment column depending on whether it is positive or negative, but the transaction type is not changed. It should be changed to BPD or BPW depending on it being a deposit or a withdrawal.
(0096025)
hgbot   
2017-04-12 12:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 264c8c163463402ea5d3cf3f27504c646235c82e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 12 16:24:00 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/264c8c163463402ea5d3cf3f27504c646235c82e [^]

Fixes issue 35631 : Transaction should be updated if any negative payments are present

* Transaction type updated based on withdrawel/deposit amounts

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0096026)
hgbot   
2017-04-12 12:55   
Repository: tools/automation/pi-mobile
Changeset: 032a790d20e95d1dba49edeca0ded6bae7dde598
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 12 16:24:09 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/032a790d20e95d1dba49edeca0ded6bae7dde598 [^]

Verifies issue 35631 : Modified automated test 'I35631_VerifyCashupKeyboard'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I35631_VerifyCashupKeyboard.java
---