Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035627Openbravo ERP09. Financial managementpublic2017-03-10 10:492017-03-29 09:20
Reporterngarcia 
Assigned Tomarkmm82 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q4.4Fixed in Version3.0PR16Q4.4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/66e8497a06cb [^]
Triggers an Emergency PackNo
Summary0035627: It is possible to create a bank fee transaction in financial account with both deposit and withdrawal amount different from 0
DescriptionIt is possible to create a bank fee transaction in financial account with both deposit and withdrawal amount different from 0
Steps To ReproduceAs group admin role:

1. Create a new record in Financial Account - Transaction tab
   Set Transaction Type as Bank fee
   Set a value different from 0 in the Deposit Amount field
   Set a value different from 0 in the Withdrawal Amount field
   Check you can save and process it and you should not

2. Select a Financial Account with a Matching Algorithm defined
   Create a record in Imported Bank Statements record
   Add a line to it and process it
   Click on Match Statement process button
   Cancel the algorithm to be run
   Add a new transaction (+ button in Match column)
   Set Transaction Type as Bank fee
   Check the amount is reset to 0 (See note)
   Set a value different from 0 in the Deposit Amount field
   Set a value different from 0 in the Withdrawal Amount field
   Check you can process it and you should not
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035477 closed markmm82 It is possible to create a bank fee transaction in financial account with both deposit and withdrawal amount different from 0 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-27 23:29markmm82Typedefect => backport
2017-03-27 23:29markmm82Target Version => 3.0PR16Q4.4
2017-03-28 12:42aferrazRegression date2015-05-06 => 2014-09-23
2017-03-28 12:42aferrazRegression introduced in release3.0PR15Q1.3 => 3.0PR14Q4
2017-03-28 20:42aferrazSeveritymajor => minor
2017-03-29 09:18hgbotCheckin
2017-03-29 09:18hgbotNote Added: 0095624
2017-03-29 09:18hgbotStatusscheduled => resolved
2017-03-29 09:18hgbotResolutionopen => fixed
2017-03-29 09:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q4.4/rev/b039e61dc09ee1b94c6783b0e77201cefc18427d [^]
2017-03-29 09:20aferrazReview Assigned To => aferraz
2017-03-29 09:20aferrazNote Added: 0095626
2017-03-29 09:20aferrazStatusresolved => closed
2017-03-29 09:20aferrazFixed in Version => 3.0PR16Q4.4

Notes
(0095624)
hgbot   
2017-03-29 09:18   
Repository: erp/backports/3.0PR16Q4.4
Changeset: b039e61dc09ee1b94c6783b0e77201cefc18427d
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Mar 28 09:26:09 2017 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4.4/rev/b039e61dc09ee1b94c6783b0e77201cefc18427d [^]

Fixes issue 35627: Avoid Financial Account transactions with both amounts != 0

Following changes have been done in Financial Account Transaction tab and in Add Transaction process definition:
When changing to Bank Fee transaction type, amounts will not be updated to zero.
When changing Deposit Amount in case Bank Fee transaction type, Withdrawal Amount will be updated to zero.
When changing Withdrawal Amount in case Bank Fee transaction type, Deposit Amount will be updated to zero.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Trxtype_Transaction.java
A src/org/openbravo/erpCommon/ad_callouts/SE_Amount_Transaction.java
---
(0095626)
aferraz   
2017-03-29 09:20   
Code review + Testing OK