Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035616ModulesWarehouse Pickingpublic2017-03-24 14:272017-05-30 12:17
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0035616: Wrong stock reservation when deleting partially shipped orders' picking lists lines
DescriptionWrong stock reservation when deleting partially shipped orders' picking lists lines
Steps To ReproduceAs group admin role:
   Apply the module's dataset in F&B US Inc.
   Set the Enable Stock Reservations preference to Y
   Log out and log in

   The following case is still failing:

As group admin role:
   Apply the module's dataset in F&B US Inc.
   Set the Enable Stock Reservations preference to Y
   Log out and log in

   Create a new product in F&B US Inc.
   Receive the following units of it:
      - 40 units in WC-0-0-0
      - 40 units in WC-1-0-0
      - 40 units in WC-2-0-0
   Create a sales order of 100 units of the product
   Generate Picking List from it
   Delete the lines in bins WC-1-0-0 and WC-2-0-0
   Edit the line in bin WC-0-0-0 and reduce the quantity to 5
   Process it
   Generate a new Picking List from the order
   Delete the line from the WC-0-0-0 bin
   Check the stock reservation line has:
      Quantity: 10
      Released: 5
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0035542 closed aferraz Wrong stock reservation when deleting lines or canceling partially shipped orders' picking lists 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-24 14:27ngarciaNew Issue
2017-03-24 14:27ngarciaAssigned To => aferraz
2017-03-24 14:27ngarciaResolution time => 1491429600
2017-03-24 14:27ngarciaIssue generated from0035542
2017-03-24 14:28ngarciaAssigned Toaferraz => Triage Finance
2017-03-24 14:28ngarciaRelationship addeddepends on 0035542
2017-03-24 14:28ngarciaIssue Monitored: networkb
2017-03-24 16:01markmm82Assigned ToTriage Finance => collazoandy4
2017-03-24 16:30jfrancesIssue Monitored: jfrances
2017-03-29 16:03collazoandy4Statusnew => scheduled
2017-03-29 21:50collazoandy4Note Added: 0095681
2017-04-06 13:22hgbotCheckin
2017-04-06 13:22hgbotNote Added: 0095863
2017-04-06 13:22hgbotStatusscheduled => resolved
2017-04-06 13:22hgbotResolutionopen => fixed
2017-04-06 13:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e6241c8cf7e7155ff63051c48df403aa878b9cf5 [^]
2017-04-06 13:22hgbotCheckin
2017-04-06 13:22hgbotNote Added: 0095864
2017-04-06 13:22hgbotCheckin
2017-04-06 13:22hgbotNote Added: 0095865
2017-04-06 13:24aferrazReview Assigned To => aferraz
2017-04-06 13:24aferrazNote Added: 0095866
2017-04-06 13:24aferrazStatusresolved => closed
2017-05-30 12:17eugeniIssue Monitored: eugeni

Notes
(0095681)
collazoandy4   
2017-03-29 21:50   
As group admin role:
   Apply the module's dataset in F&B US Inc.
   Set the Enable Stock Reservations preference to Y
   Log out and log in

   Create a new product in F&B US Inc.
     Product: Issue 35616
     Create a new record in Price tab:
       Price List Version: General Sales
       Unit Price: 6
       List Price: 8
   Create a new Goods Receipt:
     Business Partner: Be Soft Drinker, Inc.
     Create a new record in Lines tab:
       Product: Issue 35616
       Movement Quantity: 40
       Storage bin: WC-0-0-0
     Create a new record in Lines tab:
       Product: Issue 35616
       Movement Quantity: 40
       Storage bin: WC-1-0-0
     Create a new record in Lines tab:
       Product: Issue 35616
       Movement Quantity: 40
       Storage bin: WC-2-0-0
     Complete the receipt
   Create a new Sales Order
     Business Partner: Healthy Food Supermarkets, Co.
     Create a new record in Lines tab:
       Product: Issue 35616
       Ordered qty: 100
     Book the order
     Generate a Picking List
   Go to Warehouse Picking List select the created picking:
     Delete the lines in bins WC-1-0-0 and WC-2-0-0
     Edit the line in bin WC-0-0-0 and set the quantity to 5
     Process the picking list
   Generate a new Picking List from the order
   Delete the line from the WC-0-0-0 bin
   Check the stock reservation line has:
      Quantity: 5
      Released: 5


Test Plan II
  Create a new Sales Order
     Business Partner: Healthy Food Supermarkets, Co.
     Create a new record in Lines tab:
       Product: Lemonade
       Ordered qty: 20
     Book the order
     Generate a Picking List
   Go to Warehouse Picking List select the created picking:
     Edit the line in bin WC-0-0-0 and set the quantity to 5
     Process the picking list
   Check the stock reservation Quantity/Released = 5
   Generate a new Picking List from the order
   Check the stock reservation Quantity = 20 Released = 5
   Delete the line
   Check the stock reservation line has updated to Quantity/Released = 5
(0095863)
hgbot   
2017-04-06 13:22   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: e6241c8cf7e7155ff63051c48df403aa878b9cf5
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Apr 04 13:05:11 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/e6241c8cf7e7155ff63051c48df403aa878b9cf5 [^]

Fixes issue 35616: Deleting PL lines with reservation stock releasedqty > 0

When deleting Picking List lines and the releasedqty of the reservation stock
is greater than 0 the stock reservation quantity is not properly updated.

Now the subtraction between the shipment inout line movementqty and the stock releasedqty
it's skipped if the stock reservation quantity is greater than the movementqty because
this movementqty have no effect in the stock reservation releasedqty updating
properly the stock reservation qty by the M_RESERVE_STOCK_MANUAL process

---
M src/org/openbravo/warehouse/pickinglist/actionhandler/DeletePickingLineHandler.java
---
(0095864)
hgbot   
2017-04-06 13:22   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: fcb18471812de28c0d29405be38b820bb9943bec
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 06 13:11:31 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/fcb18471812de28c0d29405be38b820bb9943bec [^]

Related to issue 35616: Code review improvements

---
M src/org/openbravo/warehouse/pickinglist/actionhandler/DeletePickingLineHandler.java
---
(0095865)
hgbot   
2017-04-06 13:22   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 0eb111625ff907ebd1c4541c1fc442534f8a1f9f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 06 13:21:10 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/0eb111625ff907ebd1c4541c1fc442534f8a1f9f [^]

Related to issue 35616: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0095866)
aferraz   
2017-04-06 13:24   
Code review + Testing OK