Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035612Retail ModulesStoreServerpublic2017-03-24 13:342017-03-29 13:54
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035612: SynchronizationPropertiesFileBuilder should not read template from source path
DescriptionThe SynchronizationPropertiesFileBuilder is currently reading a template from the source path, see [1]. It is not guaranteed that this development is deployed in an environment that contains the sources, so the template should be read from WebContent.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/72e395e33639/src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java#l275 [^]
Steps To ReproduceIn a multiserver environment:
- Rename the file src/org/openbravo/replication/symmetricds/util/engine-properties.ftl of the module org.openbravo.replicate.symmetricds. With this the lack of sources will be simulated.
- Try to start Tomcat. An error will be shown because the template propertiles file will not be found.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-24 13:34AugustoMauchNew Issue
2017-03-24 13:34AugustoMauchAssigned To => AugustoMauch
2017-03-24 13:34AugustoMauchTriggers an Emergency Pack => No
2017-03-24 13:39AugustoMauchReview Assigned To => mtaal
2017-03-24 13:40hgbotCheckin
2017-03-24 13:40hgbotNote Added: 0095557
2017-03-24 13:40hgbotStatusnew => resolved
2017-03-24 13:40hgbotResolutionopen => fixed
2017-03-24 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/7a9c13cef378f084fdb5ecd61de8971dc3de76b7 [^]
2017-03-24 14:44shuehnerIssue Monitored: shuehner
2017-03-27 09:19hgbotCheckin
2017-03-27 09:19hgbotNote Added: 0095582
2017-03-29 13:54mtaalNote Added: 0095644
2017-03-29 13:54mtaalStatusresolved => closed

Notes
(0095557)
hgbot   
2017-03-24 13:40   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 7a9c13cef378f084fdb5ecd61de8971dc3de76b7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Mar 24 13:39:17 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/7a9c13cef378f084fdb5ecd61de8971dc3de76b7 [^]

Fixes issue 35612: Template file is no longer read from the source path

Instead of reading the template from the source path, it is read from webcontent by using this command:

    URL resourceUrl = SynchronizationPropertiesFileBuilder.class.getResource(TEMPLATE_PATH);
    File f = new File(resourceUrl.getPath());

---
M src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java
---
(0095582)
hgbot   
2017-03-27 09:19   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: e9953da38eeaf0e26b7baa5fbda05b66d4ee2939
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 27 09:18:38 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/e9953da38eeaf0e26b7baa5fbda05b66d4ee2939 [^]

Related with issue 35612: Removes unused field

---
M src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java
---
(0095644)
mtaal   
2017-03-29 13:54   
Reviewed