Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035610Openbravo ERP07. Sales managementpublic2017-03-24 09:362017-05-29 17:43
Reportermaite 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket45932
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035610: Unhomogeneous behavior depending on process used to create sales invoice
DescriptionHaving a Sales Order document with "Order Reference" value, when sales invoice is created using a process which executes "C_INVOICE_CREATE" function extra line with only description information is added in sales invoice document
Steps To Reproduce1. Register Sales Order for "F&B España - Región Norte" organization, "Hoteles Buenas Noches, S.A." business partner, "After Order Delivered" invoice terms and "reference1" in Order Reference field. Add line for "Cerveza Ale 0,5L" product and process
2. Access "Create Shipments from Orders" and run process from previous order
3. Access "Create Invoices from Orders" and run process from previous order
4. Access Sales Invoice document and verify that extra line with lineno=0, qty=0, price=0 and only description "Delivery Note 1000216 (referencia1)" has been added
5. Register similar Sales Order setting Order Reference as "reference2"
6. Register Goods Shipment document for same org and bp and set Order Reference as "reference2". Run "Create lines from" process selecting previous order and process
7. Register Sales Invoice document for same org and bp and set Order Reference as "reference2". Run "Create lines from" process selecting previous order and process. Realize that no extra sales inovoice line has been added

This is wrong as similar sales invoice document should be obtained independently of process used to create it
Proposed Solutionremove this extra line with only description as Order Reference information is on document's header
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-24 09:36maiteNew Issue
2017-03-24 09:36maiteAssigned To => Triage Finance
2017-03-24 09:36maiteOBNetwork customer => Yes
2017-03-24 09:36maiteModules => Core
2017-03-24 09:36maiteSupport ticket => 45932
2017-03-24 09:36maiteResolution time => 1492120800
2017-03-24 09:36maiteTriggers an Emergency Pack => No
2017-03-24 09:37maiteIssue Monitored: networkb
2017-03-24 09:38maiteProposed Solution updated
2017-03-24 16:01markmm82Assigned ToTriage Finance => collazoandy4
2017-03-24 18:21mcobasAssigned Tocollazoandy4 => mcobas
2017-03-24 18:21mcobasStatusnew => scheduled
2017-03-28 15:53markmm82Assigned Tomcobas => markmm82
2017-03-29 21:51markmm82Note Added: 0095682
2017-04-03 16:16hgbotCheckin
2017-04-03 16:16hgbotNote Added: 0095811
2017-04-03 16:16hgbotStatusscheduled => resolved
2017-04-03 16:16hgbotResolutionopen => fixed
2017-04-03 16:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bf0a4aedda523f0ec58a67d78587f857d54df2b4 [^]
2017-04-03 16:34aferrazReview Assigned To => aferraz
2017-04-03 16:34aferrazNote Added: 0095815
2017-04-03 16:34aferrazStatusresolved => closed
2017-04-03 16:34aferrazFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096861

Notes
(0095682)
markmm82   
2017-03-29 21:51   
Test Plan:
1. Register Sales Order:
   Organization = "F&B España - Región Norte" organization,
   Business partner = "Hoteles Buenas Noches, S.A.",
   Invoice terms = "After Order Delivered",
   Order Reference = "reference1" in Order Reference field of More information section.
2. Add line for "Cerveza Ale 0,5L" product and process.
3. Run "Create Shipments from Orders"
   Select previously created previous order and process.
   Notice it creates a new Goods Shipment with Order reference = "reference1"
4. Access "Create Invoices from Orders"
   Select previous created order and process
   Notice it creates a new Sales Invoice
5. Access created Sales Invoice document and verify:
   No extra line was created
   Go to Sales invoice header and check that Order reference = "reference1"
(0095811)
hgbot   
2017-04-03 16:16   
Repository: erp/devel/pi
Changeset: bf0a4aedda523f0ec58a67d78587f857d54df2b4
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Mar 29 15:34:57 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bf0a4aedda523f0ec58a67d78587f857d54df2b4 [^]

Fixes issue 35610: Unhomogeneous behavior on process used to create sales invoice

Having a Sales Order document with "Order Reference" value, when sales
invoice is created using a process which executes "C_INVOICE_CREATE" function,
extra line with only description information is added in sales invoice document.

As executing "Create Invoices from Orders" process, Order Reference information
is stored on invoice's header, it is not needed to create a line just to log this
information on Description field.

To get an homogeneous behavior, this extra line it is not created.

Were removed from the C_INVOICE_CREATE function all variables and code fragments
used to get this reference and create this extra line with it, as they will be
unused with this solution.

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0095815)
aferraz   
2017-04-03 16:34   
Code review + Testing OK
(0096861)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test