Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035607Retail ModulesWeb POSpublic2017-03-23 13:362017-05-08 12:02
Reportermarvintm 
Assigned Toguilleaer 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035607: Direct navigation to windows bypasses approval checks
DescriptionCurrently, the only way to define approvals for windows is to set them in the menu entry. This works if the user navigates to them through the menu, but if the user navigates to the window directly by typing the URL the approval is then not checked.
Steps To Reproduce- Define approval for the main user in Cash management window.
- Navigate to the window by using the menu. Verify that the approval is shown. This is correct.
- Navigate to it by adding the corresponding URL tag: #retail.cashmanagement. Verify that the approval is not shown. This is not correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-23 13:36marvintmNew Issue
2017-03-23 13:36marvintmAssigned To => Retail
2017-03-23 13:36marvintmOBNetwork customer => No
2017-03-23 13:36marvintmTriggers an Emergency Pack => No
2017-04-12 11:42hgbotCheckin
2017-04-12 11:42hgbotNote Added: 0096012
2017-04-12 11:42hgbotStatusnew => resolved
2017-04-12 11:42hgbotResolutionopen => fixed
2017-04-12 11:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0b32b2cd2e20e40af7008ab7e2e63112cb732ca [^]
2017-04-12 11:42hgbotCheckin
2017-04-12 11:42hgbotNote Added: 0096013
2017-04-12 11:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0b32b2cd2e20e40af7008ab7e2e63112cb732ca [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/012655d62a2b16969cdd2545406a6d04fe146d67 [^]
2017-04-12 11:43hgbotCheckin
2017-04-12 11:43hgbotNote Added: 0096014
2017-04-12 11:43hgbotCheckin
2017-04-12 11:43hgbotNote Added: 0096015
2017-04-12 12:32marvintmAssigned ToRetail => marvintm
2017-05-02 12:28guilleaerAssigned Tomarvintm => guilleaer
2017-05-02 13:04hgbotCheckin
2017-05-02 13:04hgbotNote Added: 0096309
2017-05-02 13:50hgbotCheckin
2017-05-02 13:50hgbotNote Added: 0096310
2017-05-02 14:01hgbotCheckin
2017-05-02 14:01hgbotNote Added: 0096311
2017-05-04 09:05hgbotCheckin
2017-05-04 09:05hgbotNote Added: 0096363
2017-05-08 12:02marvintmReview Assigned To => marvintm
2017-05-08 12:02marvintmStatusresolved => closed
2017-05-08 12:02marvintmFixed in Version => RR17Q3

Notes
(0096012)
hgbot   
2017-04-12 11:42   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c0b32b2cd2e20e40af7008ab7e2e63112cb732ca
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 12 11:03:14 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0b32b2cd2e20e40af7008ab7e2e63112cb732ca [^]

Fixed issue 35607: Window approvals will be shown when navigate is done instead of when menu option is clicked

- an error is shown if user lack of permissions to access to a specific window
- Actions after call to OBMOBC_PreWindowNavigate has been reduced because they have been moved to the hook OBMOBC_PreWindowNavigate
- new hook OBMOBC_PreWindowNavigate
- windows can register which is the default window
- approvals popup will work without any model (also with model if it is passed)
- new function to manage routing. This function also will execute OBMOBC_PreWindowNavigate
- defaultwindow now stores the default window. Previous use of this field is mantained but now this field is called -nextWindow-

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
M web/org.openbravo.mobile.core/source/model/ob-router.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0096013)
hgbot   
2017-04-12 11:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 012655d62a2b16969cdd2545406a6d04fe146d67
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 12 10:55:37 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/012655d62a2b16969cdd2545406a6d04fe146d67 [^]

Fixed issue 35607: Window approvals will be shown when navigate is done instead of when menu option is clicked

- new hook OBMOBC_PreWindowNavigate
- retail.pointofsale will be the default window
- check approval function moved to utils file, now it works even if a model is not received
- old check approval method (included in windowmodel) has been deprecated
- renamed -defaultwindow- now it is called -nextwindow-. -defaultwindow will store the default window
- navigateTo function, included when window are registeres will not include navigate instruction. Success callback will be excuted instead

---
M web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js
M web/org.openbravo.retail.posterminal/js/components/menuhook.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/main.js
M web/org.openbravo.retail.posterminal/js/model/terminal-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0096014)
hgbot   
2017-04-12 11:43   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: f5efeaede58a209acd0b9a392659e12d9113b13c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 12 11:39:20 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/f5efeaede58a209acd0b9a392659e12d9113b13c [^]

Related to issue 35607: Mobile procurement will use next window if it existe. mainPOP is now the default window

---
M web/org.openbravo.mobile.procurement/source/pointofpurchase/mpr-popurchase-view.js
M web/org.openbravo.mobile.procurement/source/terminal/mpr-terminal.js
---
(0096015)
hgbot   
2017-04-12 11:43   
Repository: erp/pmods/org.openbravo.mobile.warehouse
Changeset: d3a8013b04cba3592f836bd8389f6a4067bf242c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 12 11:33:45 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/d3a8013b04cba3592f836bd8389f6a4067bf242c [^]

Related to issue 35607: use next window instead of default window. Menu is now the default window

---
M web/org.openbravo.mobile.warehouse/source/mainMenu/wh-menu-view.js
M web/org.openbravo.mobile.warehouse/source/terminal/wh-terminal.js
---
(0096309)
hgbot   
2017-05-02 13:04   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 38eb6c9a1e4d420b83b881e0dc06339e6c10b12e
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 02 13:03:34 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/38eb6c9a1e4d420b83b881e0dc06339e6c10b12e [^]

Related to issue 35607: Check if log is available before write log

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0096310)
hgbot   
2017-05-02 13:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e34072689bfff2bad4b07a92c382b946c52ae051
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 02 13:49:42 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e34072689bfff2bad4b07a92c382b946c52ae051 [^]

Related to issue 35607: Show warn instead of error. Fix problem saving log when OB.MobileApp.model is not ready

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0096311)
hgbot   
2017-05-02 14:01   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 5751227bfe3c7eda7eb550ec7d004f288a9f1543
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 02 14:00:49 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/5751227bfe3c7eda7eb550ec7d004f288a9f1543 [^]

Related to issue 35607: Mobile procurement will use next window if it existe. mainPOP is now the default window

---
M web/org.openbravo.mobile.procurement/source/pointofpurchase/mpr-popurchase-view.js
M web/org.openbravo.mobile.procurement/source/terminal/mpr-terminal.js
---
(0096363)
hgbot   
2017-05-04 09:05   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: d8c3d9672250c866a8fb29bde94c1d623a747d67
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 04 09:05:16 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/d8c3d9672250c866a8fb29bde94c1d623a747d67 [^]

Related to issue 35607: jsBeautifier

---
M web/org.openbravo.mobile.procurement/source/terminal/mpr-terminal.js
---