Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035582Retail ModulesWeb POSpublic2017-03-21 12:132017-03-31 10:11
Reporteramayavicente 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035582: [SERQA 2649] Same approval is required twice
DescriptionApproval bugs flow: If a layaway requires an aproval (for instance discretionary discount), the same approval is required at the moment of paying the ticket. Only one approval should be required.
Steps To ReproduceIn backend:
1.In preference window, create a preference with the values:
-Organization:*
-Property: Web POS Discretionary Discount Approval
-Value: N
-Visible at Client: Th White Valley Group
-Rest of the visibility fields to blank.
2.Create a new preference with the values:
-Organization:*
-Property: Web POS Discretionary Discount Approval
-Value: Y
-Visible at Client: Th White Valley Group
-Visible at User: Openbravo
-Rest of the visibility fields to blank.
3. In Discounts and Promotions window, set the promotions 'disc_5_ var_perc' and 'disc_5_ var_euro' as Approval Required=Yes.
In WebPOS:
4.Create a Layaway with a line.
5.Add a discretionary discount to the line.
6.Click the total amount button. Check that the approval pop up is raised.
7.Approve the accion and click 'Layaway' button.
8. In the menu, open the 'Layaways' option an open the layaway created previously. In the real user case, this search is done in a different terminal (for cashiers) that the creation of the layaway (sellers).
6. Click the total amount button. Check that the same approval pop up that in the step 6 is displayed.
ERROR: the same action must be approved twice.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-21 12:13amayavicenteNew Issue
2017-03-21 12:13amayavicenteAssigned To => Retail
2017-03-21 12:13amayavicenteOBNetwork customer => Yes
2017-03-21 12:13amayavicenteResolution time => 1491256800
2017-03-21 12:13amayavicenteTriggers an Emergency Pack => No
2017-03-21 12:14amayavicenteTag Attached: SER-QA
2017-03-23 13:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-03-23 13:38ranjith_qualiantech_comStatusnew => scheduled
2017-03-29 15:22hgbotCheckin
2017-03-29 15:22hgbotNote Added: 0095654
2017-03-29 15:22hgbotStatusscheduled => resolved
2017-03-29 15:22hgbotResolutionopen => fixed
2017-03-29 15:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16d2f7e18f940461a09ad7d3e30323cb43df9646 [^]
2017-03-29 15:23hgbotCheckin
2017-03-29 15:23hgbotNote Added: 0095655
2017-03-30 18:48hgbotCheckin
2017-03-30 18:48hgbotNote Added: 0095737
2017-03-30 18:49hgbotCheckin
2017-03-30 18:49hgbotNote Added: 0095739
2017-03-30 18:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16d2f7e18f940461a09ad7d3e30323cb43df9646 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250c586366b6073843b3b155950e9bc789a5e574 [^]
2017-03-31 10:11marvintmReview Assigned To => marvintm
2017-03-31 10:11marvintmStatusresolved => closed
2017-03-31 10:11marvintmFixed in Version => RR17Q2

Notes
(0095654)
hgbot   
2017-03-29 15:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 16d2f7e18f940461a09ad7d3e30323cb43df9646
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 18:52:07 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16d2f7e18f940461a09ad7d3e30323cb43df9646 [^]

Fixes issue 35582 : Approval should not be checked for layaway if it is already approved

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0095655)
hgbot   
2017-03-29 15:23   
Repository: tools/automation/pi-mobile
Changeset: 61900209b82fdb2c5774577b99ed9090fb85e9ac
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 18:52:21 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/61900209b82fdb2c5774577b99ed9090fb85e9ac [^]

Verifies issue 35582 : Added automated test 'I35582_VerifyLayawayApprovalOnReload'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35582_VerifyLayawayApprovalOnReload.java
---
(0095737)
hgbot   
2017-03-30 18:48   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a4225f8a5571fddc4d500e6f52e3a6c7e862dcfb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 22:17:39 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a4225f8a5571fddc4d500e6f52e3a6c7e862dcfb [^]

Related to issue 35582 : Discount Approval should not be checked for layaway if it is already approved

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0095739)
hgbot   
2017-03-30 18:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 250c586366b6073843b3b155950e9bc789a5e574
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 22:18:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250c586366b6073843b3b155950e9bc789a5e574 [^]

Fixes issue 35582 : Discount Approval should not be checked for layaway if it is already approved

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---