Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035560Openbravo ERP09. Financial managementpublic2017-03-17 14:012017-03-30 17:27
maite 
markmm82 
immediatemajoralways
closedfixed 
5
 
3.0PR17Q2 
aferraz
Core
Production - Confirmed Stable
2015-04-24
3.0PR15Q3
https://code.openbravo.com/erp/devel/pi/rev/1881cfa4bb9c [^]
No
0035560: "Adjustment Period" not used when posting a GL Journal
In case Adjustment Period is defined for your calendar and user tries to post gl journal document in that period it is not properly done
1. Access Fiscal Calendar "US Calendar", go to Year 2017 and create new Period named "adjustment period", starting date=ending date=31-12-2017 and type= adjustment perio"
2. Access Open/Close period control window filter by "US Calendar" and "2017" year and run "Open period" process in adjustment period
3. Register GL Journal for "F&B US East Coast" organization, Date=31-12-2017, period= adjustment period and currency=USD
4. Add header setting "F&B International Group US/A/US Dollar" general ledger and verify that adjustment period is set
5. Add line for any account and any debit amount
6. Add another line for different account and same credit amount
7. Process header and post it
8. Access "Accounting transaction details" window and verify that period set is "Dec-17" instead of "adjustment period"

Moreover, you can verify that if you unpost journal, close Dec-17 period and try to post it again you will receive "Period closed" error. So period set in GL Journal document is not being considered
No tags attached.
depends on backport 00355753.0PR17Q1.1 closed markmm82 "Adjustment Period" not used when posting a GL Journal 
depends on backport 00355763.0PR16Q4.4 closed markmm82 "Adjustment Period" not used when posting a GL Journal 
caused by defect 0028973 closed reinaldoguerra G/L Journal can be posted in a closed period. It cannot be unposted then 
Issue History
2017-03-17 14:01maiteNew Issue
2017-03-17 14:01maiteAssigned To => Triage Finance
2017-03-17 14:01maiteModules => Core
2017-03-17 14:01maiteResolution time => 1491516000
2017-03-17 14:01maiteTriggers an Emergency Pack => No
2017-03-17 14:01maiteIssue Monitored: networkb
2017-03-17 14:06maiteRelationship addedcaused by 0028973
2017-03-17 14:18eugeniIssue Monitored: eugeni
2017-03-20 00:38markmm82Assigned ToTriage Finance => luisrs8608
2017-03-20 14:59markmm82Regression level => Production - Confirmed Stable
2017-03-20 14:59markmm82Regression date => 2015-04-24
2017-03-20 14:59markmm82Regression introduced in release => 3.0PR15Q3
2017-03-20 14:59markmm82Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/1881cfa4bb9c [^]
2017-03-20 15:00markmm82Statusnew => scheduled
2017-03-20 18:55hgbotCheckin
2017-03-20 18:55hgbotNote Added: 0095441
2017-03-20 18:55hgbotStatusscheduled => resolved
2017-03-20 18:55hgbotResolutionopen => fixed
2017-03-20 18:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9812b29fd4fa27988dd0f969844044edafc5789c [^]
2017-03-20 19:06markmm82Assigned Toluisrs8608 => markmm82
2017-03-20 19:07markmm82Review Assigned To => markmm82
2017-03-20 19:07markmm82Note Added: 0095444
2017-03-20 19:07markmm82Statusresolved => closed
2017-03-20 19:07markmm82Fixed in Version => 3.0PR17Q2
2017-03-21 15:26hudsonbotCheckin
2017-03-21 15:26hudsonbotNote Added: 0095475
2017-03-30 09:23aferrazReview Assigned Tomarkmm82 => aferraz
2017-03-30 10:26aferrazNote Added: 0095690
2017-03-30 10:26aferrazStatusclosed => new
2017-03-30 10:26aferrazResolutionfixed => open
2017-03-30 10:26aferrazFixed in Version3.0PR17Q2 =>
2017-03-30 10:27hgbotCheckin
2017-03-30 10:27hgbotNote Added: 0095691
2017-03-30 11:40hgbotCheckin
2017-03-30 11:40hgbotNote Added: 0095703
2017-03-30 12:34aferrazNote Deleted: 0095444
2017-03-30 12:34aferrazStatusnew => scheduled
2017-03-30 12:34aferrazStatusscheduled => resolved
2017-03-30 12:34aferrazFixed in Version => 3.0PR17Q2
2017-03-30 12:34aferrazResolutionopen => fixed
2017-03-30 12:35aferrazNote Added: 0095705
2017-03-30 12:35aferrazStatusresolved => closed
2017-03-30 17:27hudsonbotCheckin
2017-03-30 17:27hudsonbotNote Added: 0095729
2017-03-30 17:27hudsonbotCheckin
2017-03-30 17:27hudsonbotNote Added: 0095731

Notes
(0095441)
hgbot   
2017-03-20 18:55   
Repository: erp/devel/pi
Changeset: 9812b29fd4fa27988dd0f969844044edafc5789c
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Mar 20 13:14:16 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/9812b29fd4fa27988dd0f969844044edafc5789c [^]

Fixes issue 35560: "Adjustment Period" not used when posting a GL Journal

In case Adjustment Period was defined for a calendar and user tries to post gl journal document in that period it was not properly done.

It was fixed re-structuring the affected queries using the C_PERIOD_ID column of GL_JOURNAL and C_PERIOD tables, always retrieving this value as C_PERIOD_ID instead of "period" alias

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal_data.xsql
---
(0095475)
hudsonbot   
2017-03-21 15:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d2c97fb54da7 [^]
Maturity status: Test
(0095690)
aferraz   
2017-03-30 10:26   
Reopened because it was causing issue 0028973 to be reproducible again.
(0095691)
hgbot   
2017-03-30 10:27   
Repository: erp/devel/pi
Changeset: a998052fc4257f6f143fff8ebb8ffec68dea1302
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 30 10:25:21 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a998052fc4257f6f143fff8ebb8ffec68dea1302 [^]

Related to issue 35560: Code review improvements

Backout fixes of issues 35560 & 28973 and fix issue 28973 properly:
DocGLJournal.isperiodOpen method was not correctly checking if DocGLJournalData.periodOpen retrieves no period.

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal_data.xsql
---
(0095703)
hgbot   
2017-03-30 11:40   
Repository: erp/devel/pi
Changeset: cd7a62b67c82ed7bd7f4156861f1a35ba6083b12
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 30 11:38:36 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cd7a62b67c82ed7bd7f4156861f1a35ba6083b12 [^]

Related to issue 35560: Use StringUtils.isEmpty instead of "".equals

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
---
(0095705)
aferraz   
2017-03-30 12:35   
Code review + Testing OK
(0095729)
hudsonbot   
2017-03-30 17:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fbf76c4a22c1 [^]
Maturity status: Test
(0095731)
hudsonbot   
2017-03-30 17:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fbf76c4a22c1 [^]
Maturity status: Test