Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035549Retail ModulesStoreServerpublic2017-03-17 08:462017-03-20 10:41
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035549: Cross domain checking should not use mobile servers if the multi-server preference is of
DescriptionThe cross domain checking logic uses mobile server definitions [1]. It should however not use them if the multi-server preference [2] is not set.

[1]
http://wiki.openbravo.com/wiki/How_to_Setup_MultiServer_Dev_Environment#Understanding_CORS [^]

[2]
http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences [^]
Steps To ReproduceCreate some mobile server definitions with urls
Set the multi-server preference to N
Set a breakpoint in the code here [1]
See that the code reads the mobile server definitions and uses them

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/01f7665c6772/src/org/openbravo/mobile/core/authenticate/MobileAllowedCrossDomainsChecker.java#l82 [^]
Proposed SolutionDo not read any mobile server definition records if multi-server preference is N
Additional Information
TagsNo tags attached.
Relationships
related to defect 00355483.0PR17Q2 closed mtaal Openbravo ERP Cross domain checks is also executed/logged when the origin of the webpos main page and the separate xhr request are the same 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-17 08:46mtaalNew Issue
2017-03-17 08:46mtaalAssigned To => mtaal
2017-03-17 08:46mtaalTriggers an Emergency Pack => No
2017-03-17 08:46mtaalRelationship addedrelated to 0035548
2017-03-17 10:10shuehnerResolution time => 1491516000
2017-03-17 10:14shuehnerIssue Monitored: shuehner
2017-03-19 10:29mtaalReview Assigned To => AugustoMauch
2017-03-19 10:41hgbotCheckin
2017-03-19 10:41hgbotNote Added: 0095397
2017-03-19 10:41hgbotStatusnew => resolved
2017-03-19 10:41hgbotResolutionopen => fixed
2017-03-19 10:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/98a5ddef767777bd4faebb244e9bb2b5b27299e6 [^]
2017-03-20 10:41AugustoMauchNote Added: 0095415
2017-03-20 10:41AugustoMauchStatusresolved => closed

Notes
(0095397)
hgbot   
2017-03-19 10:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 98a5ddef767777bd4faebb244e9bb2b5b27299e6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:30:02 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/98a5ddef767777bd4faebb244e9bb2b5b27299e6 [^]

Fixes issue 35549: Cross domain checking should not use mobile servers if the multi-server preference is off
Keep the internal list empty if the multi-server pref is off

---
M src/org/openbravo/mobile/core/authenticate/MobileAllowedCrossDomainsChecker.java
---
(0095415)
AugustoMauch   
2017-03-20 10:41   
Code reviewed and verified