Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035539Openbravo ERP07. Sales managementpublic2017-03-16 11:542017-03-25 01:51
ngarcia 
mcobas 
urgentmajoralways
closedfixed 
5
 
3.0PR17Q2 
aferraz
Core
No
0035539: Delivered Sales Order Report is showing the business partner only when the sales order is associated with a project
Delivered Sales Order Report is showing the business partner only when the sales order is associated with a project.

The problem is that the link between c_order and c_bpartner tables is made by the c_project table

c_order -> c_project -> c_bpartner
As group admin role:
   Create a sales order
   Create shipment from orders from it
   Launch the Delivered Sales Order Report:
      From Date: sales order date
      To Date: sales order date
   Check the Business Partner name is not shown in the Business Partner title
   Launch the report again by filtering by the sales order business partner
   Check the report is shown empty
No tags attached.
Issue History
2017-03-16 11:54ngarciaNew Issue
2017-03-16 11:54ngarciaAssigned To => Triage Finance
2017-03-16 11:54ngarciaModules => Core
2017-03-16 11:54ngarciaResolution time => 1491429600
2017-03-16 11:54ngarciaTriggers an Emergency Pack => No
2017-03-16 11:55ngarciaIssue Monitored: networkb
2017-03-16 19:36markmm82Assigned ToTriage Finance => mcobas
2017-03-20 19:27mcobasStatusnew => scheduled
2017-03-23 15:21mcobasNote Added: 0095533
2017-03-23 18:03hgbotCheckin
2017-03-23 18:03hgbotNote Added: 0095548
2017-03-23 18:03hgbotStatusscheduled => resolved
2017-03-23 18:03hgbotResolutionopen => fixed
2017-03-23 18:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/595d854767a230ff40ace21f8720c245d1e81990 [^]
2017-03-23 18:03hgbotCheckin
2017-03-23 18:03hgbotNote Added: 0095549
2017-03-23 18:04aferrazReview Assigned To => aferraz
2017-03-23 18:04aferrazNote Added: 0095550
2017-03-23 18:04aferrazStatusresolved => closed
2017-03-23 18:04aferrazFixed in Version => 3.0PR17Q2
2017-03-25 01:51hudsonbotCheckin
2017-03-25 01:51hudsonbotNote Added: 0095578
2017-03-25 01:51hudsonbotCheckin
2017-03-25 01:51hudsonbotNote Added: 0095579

Notes
(0095533)
mcobas   
2017-03-23 15:21   
Test Plan A
1. Create a sales order.
2. Create a Good Shipment using previous order.
3. Launch the Delivered Sales Order Report:
   From Date: sales order date
   To Date: sales order date
4. Notice that Business Partner name is shown in the Business Partner title.

Test Plan B
1. Create a sales order.
2. Create a Good Shipment using previous order.
3. Launch the Delivered Sales Order Report:
   From Date: sales order date
   To Date: sales order date
4. Notice that Business Partner name is shown in the Business Partner title of both Delivered.
5. Launch the report again by filtering by the sales order business partner.
6. Notice that Business Partner name is shown in the Business Partner title.
(0095548)
hgbot   
2017-03-23 18:03   
Repository: erp/devel/pi
Changeset: 595d854767a230ff40ace21f8720c245d1e81990
Author: Miguel <martencobasmiguel <at> gmail.com>
Date: Mon Mar 20 14:07:23 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/595d854767a230ff40ace21f8720c245d1e81990 [^]

Fixes issue 35539: Delivered Sales Order Report is not showing business partner

The problem is that the link between c_order and c_bpartner tables is made by
the c_project table and in cases where the sales order is not related to a
project, the relationship between c_project and c_bpartner is going to return
null, causing it to be impossible to obtain the information of the
business partner.

To solve this problem the union is established between the tables c_order
and c_bdpartner.

---
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvided_data.xsql
---
(0095549)
hgbot   
2017-03-23 18:03   
Repository: erp/devel/pi
Changeset: defaa5739e3fbb1a564bfdb310f30a8b59b0cb2f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 23 17:54:38 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/defaa5739e3fbb1a564bfdb310f30a8b59b0cb2f [^]

Related to issue 35539: Code review improvements

Join with C_BPARTNER_LOCATION table done using C_ORDER table instead of C_PROJECT table.

---
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvided_data.xsql
---
(0095550)
aferraz   
2017-03-23 18:04   
Code review + Testing OK
(0095578)
hudsonbot   
2017-03-25 01:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a169bf5db5fd [^]
Maturity status: Test
(0095579)
hudsonbot   
2017-03-25 01:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a169bf5db5fd [^]
Maturity status: Test