Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035517Retail ModulesWeb POSpublic2017-03-14 20:402017-08-08 12:34
Reporterrbianchini 
Assigned Togorka_gil 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR16Q4.2 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035517: Search filter not removed under some circumstances
DescriptionWhen you add a service to a product, and you need to use the search tab again, sometimes you have to remove manually the filter used to show the services associated to the product.
This happens at least from 16Q1
Steps To ReproduceLog in https://livebuilds.openbravo.com/retail_mp_3.0RR16Q4.2/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
- Select the product “Backpacks & Travel > Baby Carrier”
- After the Product has been included in the ticket, tap on the “services”-symbol
- Tap the service “Fit in the car”
- Tap BROWSE
- Select the product “Mountaineering > Thermal t-shirt”
- Note that the SEARCH window, which now should show the variants for the selected product, still has the filters corresponding to the last product and that you have to manually reset the filter for the variants to show up.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff fixes_issue_35517_hg_export.diff (1,097) 2017-06-29 11:27
https://issues.openbravo.com/file_download.php?file_id=10878&type=bug
diff test_for_issue_35517_hg_export.diff (14,938) 2017-06-30 12:00
https://issues.openbravo.com/file_download.php?file_id=10881&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-14 20:40rbianchiniNew Issue
2017-03-14 20:40rbianchiniAssigned To => Retail
2017-03-14 20:40rbianchiniTriggers an Emergency Pack => No
2017-03-15 10:26pcg_elopezNote Added: 0095021
2017-03-15 11:27gorka_gilAssigned ToRetail => gorka_gil
2017-03-15 11:28egoitzIssue Monitored: egoitz
2017-03-30 12:55gorka_gilStatusnew => scheduled
2017-06-29 11:27gorka_gilFile Added: fixes_issue_35517_hg_export.diff
2017-06-29 11:27gorka_gilFile Added: test_for_issue_35517_hg_export.diff
2017-06-30 12:00gorka_gilFile Deleted: test_for_issue_35517_hg_export.diff
2017-06-30 12:00gorka_gilFile Added: test_for_issue_35517_hg_export.diff
2017-07-19 11:42hgbotCheckin
2017-07-19 11:42hgbotNote Added: 0098128
2017-07-19 11:43hgbotCheckin
2017-07-19 11:43hgbotNote Added: 0098129
2017-07-19 11:43hgbotStatusscheduled => resolved
2017-07-19 11:43hgbotResolutionopen => fixed
2017-07-19 11:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/43c68e1461809625dff7670bb1dbb0dd39ecbbad [^]
2017-08-08 12:34marvintmReview Assigned To => marvintm
2017-08-08 12:34marvintmStatusresolved => closed
2017-08-08 12:34marvintmFixed in Version => RR17Q4

Notes
(0095021)
pcg_elopez   
2017-03-15 10:26   
We were able to solve the issue by adding the following line to "toolbar-right.js":

[...]
tabPanel: 'catalog',
  i18nLabel: 'OBMOBC_LblBrowse',
  tap: function () {
    OB.UI.SearchProductCharacteristic.prototype.filtersCustomClear(); <-------
    if (!this.disabled) {
    [...]
(0098128)
hgbot   
2017-07-19 11:42   
Repository: tools/automation/pi-mobile
Changeset: 1598d38b2ff6b21269748f3a66dd6e0c72a1cbad
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Jun 30 11:59:28 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1598d38b2ff6b21269748f3a66dd6e0c72a1cbad [^]

Related to issue 35517: Search filter not removed under some circumstances

Added test cases for:

pack:
  product with service button -> product generic
  product with service button -> product with service button
  product with service button -> product with service mandatory proposal
  product generic -> product with service mandatory proposal
  product generic -> product with service button
  product generic -> product generic (NOT IMPLEMENTED)
  --- NOT done because there is no 2 generic products in sampledata nor in test sampledata
  product with service mandatory proposal -> product with service mandatory proposal
  product with service mandatory proposal -> product with service button
  product with service mandatory proposal -> product generic

ext-modules:
  complementary -> product with service mandatory proposal
  product with service mandatory proposal -> complementary
  complementary -> complementary

Note: tests implemented to work in remote and local, but since generic only works in local
these tests are skipped in remote

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/complementaryproducts/I35517_CustomSearchFilterNoReset_complementary.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I35517_CustomSearchFilterNoReset.java
---
(0098129)
hgbot   
2017-07-19 11:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 43c68e1461809625dff7670bb1dbb0dd39ecbbad
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Jun 27 19:27:03 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/43c68e1461809625dff7670bb1dbb0dd39ecbbad [^]

Fixes issue 35517: Search filter not removed under some circumstances

Ensure custom filters are cleared always before a new filter

Especifically fixed the generic case, since the rest were working fine
Note: that in remote generic is disabled

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js
---