Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035490Openbravo ERPA. Platformpublic2017-03-12 13:132017-03-15 20:22
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035490: SystemService logValidationResults logs a ERROR line always if there are no errors (shows in export.database)
DescriptionThe 'Validating module' part of export.database calls to SystemService in erp sourcecode to do the validation + to log the result.

That logValidationResult method assembles a StringBuffer and logs it using log4j.error.

However if does not check if that String does contain anything so logs an 'empty' error all the time.

Note that this is minor for the moment as export.database does have bad log4j config so it does not show the log-level prefix at the moment. Fixing that manually show the problem clearly like this:

24623 [main] INFO org.openbravo.ddlutils.task.ExportDatabase - Validating Module...
25022 [main] ERROR org.openbravo.ddlutils.task.ExportDatabase -
Steps To ReproduceRun export.database with any module in development and notice the extra empty line on Validating module.
With the debugging patch attached to this issue it will show the wrong log level clearly.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035493 closed alostale missing log info when check consistency fails 
Attached Filesdiff 35490_fix.diff (445) 2017-03-12 13:14
https://issues.openbravo.com/file_download.php?file_id=10555&type=bug
diff debugging-do-not-commit-fix-log4j.diff (941) 2017-03-12 13:15
https://issues.openbravo.com/file_download.php?file_id=10556&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-12 13:13shuehnerNew Issue
2017-03-12 13:13shuehnerAssigned To => platform
2017-03-12 13:13shuehnerModules => Core
2017-03-12 13:13shuehnerTriggers an Emergency Pack => No
2017-03-12 13:14shuehnerFile Added: 35490_fix.diff
2017-03-12 13:15shuehnerFile Added: debugging-do-not-commit-fix-log4j.diff
2017-03-12 13:15shuehnerNote Added: 0094956
2017-03-13 07:49alostaleAssigned Toplatform => shuehner
2017-03-13 07:49hgbotCheckin
2017-03-13 07:49hgbotNote Added: 0094968
2017-03-13 07:49hgbotStatusnew => resolved
2017-03-13 07:49hgbotResolutionopen => fixed
2017-03-13 07:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0dd550bbbef217729547c193505710672401aa65 [^]
2017-03-13 07:51alostaleReview Assigned To => alostale
2017-03-13 07:51alostaleNote Added: 0094969
2017-03-13 07:51alostaleStatusresolved => closed
2017-03-13 07:51alostaleFixed in Version => 3.0PR17Q2
2017-03-13 09:17alostaleRelationship addedrelated to 0035493
2017-03-15 20:22hudsonbotCheckin
2017-03-15 20:22hudsonbotNote Added: 0095293

Notes
(0094956)
shuehner   
2017-03-12 13:15   
Note: the debugging patch is for dbsm repo so to use it need to recompile dbsm and use that jar
(0094968)
hgbot   
2017-03-13 07:49   
Repository: erp/devel/pi
Changeset: 0dd550bbbef217729547c193505710672401aa65
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Mar 13 07:48:48 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0dd550bbbef217729547c193505710672401aa65 [^]

fixed bug 35490: SystemService logs a ERROR line always

---
M src/org/openbravo/service/system/SystemService.java
---
(0094969)
alostale   
2017-03-13 07:51   
reviewed
(0095293)
hudsonbot   
2017-03-15 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test