Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035482 | Retail Modules | StoreServer | public | 2017-03-10 14:23 | 2017-03-27 09:51 |
|
| Reporter | mtaal | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RR17Q2 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035482: MobileMainServerCheck should also use last ping approach |
| Description | The MobileMainServerCheck [1] class starts pinging the central server when it is offline. This can overflow the central server when it gets back online (all store servers ping it then). Therefore the idea is to let the MobileMainServerCheck also use the lastping approach. It continuously checks if a last ping was received from the main server.
Also the MobileServerStatusInformation [2] should have some code to check that it is only called on the store server, so it should not be called/executed on the central server, it should be called from the central server.
[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/9df8c77e1fd8/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java [^]
[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/9df8c77e1fd8/src/org/openbravo/mobile/core/servercontroller/MobileServerStatusInformation.java#l37 [^] |
| Steps To Reproduce | See description |
| Proposed Solution | Use last ping approach also in case of mobile main server check
Add log/warn statement if mobile server status webservice is called on the central server |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0035113 | | closed | mtaal | The ServerStateBackground server ping unregistered servers |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-03-10 14:23 | mtaal | New Issue | |
| 2017-03-10 14:23 | mtaal | Assigned To | => mtaal |
| 2017-03-10 14:23 | mtaal | OBNetwork customer | => No |
| 2017-03-10 14:23 | mtaal | Triggers an Emergency Pack | => No |
| 2017-03-10 14:23 | mtaal | Relationship added | related to 0035113 |
| 2017-03-10 14:24 | mtaal | Relationship deleted | related to 0035113 |
| 2017-03-10 14:29 | mtaal | Summary | Add check/log in MobileServerStatusInformation so that it is only called by central on store => MobileMainServerCheck should also use last ping approach |
| 2017-03-10 14:29 | mtaal | Description Updated | bug_revision_view_page.php?rev_id=14769#r14769 |
| 2017-03-10 14:29 | mtaal | Proposed Solution updated | |
| 2017-03-10 14:29 | mtaal | Relationship added | related to 0035113 |
| 2017-03-13 10:49 | AugustoMauch | Assigned To | mtaal => AugustoMauch |
| 2017-03-15 13:16 | hgbot | Checkin | |
| 2017-03-15 13:16 | hgbot | Note Added: 0095030 | |
| 2017-03-15 13:16 | hgbot | Status | new => resolved |
| 2017-03-15 13:16 | hgbot | Resolution | open => fixed |
| 2017-03-15 13:16 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/388cb7e16a014ee77632ca4aaea27cea1b657909 [^] |
| 2017-03-15 13:17 | AugustoMauch | Review Assigned To | => mtaal |
| 2017-03-19 10:25 | mtaal | Note Added: 0095391 | |
| 2017-03-19 10:35 | mtaal | Review Assigned To | mtaal => AugustoMauch |
| 2017-03-19 10:41 | hgbot | Checkin | |
| 2017-03-19 10:41 | hgbot | Note Added: 0095395 | |
| 2017-03-19 10:41 | hgbot | Checkin | |
| 2017-03-19 10:41 | hgbot | Note Added: 0095398 | |
| 2017-03-19 10:41 | hgbot | Checkin | |
| 2017-03-19 10:41 | hgbot | Note Added: 0095399 | |
| 2017-03-27 09:51 | AugustoMauch | Note Added: 0095583 | |
| 2017-03-27 09:51 | AugustoMauch | Status | resolved => closed |
|
Notes |
|
|
(0095030)
|
|
hgbot
|
|
2017-03-15 13:16
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 388cb7e16a014ee77632ca4aaea27cea1b657909
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 15 13:13:19 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/388cb7e16a014ee77632ca4aaea27cea1b657909 [^]
Fixes issue 35482: Refactors, improves performance of MobileMainServerCheck
The following changes have been made to MobileMainServerCheck:
- Store servers no longer ping the central server. They just check when was the last time the central server pinged them to determine if the central server is offline.
- Once a store server is determined to be offline, the MobileMainServerCheck is terminated.
Some methods from ServerStateBackground have been made static and public to be reused from MobileMainServerCheck.
---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
|
|
|
|
(0095391)
|
|
mtaal
|
|
2017-03-19 10:25
|
|
|
Reviewed, will do additional commits, will be reviewed by original committer |
|
|
|
(0095395)
|
|
hgbot
|
|
2017-03-19 10:41
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 47961a4afa40e5a26774bfa89a39234f2a1cd67f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:27:07 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/47961a4afa40e5a26774bfa89a39234f2a1cd67f [^]
Related to issue 35482: MobileMainServerCheck should also use last ping approach
Make sure that the transition to offline logic is started (and if not restart it) in case of transitioning to offline.
Do the correct check against the value of the enum, instead of the enum itself and also use the correct OFFLINE enum
---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
|
|
|
|
(0095398)
|
|
hgbot
|
|
2017-03-19 10:41
|
|
|
|
|
(0095399)
|
|
hgbot
|
|
2017-03-19 10:41
|
|
|
|
|
|
|
Code reviewed and verified |
|