Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035467Openbravo ERPA. Platformpublic2017-03-09 12:532017-03-09 14:16
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionCentOS 6.4
Product Version3.0PR14Q3.5 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browserGoogle Chrome, Mozilla Firefox
ModulesOpenbravo 3.0 Framework
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035467: Wrong export of a view
DescriptionOpenbravo exports bad a view (with ant export.database), what causes rebuild error. I created a SRCT_INVOICE_DDPPRL (view in the attached file)
Steps To ReproduceCreate view (in the example without some columns no-standard)in the database (and Openbravo Application Dictionary) and export it, try reinstall the module.
Proposed SolutionI changed xml file content and it works, but I think it will generate error in the future in the ant export.database with the module.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035341 closed mcobas Wrong orders shown in "Create Invoices From Orders" window 
related to design defect 0029492 closed alostale Wrong export of a view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-09 12:53alostaleNew Issue
2017-03-09 12:53alostaleAssigned To => alostale
2017-03-09 12:53alostaleWeb browser => Google Chrome, Mozilla Firefox
2017-03-09 12:53alostaleModules => Openbravo 3.0 Framework
2017-03-09 12:53alostaleTriggers an Emergency Pack => No
2017-03-09 12:53alostaleIssue generated from0029492
2017-03-09 12:53alostaleRelationship addedrelated to 0035341
2017-03-09 12:53alostaleWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2017-03-09 12:53alostaleTarget Version => 3.0PR17Q1
2017-03-09 12:54alostaleRelationship addedrelated to 0029492
2017-03-09 13:11hgbotCheckin
2017-03-09 13:11hgbotNote Added: 0094874
2017-03-09 13:11hgbotCheckin
2017-03-09 13:11hgbotNote Added: 0094875
2017-03-09 13:11hgbotStatusnew => resolved
2017-03-09 13:11hgbotResolutionopen => fixed
2017-03-09 13:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/a87f1ae218605558ca84411c1cd63ab19a4744cd [^]
2017-03-09 13:11hgbotCheckin
2017-03-09 13:11hgbotNote Added: 0094876
2017-03-09 13:12alostaleReview Assigned To => caristu
2017-03-09 13:12alostaleWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2017-03-09 14:16caristuNote Added: 0094879
2017-03-09 14:16caristuStatusresolved => closed
2017-03-09 14:16caristuFixed in Version => 3.0PR17Q1
2017-03-10 13:47alostaleRelationship addedrelated to 0035474
2017-03-10 13:50alostaleRelationship deletedrelated to 0035474

Notes
(0094874)
hgbot   
2017-03-09 13:11   
Repository: erp/devel/dbsm-main
Changeset: dc1d0235612a8bf06506ffe110b25723ef3b07e9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 09 08:56:11 2017 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/dc1d0235612a8bf06506ffe110b25723ef3b07e9 [^]

related to bug 35467: added test cases

  Added failing (before fix 29492) test cases: views with more than one IN or
  NOT IN clauses are not correctly converted in PG.

---
M src-test/src/org/openbravo/dbsm/test/model/Views.java
A src-test/model/views/IN_VIEW.xml
A src-test/model/views/NOT_IN_VIEW.xml
---
(0094875)
hgbot   
2017-03-09 13:11   
Repository: erp/backports/3.0PR17Q1
Changeset: a87f1ae218605558ca84411c1cd63ab19a4744cd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 09 13:08:47 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/a87f1ae218605558ca84411c1cd63ab19a4744cd [^]

fixed bug 35467: views with several IN or NOT IN clasues fail in PG

  In PG, views that contain more than one IN or NOT IN clauses were not correctly
  exported.

  The regexps that parses and PG IN and NOT IN clauses was including from the begining
  of 1st clause till the end of the last one.

  These regexps have been fixed to be more restrictive so that they stop looking
  for the IN contents on first ].

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094876)
hgbot   
2017-03-09 13:11   
Repository: erp/backports/3.0PR17Q1
Changeset: a87f1ae218605558ca84411c1cd63ab19a4744cd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 09 13:08:47 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/a87f1ae218605558ca84411c1cd63ab19a4744cd [^]

fixed bug 35467: views with several IN or NOT IN clasues fail in PG

  In PG, views that contain more than one IN or NOT IN clauses were not correctly
  exported.

  The regexps that parses and PG IN and NOT IN clauses was including from the begining
  of 1st clause till the end of the last one.

  These regexps have been fixed to be more restrictive so that they stop looking
  for the IN contents on first ].

---
M src-db/database/lib/dbsourcemanager.jar
---
(0094879)
caristu   
2017-03-09 14:16   
Code reviewed + tested OK.