Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035444Retail ModulesWeb POSpublic2017-03-07 12:482017-03-24 12:30
Reporterguillermogil 
Assigned Tomigueldejuana 
PriorityhighSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035444: DeleteLine logic is duplicated across several functionalities
DescriptionDeleteLine logic is duplicated across several functionalities.
Hooks, approvals and common functionality should be inside of a common function.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0035443 closed migueldejuana OBPOS_PreDeleteLine Hook cannot be cancelled 
Attached Files? issue35444.commit (18,154) 2017-03-16 11:30
https://issues.openbravo.com/file_download.php?file_id=10576&type=bug
diff issue35444_16Q4.diff (15,860) 2017-03-20 16:49
https://issues.openbravo.com/file_download.php?file_id=10585&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-07 12:48guillermogilNew Issue
2017-03-07 12:48guillermogilAssigned To => Retail
2017-03-07 12:48guillermogilResolution time => 1490652000
2017-03-07 12:48guillermogilTriggers an Emergency Pack => No
2017-03-07 12:49guillermogilRelationship addedblocks 0035443
2017-03-08 10:15migueldejuanaAssigned ToRetail => migueldejuana
2017-03-08 10:15migueldejuanaStatusnew => scheduled
2017-03-16 11:30migueldejuanaFile Added: issue35444.commit
2017-03-16 13:31hgbotCheckin
2017-03-16 13:31hgbotNote Added: 0095319
2017-03-16 13:31hgbotStatusscheduled => resolved
2017-03-16 13:31hgbotResolutionopen => fixed
2017-03-16 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5f4e5e866a4e98fe96689bb0337b1c8d18c658a [^]
2017-03-20 16:49migueldejuanaFile Added: issue35444_16Q4.diff
2017-03-24 12:30marvintmReview Assigned To => marvintm
2017-03-24 12:30marvintmStatusresolved => closed
2017-03-24 12:30marvintmFixed in Version => RR17Q2

Notes
(0095319)
hgbot   
2017-03-16 13:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c5f4e5e866a4e98fe96689bb0337b1c8d18c658a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 14 08:35:49 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5f4e5e866a4e98fe96689bb0337b1c8d18c658a [^]

Fixed issue 0035444: DeleteLine logic is duplicated across several functionalities

- Remove unneeded hook file
- Gather delete line logic in pointofsale.js

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
R web/org.openbravo.retail.posterminal/js/components/hookPreDeleteLine.js
---