Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035442 | Openbravo ERP | 09. Financial management | public | 2017-03-07 12:13 | 2017-03-15 20:21 |
|
| Reporter | shuehner | |
| Assigned To | vmromanos | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | shuehner |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035442: junit test CancelAndReplace is missing to set IsSOTRX value which can cause failure with custom event observers |
| Description | This junit test does not set the issotrx value explicitely in the testing data it creates.
This can create problems when running the junit test with custom DAL event observers checking that table.
Setting that value explicitely makes the test more robust to not fail in that scenario. |
| Steps To Reproduce | https://ci.openbravo.com/job/mod-simple/11028/testReport/junit/org.openbravo.test.cancelandreplace/CancelAndReplaceTest/CancelAndReplaceTests/ [^]
Showing up for example in custom mod-but-qa-multiserver modules testing job.
|
| Proposed Solution | - |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-03-07 12:13 | shuehner | New Issue | |
| 2017-03-07 12:13 | shuehner | Assigned To | => vmromanos |
| 2017-03-07 12:13 | shuehner | OBNetwork customer | => No |
| 2017-03-07 12:13 | shuehner | Modules | => Core |
| 2017-03-07 12:13 | shuehner | Triggers an Emergency Pack | => No |
| 2017-03-07 12:28 | vmromanos | Status | new => scheduled |
| 2017-03-07 12:29 | vmromanos | Note Added: 0094786 | |
| 2017-03-07 12:37 | hgbot | Checkin | |
| 2017-03-07 12:37 | hgbot | Note Added: 0094787 | |
| 2017-03-07 12:37 | hgbot | Status | scheduled => resolved |
| 2017-03-07 12:37 | hgbot | Resolution | open => fixed |
| 2017-03-07 12:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ee35e34cd34b7cbb4bd7460afc288e4366fefcdc [^] |
| 2017-03-07 12:38 | vmromanos | Review Assigned To | => shuehner |
| 2017-03-09 10:37 | shuehner | Note Added: 0094861 | |
| 2017-03-09 10:37 | shuehner | Status | resolved => closed |
| 2017-03-15 20:21 | hudsonbot | Checkin | |
| 2017-03-15 20:21 | hudsonbot | Note Added: 0095274 | |
|
Notes |
|
|
|
Test plan:
Run CancelAndReplaceTest in custom mod-but-qa-multiserver modules testing job.
Verify it successfully passes the test. |
|
|
|
(0094787)
|
|
hgbot
|
|
2017-03-07 12:37
|
|
Repository: erp/devel/pi
Changeset: ee35e34cd34b7cbb4bd7460afc288e4366fefcdc
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 12:36:31 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ee35e34cd34b7cbb4bd7460afc288e4366fefcdc [^]
Fixed bug 35442: Explicity set isSOTRX in netting shipments
The netting shipments were created without explicity setting the isSOTRX information. If not set, the database automatically sets it to Y.
However when an EntityEventObserver is executed, this value is null and could raise a NPE.
Solution sets the isSOTRX value exactly the same as the order from which it was created. Right now it will be always Y, but done this way to reuse this method in purchase flows if necessary.
---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
|
|
|
|
|
Tested the change in the environment in which the CancelAndReplaceTests junit test before triggered a NullPointerException before in some custom EventObserver.
That error does no longer happen and the tests run sucessfully there.
Talking to assignee about change being in src/ and not just src-test he confirmed that they did already check & review that the change does not break anything else.
Thus closing with both parts being done. |
|
|
|
|
|