Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035441Retail ModulesWeb POSpublic2017-03-07 10:082017-03-30 18:48
Reporteradrianromero 
Assigned Toasiermartirena 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035441: [SER-QA 2526] The giftcard info dialog that appears from the menu must not show the refund button
DescriptionWhen displaying the giftcard information dialog from the menu, the cashier is just querying information, so no action must be displayed in the dialog. The "Refund" button must be hidden.
Steps To ReproduceJust show a giftcard information dialog from the menu
Proposed SolutionApply the attached patch.
Additional Information
TagsSER-QA
Relationships
Attached Filesdiff Issue35441.diff (1,667) 2017-03-07 10:11
https://issues.openbravo.com/file_download.php?file_id=10538&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-07 10:08adrianromeroNew Issue
2017-03-07 10:08adrianromeroAssigned To => Retail
2017-03-07 10:08adrianromeroRegression date => 2017-03-21
2017-03-07 10:08adrianromeroTriggers an Emergency Pack => No
2017-03-07 10:09adrianromeroTag Attached: SER-QA
2017-03-07 10:11adrianromeroFile Added: Issue35441.diff
2017-03-13 12:20hgbotCheckin
2017-03-13 12:20hgbotNote Added: 0094979
2017-03-13 12:20hgbotStatusnew => resolved
2017-03-13 12:20hgbotResolutionopen => fixed
2017-03-13 12:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d [^]
2017-03-13 12:24jorge-garciaAssigned ToRetail => jorge-garcia
2017-03-13 13:33maiteResolution time => 1490050800
2017-03-13 13:33maiteRegression date2017-03-21 =>
2017-03-14 09:34hgbotCheckin
2017-03-14 09:34hgbotNote Added: 0094995
2017-03-16 16:54hgbotCheckin
2017-03-16 16:54hgbotNote Added: 0095339
2017-03-16 16:55marvintmAssigned Tojorge-garcia => asiermartirena
2017-03-16 16:55marvintmNote Added: 0095340
2017-03-16 16:55marvintmStatusresolved => new
2017-03-16 16:55marvintmResolutionfixed => open
2017-03-16 16:55marvintmResolution time1490050800 =>
2017-03-16 16:55marvintmTypedefect => feature request
2017-03-21 13:01adrianromeroSummary[SER-QA 2468] The giftcard info dialog that appears from the menu must not show the refund button => [SER-QA 2526] The giftcard info dialog that appears from the menu must not show the refund button
2017-03-22 13:57asiermartirenaNote Added: 0095503
2017-03-22 13:57asiermartirenaNote Edited: 0095503bug_revision_view_page.php?bugnote_id=0095503#r14866
2017-03-22 17:52hgbotCheckin
2017-03-22 17:52hgbotNote Added: 0095512
2017-03-22 19:09hgbotCheckin
2017-03-22 19:09hgbotNote Added: 0095518
2017-03-23 17:18hgbotCheckin
2017-03-23 17:18hgbotNote Added: 0095540
2017-03-23 17:18asiermartirenaStatusnew => scheduled
2017-03-27 12:09asiermartirenaStatusscheduled => resolved
2017-03-30 18:48marvintmReview Assigned To => marvintm
2017-03-30 18:48marvintmStatusresolved => closed
2017-03-30 18:48marvintmFixed in Version => RR17Q2

Notes
(0094979)
hgbot   
2017-03-13 12:20   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Mar 13 11:04:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d [^]

Fixed issue 35441: [SER-QA 2468] The giftcard info dialog that appears from
the menu must not show the refund button

Return button must be hidden if the popup is a searchAction popup.

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0094995)
hgbot   
2017-03-14 09:34   
Repository: tools/automation/pi-mobile
Changeset: b1261c8c8ffa9f963b3f68381027a59d374f5bb6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Mar 13 12:17:27 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b1261c8c8ffa9f963b3f68381027a59d374f5bb6 [^]

Verifies issue 35441: [SER-QA 2468] The giftcard info dialog that appears from
the menu must not show the refund button

Added test I35441_HideReturnButtonInGiftCardInformation.

Added new TestId for ExtModules.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I35441_HideReturnButtonInGiftCardInformation.java
---
(0095339)
hgbot   
2017-03-16 16:54   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: ec0f9050aec0d63cbc80ef61a9b80b3210d01a8a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 16 16:54:18 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/ec0f9050aec0d63cbc80ef61a9b80b3210d01a8a [^]

Related to issue 35441. The fix as it is designed is not correct, because it completely removed the functionality, instead of making it configurable.

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0095340)
marvintm   
2017-03-16 16:55   
The fix is not correct. It's not right to simply remove a useful functionality. Instead, it should be changed so that it's possible to configure if it's available for the user or not.
(0095503)
asiermartirena   
2017-03-22 13:57   
Yes, that's the reason why the change have been back outed. I've already talked to Antonio and agreed to make it configurable by a preference. I'll implement it as soon as possible.
(0095512)
hgbot   
2017-03-22 17:52   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1ad41f8683443cffacb9030723686ea99ca54244
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed Mar 22 17:51:49 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1ad41f8683443cffacb9030723686ea99ca54244 [^]

Related to issue 35441: The giftcard info dialog that appears from the menu may not show the refund button

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0095518)
hgbot   
2017-03-22 19:09   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: c3aef7f4469f7448a1136041658bf1887ed04c7a
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed Mar 22 19:04:46 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c3aef7f4469f7448a1136041658bf1887ed04c7a [^]

Related to issue 35441: Backed out changeset 1ad41f868344 (try errors)

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0095540)
hgbot   
2017-03-23 17:18   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 4ab23e38c08717d1ffa8b27b8948fa58e7f91975
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Thu Mar 23 16:52:58 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/4ab23e38c08717d1ffa8b27b8948fa58e7f91975 [^]

Related to issue 35441: Backed out changeset c3aef7f4469f

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---