Openbravo Issue Tracking System - Retail Modules
View Issue Details
0035439Retail ModulesReturn Receiptpublic2017-03-06 16:332017-05-09 08:57
lorenzofidalgo 
rqueralta 
normalminoralways
closedfixed 
5
pi 
RR17Q3 
marvintm
No
0035439: "Not enough cash" message is shown and Tick button is disabled using Gift Card to return a receipt with no cash involved
It is being checked if there is enough cash to return a receipt when it is being used Gift Card payment method to return the receipt. Because of that checking, it is shown "There is not enough cash available." and OK (tick) button is disabled. Those checks are unnecessary and wrong.
0-With "Gift Cards and Vouchers" module installed and at at least a Gift Card created correctly login Web POS as vallblanca.
1-Complete a Cashup keeping nothing in all steps.
2-Add 1x "Adhesive body warmers" to the receipt.
3-Mark this receipt as "To be Returned" through dropdown menu.
4-Click Total Amount button and use the previously created Gift Card as Payment Method to return this receipt. (Click Gift Card button, then OK button and select the previously created Gift Card).
5-DEFECT: Realise it is not avaliable to click in OK button (tick) and it is shown "There is not enough cash available" even when cash is not required.
No tags attached.
png NotEnoughCashAvailableGC.png (138,752) 2017-03-06 16:33
https://issues.openbravo.com/file_download.php?file_id=10537&type=bug
png
Issue History
2017-03-06 16:33lorenzofidalgoNew Issue
2017-03-06 16:33lorenzofidalgoAssigned To => Retail
2017-03-06 16:33lorenzofidalgoFile Added: NotEnoughCashAvailableGC.png
2017-03-06 16:33lorenzofidalgoTriggers an Emergency Pack => No
2017-03-29 23:07rqueraltaAssigned ToRetail => rqueralta
2017-03-29 23:08rqueraltaStatusnew => scheduled
2017-04-17 16:15hgbotCheckin
2017-04-17 16:15hgbotNote Added: 0096043
2017-04-17 16:15hgbotStatusscheduled => resolved
2017-04-17 16:15hgbotResolutionopen => fixed
2017-04-17 16:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/a3b2b4830ed9b131b6ca5f4b53c2de06004e1940 [^]
2017-04-18 17:21hgbotCheckin
2017-04-18 17:21hgbotNote Added: 0096054
2017-04-20 18:26asiermartirenaNote Added: 0096095
2017-04-20 18:35asiermartirenaNote Edited: 0096095bug_revision_view_page.php?bugnote_id=0096095#r15040
2017-04-24 06:53hgbotCheckin
2017-04-24 06:53hgbotNote Added: 0096107
2017-04-28 11:22hgbotCheckin
2017-04-28 11:22hgbotNote Added: 0096256
2017-04-28 11:43hgbotCheckin
2017-04-28 11:43hgbotNote Added: 0096257
2017-05-09 08:57marvintmReview Assigned To => marvintm
2017-05-09 08:57marvintmStatusresolved => closed
2017-05-09 08:57marvintmFixed in Version => RR17Q3

Notes
(0096043)
hgbot   
2017-04-17 16:15   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: a3b2b4830ed9b131b6ca5f4b53c2de06004e1940
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Apr 11 15:17:48 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/a3b2b4830ed9b131b6ca5f4b53c2de06004e1940 [^]

Fixed issue 35439: "Not enough cash" message is shown and Tick button is
disabled using Gift Card to return a receipt with no cash involved

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardPaymentAmount.js
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
---
(0096054)
hgbot   
2017-04-18 17:21   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: c7edbf371033382c60b84276212e570e7aff10b8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 18 17:20:44 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c7edbf371033382c60b84276212e570e7aff10b8 [^]

Related to issue 35439: "Not enough cash" message is shown and Tick button is
disabled using Gift Card to return a receipt with no cash involved

Fix JSlint error from integration.

---
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
---
(0096095)
asiermartirena   
2017-04-20 18:26   
(edited on: 2017-04-20 18:35)
After these changes both Gift Certificates and Product Gift Cards flows are broken. This changes have not been detected on try because the Gift Cards and Credit notes are still in the quarantine.
We will fix these problems and push to this issue after we verify that all tests are correctly executed.

We are working to correct all tests to get them out of the quarantine.

(0096107)
hgbot   
2017-04-24 06:53   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1296a637d8cbe6bf6ccf3c1b2869dcc38bf7280d
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Apr 21 18:39:39 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1296a637d8cbe6bf6ccf3c1b2869dcc38bf7280d [^]

Related to issue 35439: Fixed Gift Certificates and Product Gift Cards broken flow

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
R web/org.openbravo.retail.giftcards/js/components/GiftCardPaymentAmount.js
R web/org.openbravo.retail.giftcards/js/hooks/PreAddPaymentButtonHook.js
---
(0096256)
hgbot   
2017-04-28 11:22   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: d864338390c479906f46bb7265e21920862ec114
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Apr 28 11:21:33 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/d864338390c479906f46bb7265e21920862ec114 [^]

Related to issue 35439: Separated Product Gift Card and Gift Certificate buttons.

In Web POS, now, product gift cards and gift certificates have now different buttons.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
A web/org.openbravo.retail.giftcards/js/components/GiftCardPaymentAmount.js
---
(0096257)
hgbot   
2017-04-28 11:43   
Repository: tools/automation/pi-mobile
Changeset: 3d28ee351ff90c695d1229d90a15b6aed7198ac3
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Apr 28 11:43:23 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3d28ee351ff90c695d1229d90a15b6aed7198ac3 [^]

Related to issue 35439: Modified tests to work with two buttons

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I30841_ReturnLineButtonNotClickeable.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I31651_VerfiyGiftCardReturnTransaction.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I31718_CheckGiftCardPaymentWithCustomPayment.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32804_GiftCardValidateReturnLine.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32981_VerifyGiftCardLineSelection.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I34251_VerifyGiftCardEditPrice.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayOpenTicketsWithGiftCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayTicketWithGiftCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayTicketWithTwoGiftCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayWithGiftCardOneTimeUse.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReversePaymentsWithGiftCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/TryToPayMoreThanCardBalance.java
---