Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035434Openbravo ERP09. Financial managementpublic2017-03-06 12:192017-03-20 15:11
Reporteraferraz 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR17Q2Fixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2017-03-03
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/86dcf5d294d9 [^]
Triggers an Emergency PackNo
Summary0035434: Manual taxes deleted when reactivating a price including taxes invoice
DescriptionManual taxes deleted when reactivating a price including taxes invoice
Steps To ReproduceAs QA Admin role:
- Create a Sales Invoice with Price Including Taxes Sales price list.
- Add a line with any tax.
- Add a manual tax in Tax tab.
- Complete the invoice and check there are two records in Tax tab.
- Reactivate the invoice and check the manual created tax (Recalculate = N) in Tax tab has been removed.

The following flow is also failing:

As QA Admin role:
- Create a Sales Invoice with Price Including Taxes Sales price list.
- Add a manual tax in Tax tab with TaxAmt<>0 and TaxBaseAmt<>0.
- Add a line with a different tax than manual tax.
- Check Total Net Amount is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by design defect 0032265 closed aferraz [SER QA 1434] Taxes at document level are not properly calculated in some cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-06 12:19aferrazNew Issue
2017-03-06 12:19aferrazAssigned To => aferraz
2017-03-06 12:19aferrazModules => Core
2017-03-06 12:19aferrazRegression introduced in release => pi
2017-03-06 12:19aferrazTriggers an Emergency Pack => No
2017-03-06 12:19aferrazRelationship addedcaused by 0032265
2017-03-06 12:31aferrazRegression level => Pre packaging ( pi )
2017-03-06 12:31aferrazRegression date => 2017-03-03
2017-03-06 12:31aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/86dcf5d294d9 [^]
2017-03-06 13:25aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14726#r14726
2017-03-06 13:57hgbotCheckin
2017-03-06 13:57hgbotNote Added: 0094767
2017-03-06 13:57hgbotStatusnew => resolved
2017-03-06 13:57hgbotResolutionopen => fixed
2017-03-06 13:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b0e68131dd0747e6b671f418be02daac8512c80c [^]
2017-03-15 20:21hudsonbotCheckin
2017-03-15 20:21hudsonbotNote Added: 0095273
2017-03-20 15:11vmromanosReview Assigned To => vmromanos
2017-03-20 15:11vmromanosNote Added: 0095428
2017-03-20 15:11vmromanosStatusresolved => closed
2017-03-20 15:11vmromanosFixed in Version => 3.0PR17Q2

Notes
(0094767)
hgbot   
2017-03-06 13:57   
Repository: erp/devel/pi
Changeset: b0e68131dd0747e6b671f418be02daac8512c80c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Mar 06 13:56:27 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b0e68131dd0747e6b671f418be02daac8512c80c [^]

Fixes issue 35434: Manual taxes deleted when reactivating a PIT invoice

Now when reactivating a price including taxes invoice, manual taxes will not be deleted, and invoice gross amount will be updated to the sum of tax amounts of the manual taxes instead of zero.
Also, when calculating invoice gross and net amounts in invoice line trigger, manual taxes will be taken into account when getting the sum of tax amounts but not for getting the sum of tax base amounts.

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0095273)
hudsonbot   
2017-03-15 20:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095428)
vmromanos   
2017-03-20 15:11   
Code review OK