Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035433Openbravo ERP09. Financial managementpublic2017-03-06 11:312017-05-29 17:43
Reportervmromanos 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q3Fixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2017-02-23
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/251ea8a24d39 [^]
Triggers an Emergency PackNo
Summary0035433: Payables and Receivable Aging Balance Organization and General Ledger fields
DescriptionSeveral problems in Organization and General Ledger Filters in both Payables and Receivables Aging Schedule Reports.

Organization:
1. Validation similar to "AD_Org is transactions allowed" should be added

General Ledger:
1. Add validation to show only general ledgers available for the selected organization. The values should be updated each time the organization is changed.
Steps To ReproduceAs Openbravo Admin

Go to Payables Aging Schedule report (or Receivables Aging Schedule)
Verify * organization can be selected. This is wrong as this organization can't have transactions
Change org to F&B US.
Verify General Ledger "F&B España" is shown in selector. This is wrong as this general ledger is not available for F&B US
Proposed SolutionReview original code in legacy Aging Balance module and transplant it to the version in core for both reports.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00325353.0PR16Q3 closed markmm82 Report's currency and report's general ledger should be defaulted to organization's currency and organization's general ledger 
depends on backport 00356983.0PR17Q2 closed nonofrancisco Payables and Receivable Aging Balance Organization and General Ledger fields 
caused by feature request 00350893.0PR17Q2 closed nonofrancisco Integrate module Aging Balance Report into Openbravo 3 distribution 
related to feature request 0036034 new Triage Omni OMS Improve organization and general ledger parameters default value and on change function inside Aging process definition 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-06 11:31vmromanosNew Issue
2017-03-06 11:31vmromanosAssigned To => Triage Finance
2017-03-06 11:31vmromanosModules => Core
2017-03-06 11:31vmromanosTriggers an Emergency Pack => No
2017-03-06 11:31vmromanosAssigned ToTriage Finance => nonofrancisco
2017-03-06 11:34vmromanosRelationship addedcaused by 0035089
2017-03-15 21:09nonofranciscoStatusnew => scheduled
2017-03-15 21:25nonofranciscoNote Added: 0095304
2017-03-30 16:51aferrazRelationship addedrelated to 0032535
2017-03-30 17:08aferrazTarget Version3.0PR17Q2 => 3.0PR17Q2.1
2017-04-05 09:14vmromanosStatusscheduled => acknowledged
2017-04-05 09:14vmromanosTarget Version3.0PR17Q2.1 => 3.0PR17Q3
2017-04-05 09:15vmromanosStatusacknowledged => scheduled
2017-05-17 21:49hgbotCheckin
2017-05-17 21:49hgbotNote Added: 0096648
2017-05-17 21:49hgbotStatusscheduled => resolved
2017-05-17 21:49hgbotResolutionopen => fixed
2017-05-17 21:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/04a6552919851945d8ca428fc012d40c7f9a9020 [^]
2017-05-17 21:50hgbotCheckin
2017-05-17 21:50hgbotNote Added: 0096649
2017-05-17 21:52aferrazRegression level => Packaging and release
2017-05-17 21:52aferrazRegression date => 2017-02-23
2017-05-17 21:52aferrazRegression introduced in release => main
2017-05-17 21:52aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/251ea8a24d39 [^]
2017-05-17 21:55aferrazReview Assigned To => aferraz
2017-05-17 21:55aferrazNote Added: 0096650
2017-05-17 21:55aferrazStatusresolved => closed
2017-05-17 21:55aferrazFixed in Version => 3.0PR17Q3
2017-05-18 10:16aferrazRelationship addedrelated to 0036034
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096972
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096973

Notes
(0095304)
nonofrancisco   
2017-03-15 21:25   
Test plan:

As Openbravo Admin

Go to Payables Aging Schedule report
Verify * organization does not appears in selector, just organizations with transaction allowed can be selected.
Change org to F&B US.
Verify just General Ledger "F&B International Group US/A/US Dollar" is shown in selector.
Change org to F&B España - Región Norte.
Verify General Ledger "F&B International Group US/A/US Dollar" and "F&B España, S.A. US/A/Euro" are shown in selector.

Do the same for Receivables Aging Schedule
Verify the behavior is the same
(0096648)
hgbot   
2017-05-17 21:49   
Repository: erp/devel/pi
Changeset: 04a6552919851945d8ca428fc012d40c7f9a9020
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Tue May 09 13:28:14 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/04a6552919851945d8ca428fc012d40c7f9a9020 [^]

Fixes issue 35433: Aging Balance Organization and GL fields

* The default value of parameter Organization is the one selected when login,
if is transaction allowed, otherwise, the first one in the list of Organizations
with transaction allowed.

* When parameter Organization changes, the selected value of General Ledger
selector is set accordingly.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
A src/org/openbravo/common/actionhandler/AgingGeneralLedgerByOrganizationActionHandler.java
A src/org/openbravo/common/filterexpression/AgingGeneralLedgerFilterExpression.java
A src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0096649)
hgbot   
2017-05-17 21:50   
Repository: erp/devel/pi
Changeset: b069f040ba1098f708ce1c3802488ca14211d8ba
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed May 17 21:46:10 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b069f040ba1098f708ce1c3802488ca14211d8ba [^]

Related to issue 35433: Code review improvements

- Fix copyrights.
- Improve Account Schema Selector filter expression.
- Improve AgingOrganizationFilterExpression class.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src/org/openbravo/common/actionhandler/AgingGeneralLedgerByOrganizationActionHandler.java
M src/org/openbravo/common/filterexpression/AgingGeneralLedgerFilterExpression.java
M src/org/openbravo/common/filterexpression/AgingOrganizationFilterExpression.java
---
(0096650)
aferraz   
2017-05-17 21:55   
Code review + Testing OK
(0096972)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096973)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test