Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035427Openbravo ERP09. Financial managementpublic2017-03-03 12:532017-09-21 16:49
Reporterdmiguelez 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035427: Conversion of Valuation is not correct in Pareto Product Report
DescriptionConversion in Pareto Product Report is not correct.

The conversion of the currencies is not the same as in the Valued Stock Report.
The problem is that the total valuation is converted to the currency today, instead of converting each Transaction in the day it happened
Steps To ReproduceLaunch Pareto Product Report for:
* Org: US
* Currency: EUR

Launch Valued Stock Report for:
* Org: US
* Date: Today
*Currency: EUR

Check that the valuation of the Stock is different between both reports and this is a bug, it must be the same.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0032493 closed vmromanos Pareto Product Report takes too long in an environment with big amount of data 
Attached Filesdiff proposed_fix.diff (1,506) 2017-03-03 12:53
https://issues.openbravo.com/file_download.php?file_id=10533&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-03 12:53dmiguelezNew Issue
2017-03-03 12:53dmiguelezAssigned To => Triage Finance
2017-03-03 12:53dmiguelezFile Added: proposed_fix.diff
2017-03-03 12:53dmiguelezModules => Core
2017-03-03 12:53dmiguelezTriggers an Emergency Pack => No
2017-03-03 12:53dmiguelezRelationship addedrelated to 0032493
2017-08-07 18:03markmm82Assigned ToTriage Finance => markmm82
2017-08-07 18:04markmm82Statusnew => scheduled
2017-08-15 20:02markmm82Note Added: 0098510
2017-08-25 08:52hgbotCheckin
2017-08-25 08:52hgbotNote Added: 0098639
2017-08-25 08:52hgbotStatusscheduled => resolved
2017-08-25 08:52hgbotResolutionopen => fixed
2017-08-25 08:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bce3ce144ae4668ad29da2a5c3104395411767e1 [^]
2017-08-25 09:13aferrazReview Assigned To => aferraz
2017-08-25 09:13aferrazNote Added: 0098644
2017-08-25 09:13aferrazStatusresolved => closed
2017-08-25 09:13aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099326

Notes
(0098510)
markmm82   
2017-08-15 20:02   
Test Plan:
As Group Admin
- Launch Pareto Product Report for:
  Org: US
  Currency: EUR

- Launch Valued Stock Report for:
  Org: US
  Date: Today
  Currency: EUR

Check that the valuation of the Stock is the same in both reports.
(0098639)
hgbot   
2017-08-25 08:52   
Repository: erp/devel/pi
Changeset: bce3ce144ae4668ad29da2a5c3104395411767e1
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Aug 21 19:09:24 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bce3ce144ae4668ad29da2a5c3104395411767e1 [^]

Fixes issue 35427: Conversion of Valuation not correct in Pareto Product Report

The conversion of the currencies in Pareto Product Report is not the same as in the
Valued Stock Report. The problem is that the total valuation is converted to the
currency for today, instead of converting each Transaction in the day it happened.

This fix uses the transaction's date instead of the current date to convert
the valuation. Also is grouped by transaction's accounting date to have an homegeneous
behaviour like in CostingUtils.getCurrentValuedStock() and CostAdjustmentUtils.
getValuedStockOnTransactionDate() methods.

---
M src/org/openbravo/erpCommon/ad_reports/ReportParetoProduct_data.xsql
---
(0098644)
aferraz   
2017-08-25 09:13   
Code review + Testing OK
(0099326)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test