Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035426Openbravo ERPA. Platformpublic2017-03-03 11:392017-03-15 20:22
ReporterJONHM 
Assigned Toinigosanchez 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR16Q1.3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/92802596bf940d3c62c8e84547ea21e78055c0fc [^]
Triggers an Emergency PackNo
Summary0035426: Adaptive filtering capability does not work for Table references.
DescriptionAdaptive filtering capability (filter in client when all data is locally available) does not work for Table references when filtering by text instead of by selecting a value in the drop down list.
Steps To ReproduceAs 'F&B International Group Admin' Role:
1) Open [Business Partner] window.
2) Write 'EUR' in Currency column and press enter button or click elsewhere
--> The data is not filtered properly.
3) Click refresh button.
--> The data is filtered properly because in this case adaptive filtering is not used.

Note: On one hand 'Currency' field (Reference Table) is not filtering properly. On the other hand, 'Business Partner Category' field (Reference TableDir) is filtering properly.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00354643.0PR17Q1 closed inigosanchez Adaptive filtering capability does not work for Table references. 
depends on backport 00354653.0PR16Q4.4 closed inigosanchez Adaptive filtering capability does not work for Table references. 
depends on backport 00354663.0PR16Q3.6 closed inigosanchez Adaptive filtering capability does not work for Table references. 
caused by defect 0030800 closed caristu Filter on Property field in a table reference column doesn't work 
Attached Files? noFilterNullValues.mp4 (2,149,200) 2017-03-03 11:39
https://issues.openbravo.com/file_download.php?file_id=10531&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-03 11:39JONHMNew Issue
2017-03-03 11:39JONHMAssigned To => platform
2017-03-03 11:39JONHMFile Added: noFilterNullValues.mp4
2017-03-03 11:39JONHMModules => Core
2017-03-03 11:39JONHMResolution time => 1490310000
2017-03-03 11:39JONHMRegression introduced in release => 3.0PR15Q4.6
2017-03-03 11:39JONHMTriggers an Emergency Pack => No
2017-03-03 13:21heccamIssue Monitored: heccam
2017-03-07 11:43inigosanchezStatusnew => scheduled
2017-03-07 11:43inigosanchezAssigned Toplatform => inigosanchez
2017-03-07 15:48inigosanchezRegression level => Production - Confirmed Stable
2017-03-07 15:48inigosanchezRegression introduced in release3.0PR15Q4.6 => 3.0PR16Q1.3
2017-03-07 15:48inigosanchezSummaryFields are not automatically filtered if contains null values => Adaptive filtering capability does not work under some circumstances.
2017-03-07 15:48inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=14737#r14737
2017-03-07 15:48inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14739#r14739
2017-03-07 17:32inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/92802596bf940d3c62c8e84547ea21e78055c0fc [^]
2017-03-07 17:33inigosanchezSummaryAdaptive filtering capability does not work under some circumstances. => Adaptive filtering capability does not work for Table references.
2017-03-07 17:33inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=14744#r14744
2017-03-07 17:34inigosanchezRelationship addedcaused by 0030800
2017-03-09 12:23inigosanchezStatusscheduled => acknowledged
2017-03-09 12:24inigosanchezStatusacknowledged => scheduled
2017-03-10 08:54alostaleDescription Updatedbug_revision_view_page.php?rev_id=14764#r14764
2017-03-10 08:54alostaleDescription Updatedbug_revision_view_page.php?rev_id=14765#r14765
2017-03-10 10:08inigosanchezReview Assigned To => caristu
2017-03-10 10:16hgbotCheckin
2017-03-10 10:16hgbotNote Added: 0094898
2017-03-10 10:16hgbotStatusscheduled => resolved
2017-03-10 10:16hgbotResolutionopen => fixed
2017-03-10 10:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1eb8d1da9bb9ce7a5fe437518953c4cbe150ae44 [^]
2017-03-10 10:20inigosanchezNote Added: 0094899
2017-03-10 14:38hgbotCheckin
2017-03-10 14:38hgbotNote Added: 0094921
2017-03-10 14:39caristuNote Added: 0094922
2017-03-10 14:39caristuStatusresolved => closed
2017-03-10 14:39caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:21hudsonbotCheckin
2017-03-15 20:21hudsonbotNote Added: 0095284
2017-03-15 20:22hudsonbotCheckin
2017-03-15 20:22hudsonbotNote Added: 0095289

Notes
(0094898)
hgbot   
2017-03-10 10:16   
Repository: erp/devel/pi
Changeset: 1eb8d1da9bb9ce7a5fe437518953c4cbe150ae44
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Mar 10 10:15:36 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1eb8d1da9bb9ce7a5fe437518953c4cbe150ae44 [^]

Fixed issue 35426: Adaptive filtering does not work for Table references.

The problem was that adaptive filtering (filter in client when all data is locally available) did
not work for Table references when filtering by text instead of by selecting a value in the drop
down list. The issue that causes this regression was not taking into account adaptive filtering.

This problem has been fixed by taking into account this case in getDisplayProperty method. Now
getDisplayProperty method manages properly when all the data are in the client (Adaptive filtering).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0094899)
inigosanchez   
2017-03-10 10:20   
Several manual test can be found here: https://docs.google.com/a/openbravo.com/spreadsheets/d/1LhUQG2Yvs7ZaRyILhNnginbiBFvpDNiydHIFivVYkEs/edit?usp=sharing [^]

Pending to add an automatic test in pi-smoke-platform.
(0094921)
hgbot   
2017-03-10 14:38   
Repository: erp/devel/pi
Changeset: 5e4e6352a9f740fca721ac0aa04a7d9d9e1c4ef4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Mar 10 14:37:32 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5e4e6352a9f740fca721ac0aa04a7d9d9e1c4ef4 [^]

related to issue 35426: improved comments

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0094922)
caristu   
2017-03-10 14:39   
Code review + tested OK.

Filtering by a column based on a Table reference is working both in client and server side.
(0095284)
hudsonbot   
2017-03-15 20:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095289)
hudsonbot   
2017-03-15 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test