Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035419Openbravo ERP07. Sales managementpublic2017-03-01 15:092017-03-04 14:51
Reporterngarcia 
Assigned Tomcobas 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035419: Cannot remove an orphan line from a return to vendor or a return from customer document
DescriptionCannot remove an orphan line from a return to vendor or a return from customer document
Steps To ReproduceAs group admin role:
   Set the 'RM Allow Orphan Line' to Y
   Log out and log in
   Create a Return To Vendor header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check No Items to Show is shown in Orphan Lines section

   Create a Return From Customer header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check 'No Items to Show' is shown in Orphan Lines section
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035396 closed mcobas Cannot remove an orphan line from a return to vendor or a return from customer document 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-02 19:54markmm82Typedefect => backport
2017-03-02 19:54markmm82Target Version => 3.0PR17Q1
2017-03-04 14:43hgbotCheckin
2017-03-04 14:43hgbotNote Added: 0094756
2017-03-04 14:43hgbotStatusscheduled => resolved
2017-03-04 14:43hgbotResolutionopen => fixed
2017-03-04 14:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/dc07ac3f254c7c8f9bf6062d22b48d3b092a85f7 [^]
2017-03-04 14:51markmm82Review Assigned To => markmm82
2017-03-04 14:51markmm82Note Added: 0094761
2017-03-04 14:51markmm82Statusresolved => closed
2017-03-04 14:51markmm82Fixed in Version => 3.0PR17Q1

Notes
(0094756)
hgbot   
2017-03-04 14:43   
Repository: erp/backports/3.0PR17Q1
Changeset: dc07ac3f254c7c8f9bf6062d22b48d3b092a85f7
Author: Miguel <martencobasmiguel <at> gmail.com>
Date: Thu Mar 02 14:17:25 2017 -0500
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/dc07ac3f254c7c8f9bf6062d22b48d3b092a85f7 [^]

Fixes issue 35419:Cannot remove an orphan line in Return to/from vendor/customer

Was not able to remove an orphan line from a return to vendor or a return from
customer document because an incorrect casting to boolean.

When is validating tha Last record is selected inside the Orphan grid lines, the
lastRecord.get("obSelected") object gets as String instead of a Boolean object,
in other case it gets as Boolean.

Now, conditions are rightly validated depending of the class of the object.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
---
(0094761)
markmm82   
2017-03-04 14:51   
Code review + Testing OK