Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035404Openbravo ERPA. Platformpublic2017-03-02 12:352019-07-23 08:34
Reporteralostale 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionout of date 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035404: insufficient information in log when a view has jslint errors
DescriptionWhen a generated view has jslint errors, they are logged in openbravo.log. But there's no information about which is the view that has problems.
Steps To ReproduceBefore issue 0035403 is fixed:

1. As System Admin set User Interface Application module in development
2. As Group Admin open Financial Account window
  -> check openbravo.log:
632e68c4 2017-02-01 00:16:17,635 [ajp-bio-127.0.0.1-8009-exec-1] ERROR org.openbravo.client.kernel.ComponentGenerator - Error parsing component View
>>>>>>> Issues found in javascript <<<<<<<<<
Core.View:1967:52: Weird condition. >> offending code: f.disableItem('aprmFinaccTransOrigin', ('Y') || (OB.Utilities.getValue(currentValues,'aprmFinaccTransOrigin') !== '') === false);
>>>>>>> Issues (1969ms) <<<<<<<<<
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035403 closed vmromanos jslint error in Financial Account window 
related to feature request 0039983 closed jarmendariz Upgrade javascript linter and formatter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-02 12:35alostaleNew Issue
2017-03-02 12:35alostaleAssigned To => platform
2017-03-02 12:35alostaleModules => Core
2017-03-02 12:35alostaleTriggers an Emergency Pack => No
2017-03-02 12:35alostaleRelationship addedrelated to 0035403
2017-03-02 12:37alostaleRelationship addedrelated to 0035405
2017-03-02 12:38alostaleRelationship deletedrelated to 0035405
2017-03-02 12:52alostaleAssigned Toplatform => alostale
2017-03-02 12:52alostaleReview Assigned To => caristu
2017-03-02 12:53hgbotCheckin
2017-03-02 12:53hgbotNote Added: 0094682
2017-03-02 12:53hgbotStatusnew => resolved
2017-03-02 12:53hgbotResolutionopen => fixed
2017-03-02 12:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/71f6e1ff155295022d631faf833a1d818872e4b7 [^]
2017-03-10 13:42caristuNote Added: 0094917
2017-03-10 13:42caristuStatusresolved => new
2017-03-10 13:42caristuResolutionfixed => open
2017-03-15 20:20hudsonbotCheckin
2017-03-15 20:20hudsonbotNote Added: 0095248
2017-03-31 10:09hgbotCheckin
2017-03-31 10:09hgbotNote Added: 0095749
2017-04-01 12:06hudsonbotCheckin
2017-04-01 12:06hudsonbotNote Added: 0095777
2017-04-07 09:05alostaleStatusnew => acknowledged
2017-04-10 14:33alostaleAssigned Toalostale => platform
2017-04-10 19:09caristuReview Assigned Tocaristu =>
2019-07-22 14:22alostaleStatusacknowledged => scheduled
2019-07-23 08:34alostaleNote Added: 0113585
2019-07-23 08:34alostaleStatusscheduled => closed
2019-07-23 08:34alostaleResolutionopen => out of date
2019-07-23 08:34alostaleRelationship addedrelated to 0039983

Notes
(0094682)
hgbot   
2017-03-02 12:53   
Repository: erp/devel/pi
Changeset: 71f6e1ff155295022d631faf833a1d818872e4b7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 02 12:49:53 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/71f6e1ff155295022d631faf833a1d818872e4b7 [^]

fixed bug 35404: insufficient information in log when a view has jslint errors

  Added window name and id to be shown in log

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ComponentGenerator.java
---
(0094917)
caristu   
2017-03-10 13:42   
Reopened, log information is not being displayed for the problem reported in 0035403: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0095248)
hudsonbot   
2017-03-15 20:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095749)
hgbot   
2017-03-31 10:09   
Repository: erp/devel/pi
Changeset: 30a984e553cb0a5f69df60cc51982cd40270a25a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 31 10:08:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/30a984e553cb0a5f69df60cc51982cd40270a25a [^]

related to bug 35404: backout changeset 71f6e1ff155295022

  Fix was not correct, it didn't work in all cases because of CDI proxies.
  Proxied instance was not correctly initialized on casting.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ComponentGenerator.java
---
(0095777)
hudsonbot   
2017-04-01 12:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/44185ff76d75 [^]
Maturity status: Test
(0113585)
alostale   
2019-07-23 08:34   
Project 0039983 removed jslint on generated code