Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035396Openbravo ERP07. Sales managementpublic2017-03-01 15:092017-03-15 20:21
Reporterngarcia 
Assigned Tomcobas 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-02-03
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/905bb6ff4ee7 [^]
Triggers an Emergency PackNo
Summary0035396: Cannot remove an orphan line from a return to vendor or a return from customer document
DescriptionCannot remove an orphan line from a return to vendor or a return from customer document
Steps To ReproduceAs group admin role:
   Set the 'RM Allow Orphan Line' to Y
   Log out and log in
   Create a Return To Vendor header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check No Items to Show is shown in Orphan Lines section

   Create a Return From Customer header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check 'No Items to Show' is shown in Orphan Lines section
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00354193.0PR17Q1 closed mcobas Cannot remove an orphan line from a return to vendor or a return from customer document 
depends on backport 00354203.0PR16Q4.3 closed mcobas Cannot remove an orphan line from a return to vendor or a return from customer document 
depends on backport 00354213.0PR16Q3.6 closed mcobas Cannot remove an orphan line from a return to vendor or a return from customer document 
caused by defect 00319893.0PR16Q2 closed caristu Wrong behavior in order/invoices grid in Add Payment process definition when having >100 records selected 
related to defect 0040381 closed alostale incorrect warn message logged by ReadOnlyDataSourceService for P&E  
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-01 15:09ngarciaNew Issue
2017-03-01 15:09ngarciaAssigned To => Triage Finance
2017-03-01 15:09ngarciaModules => Core
2017-03-01 15:09ngarciaResolution time => 1490137200
2017-03-01 15:09ngarciaTriggers an Emergency Pack => No
2017-03-01 15:10ngarciaIssue Monitored: networkb
2017-03-01 15:40PracticsIssue Monitored: Practics
2017-03-01 15:43heccamIssue Monitored: heccam
2017-03-01 17:09markmm82Assigned ToTriage Finance => mcobas
2017-03-02 19:54markmm82Statusnew => scheduled
2017-03-02 20:00markmm82Note Added: 0094700
2017-03-02 20:12markmm82Regression level => Production - Confirmed Stable
2017-03-02 20:12markmm82Regression date => 2016-02-03
2017-03-02 20:12markmm82Regression introduced in release => 3.0PR16Q2
2017-03-02 20:12markmm82Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/905bb6ff4ee7 [^]
2017-03-02 20:24markmm82Relationship addedcaused by 0031989
2017-03-04 14:40hgbotCheckin
2017-03-04 14:40hgbotNote Added: 0094755
2017-03-04 14:40hgbotStatusscheduled => resolved
2017-03-04 14:40hgbotResolutionopen => fixed
2017-03-04 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9d671a527e68e81acd632c9ec28a5af06f59084a [^]
2017-03-04 14:53markmm82Review Assigned To => markmm82
2017-03-04 14:53markmm82Note Added: 0094762
2017-03-04 14:53markmm82Statusresolved => closed
2017-03-04 14:53markmm82Fixed in Version => 3.0PR17Q2
2017-03-15 20:21hudsonbotCheckin
2017-03-15 20:21hudsonbotNote Added: 0095270
2019-03-27 10:54caristuRelationship addedrelated to 0040381

Notes
(0094700)
markmm82   
2017-03-02 20:00   
As group admin role:
   Set the 'RM Allow Orphan Line' to Y
   Log out and log in
   Create a Return To Vendor header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check the previous created line is shown in Orphan Lines section
   Uncheck and DONE
   Notice the orphan line has been deleted from the RTV

   Create a Return From Customer header
   Insert Orphan Line
   Click Pick/Edit Lines button
   Check the previous created line is shown in Orphan Lines section
   Uncheck and DONE
   Notice the orphan line has been deleted from the RFC
(0094755)
hgbot   
2017-03-04 14:40   
Repository: erp/devel/pi
Changeset: 9d671a527e68e81acd632c9ec28a5af06f59084a
Author: Miguel <martencobasmiguel <at> gmail.com>
Date: Thu Mar 02 13:32:12 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/9d671a527e68e81acd632c9ec28a5af06f59084a [^]

Fixes issue 35396:Cannot remove an orphan line in Return to/from vendor/customer

Was not able to remove an orphan line from a return to vendor or a return from
customer document because an incorrect casting to boolean.

When is validating tha Last record is selected inside the Orphan grid lines, the
lastRecord.get("obSelected") object gets as String instead of a Boolean object,
in other case it gets as Boolean.

Now, conditions are rightly validated depending of the class of the object.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
---
(0094762)
markmm82   
2017-03-04 14:53   
Code review + Testing OK
(0095270)
hudsonbot   
2017-03-15 20:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test