Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035394ModulesAnalyticspublic2017-03-01 12:372017-03-21 19:29
Reporterngarcia 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocaristu
Support ticket
OBNetwork customer
Regression introduced in release
Summary0035394: Keep Only and Keep and Include Level options do not work for trees in Dimensional Reports and widgets
DescriptionKeep Only and Keep and Include Level options do not work for trees in Dimensional Reports and widgets.

Note than Keep Only is working as expected in [OB Analytics] window.
Steps To ReproduceAs System administrator role:
   Go to [Process Request] window.
   Run immediately "Update Time Dimension Refs + Tree Closure Table" process.

As F&B International Group Admin role:
   Open [OB Analytics] window.
   Select the Sample Purchase/Sales Order Line Cube.
   Add Line Net Amount as a measure.
   Add Organization as dimension.
   Save it.

   Go to [Analytics Queries] window and select Publish option.
   Go to [Dimensional Reports] window and select the previously created query
   Click on one organization, select Keep Only option and check the output is not modified.
   The same happens for the Keep and Include Level feature.

As System administrator role:
   Create a new widget
      Widget Superclass: Analytics Widget
      Enable for all Users: Y
      Add the previously created query (Analytics Query) in Analytics tab

As F&B International Group Admin role:
   Add the widget in the workspace.
   Click on one organization, select Keep Only option and check the output is not modified.
   The same happens for the Keep and Include Level feature.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034158 closed caristu Keep Only and Keep and Include Level options do not work for trees in OB Analytics window 
caused by feature request 0032215 closed caristu upgrade analytics stack 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-01 12:37ngarciaNew Issue
2017-03-01 12:37ngarciaAssigned To => platform
2017-03-01 12:37ngarciaResolution time => 1490137200
2017-03-01 12:38ngarciaRelationship addedcaused by 0032215
2017-03-01 12:38ngarciaRelationship addedhas duplicate 0034158
2017-03-01 12:38ngarciaIssue Monitored: networkb
2017-03-14 16:10inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14793#r14793
2017-03-15 09:21inigosanchezAssigned Toplatform => inigosanchez
2017-03-15 10:26inigosanchezRelationship replacedrelated to 0034158
2017-03-15 12:30inigosanchezStatusnew => scheduled
2017-03-15 12:39inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=14799#r14799
2017-03-15 12:39inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14800#r14800
2017-03-16 14:27inigosanchezNote Added: 0095323
2017-03-16 16:33hgbotCheckin
2017-03-16 16:33hgbotNote Added: 0095330
2017-03-16 16:33hgbotStatusscheduled => resolved
2017-03-16 16:33hgbotResolutionopen => fixed
2017-03-16 16:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/7c3d5591834f61b88f8beeff070a47a44a99c794 [^]
2017-03-16 17:11inigosanchezReview Assigned To => caristu
2017-03-21 12:13hgbotCheckin
2017-03-21 12:13hgbotNote Added: 0095462
2017-03-21 19:14hgbotCheckin
2017-03-21 19:14hgbotNote Added: 0095488
2017-03-21 19:29caristuNote Added: 0095489
2017-03-21 19:29caristuStatusresolved => closed

Notes
(0095323)
inigosanchez   
2017-03-16 14:27   
Three manual test have been added in TestLink in order to cover this regression:
 + Platform > [ANA] Analytics > [ANAa] OB Analytics window > ANAa010: Keep Only and Keep and Include Level
 + Platform > [ANA] Analytics > [ANAb] Dimensional Reports > ANAb010: Keep Only and Keep and Include Level
 + Platform > [ANA] Analytics > [ANAc] Analytics Widget > ANAc010: Keep Only and Keep and Include Level
(0095330)
hgbot   
2017-03-16 16:33   
Repository: erp/pmods/org.openbravo.client.analytics
Changeset: 7c3d5591834f61b88f8beeff070a47a44a99c794
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Mar 16 16:22:58 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/7c3d5591834f61b88f8beeff070a47a44a99c794 [^]

Fixed issue 35394: Keep Only and Keep and Include Level options is not working

The problem was that "Keep Only" and "Keep and Include Level" options did not work for trees in
Dimensional Reports and widgets. When you open a Analytic query in a Dimensional Report or in a
Analytics Widgets the code is assuming that dimension_list exists.


This dimension_list is used in OB Analytics window but not in Dimensional Reports or Analytics
widget. Note than dimension_list is related with the edit panel in OB Analytics window (Measures,
Columns, Rows and Filter sections).

This issue has been resolved by managing this uncontrolled situation. Now when Dimensional Report
is launched or widget is added into the workspace, it is take into account that dimension_list is
not exists.

---
M web/org.openbravo.client.analytics/saiku/js/saiku/views/WorkspaceDropZone.js
---
(0095462)
hgbot   
2017-03-21 12:13   
Repository: erp/pmods/org.openbravo.client.analytics
Changeset: b2813949964ac16639076986091ec948e74404b2
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Mar 20 18:04:55 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/b2813949964ac16639076986091ec948e74404b2 [^]

Related to issue 35394: Apply proper JS formatting

---
M web/org.openbravo.client.analytics/saiku/js/saiku/views/WorkspaceDropZone.js
---
(0095488)
hgbot   
2017-03-21 19:14   
Repository: erp/pmods/org.openbravo.client.analytics
Changeset: ec4aa743e9d7797d786432d7d8e117c2a13c10e8
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Mar 21 19:14:04 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/ec4aa743e9d7797d786432d7d8e117c2a13c10e8 [^]

Related to issue 35394: Improve if conditions and apply proper JS formatting

---
M web/org.openbravo.client.analytics/saiku/js/saiku/views/WorkspaceDropZone.js
---
(0095489)
caristu   
2017-03-21 19:29   
Code reviewed + tested OK.

Fixed in version 1.4.400