Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035372Retail ModulesWeb POSpublic2017-02-27 21:072017-03-14 18:05
ReporterOsmany 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035372: [SER-QA 2497] Overlapping popup appears in Web POS after paying with check duplicate.
DescriptionOverlapping popup appears in Web POS after paying with check duplicate.
Steps To ReproducePreconditions:
Install two modules:
org.openbravo.retail.digitalcoupons
org.openbravo.retail.chequecadeau

In Openbravo backoffice:
 * Go to Preference window
  - Create a new record for preference: "Web POS Close Drawer Before Continue". Value = 'Y', Selected = 'Y'.
  - Create another preference for: "WebPOS Synchronized Mode". Value = 'Y', Selected = 'Y'.
 * Go to POS Terminal Type window and search for "VBS POS Terminal Type". Go to Payment Method tab and make sure "Allow Open Drawer" is selected for 'Credit card' payment method.
 * Go to POS Terminal window and search "vbs-1" terminal. Configure Hardware URL = "http://localhost:8090/printer". [^]

1.- Log into WebPOS and open HWM
2.- Create a ticket and pay it using Payment Method(Is Digital Coupon)
     For have a Payment Method with Digital Coupon.
     1.Login ERP
     2.Navigate to POS Terminal Type window.
     3.Select record (VBS POS Terminal Type)
     4.Checked (Is Digital Coupon) in any Payment Method
3.- Introduce a manual check:
  * Barcode: 1234567890
  * Check Number: 1234567890
  * Amount: Total amount of the ticket
  * Expiration date: tomorrow
4.- Close the drawer and finalize the payment
5.- Create another ticket
6.- Create a manual check
  * Barcode: 1234567890
  * Check Number: 1234567890
  * Amount: Total amount of the ticket
  * Expiration date: tomorrow
7.- Try to pay it
8.- Realize that the message that the check has been used appears but the screen is blocked. This is why there is another pop up: close the drawer.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
related to defect 0034838 closed ranjith_qualiantech_com Green popup appears in Web POS after paying with overpayment 
Attached Filespatch 7876.patch (1,723) 2017-03-01 18:51
https://issues.openbravo.com/file_download.php?file_id=10527&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-27 21:07OsmanyNew Issue
2017-02-27 21:07OsmanyAssigned To => Retail
2017-02-27 21:07OsmanyOBNetwork customer => Yes
2017-02-27 21:07OsmanyResolution time => 1489100400
2017-02-27 21:07OsmanyTriggers an Emergency Pack => No
2017-02-27 22:21OsmanyRelationship addedrelated to 0034838
2017-02-28 12:13jorge-garciaResolution time1489100400 => 1489359600
2017-02-28 13:04adrianromeroTag Attached: SER-QA
2017-02-28 14:17OsmanySteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14691#r14691
2017-03-01 14:52mario_castelloAssigned ToRetail => mario_castello
2017-03-01 14:56mario_castelloStatusnew => acknowledged
2017-03-01 18:51mario_castelloFile Added: 7876.patch
2017-03-01 18:51mario_castelloStatusacknowledged => scheduled
2017-03-07 15:29hgbotCheckin
2017-03-07 15:29hgbotNote Added: 0094797
2017-03-07 15:29hgbotStatusscheduled => resolved
2017-03-07 15:29hgbotResolutionopen => fixed
2017-03-07 15:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c50398f7e239902ce9c0c4eb63776b7ddbaace86 [^]
2017-03-09 13:38marvintmNote Added: 0094877
2017-03-09 13:38marvintmStatusresolved => new
2017-03-09 13:38marvintmResolutionfixed => open
2017-03-09 15:32mario_castelloStatusnew => acknowledged
2017-03-09 15:32mario_castelloStatusacknowledged => scheduled
2017-03-13 16:19hgbotCheckin
2017-03-13 16:19hgbotNote Added: 0094981
2017-03-13 16:19hgbotStatusscheduled => resolved
2017-03-13 16:19hgbotResolutionopen => fixed
2017-03-13 16:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c50398f7e239902ce9c0c4eb63776b7ddbaace86 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0d472be24373a592fab66e5a8273654630ab55f3 [^]
2017-03-14 18:05marvintmReview Assigned To => marvintm
2017-03-14 18:05marvintmStatusresolved => closed
2017-03-14 18:05marvintmFixed in Version => RR17Q2

Notes
(0094797)
hgbot   
2017-03-07 15:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c50398f7e239902ce9c0c4eb63776b7ddbaace86
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 01 11:43:29 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c50398f7e239902ce9c0c4eb63776b7ddbaace86 [^]

Fixed issue 0035372: [SER-QA 2497] Overlapping popup appears in Web POS after paying with check duplicate.

- Create new event checkOpenDrawer to replaced the closed event when call the OpenDrawer
- Call the event checkOpenDrawer when the PreOrderSaveHook finish the execution
- The onclosed event is executed before the PreOrderSaveHook and if the hook failed it is unnecessary call the OpenDrawer

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0094877)
marvintm   
2017-03-09 13:38   
It seems the multiorders flow was ignored when doing the change. I assume the checkOpenDrawer trigger must also be called in that flow.
(0094981)
hgbot   
2017-03-13 16:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0d472be24373a592fab66e5a8273654630ab55f3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Mar 10 11:38:07 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0d472be24373a592fab66e5a8273654630ab55f3 [^]

Fixed issue 0035372: [SER-QA 2497] Overlapping popup appears in Web POS after paying with check duplicate.

- Replace the event onclosed in multiorder with the new event checkOpenDrawer
- Called the event checkOpenDrawer when all pending order have been processed

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---