Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035364 | Retail Modules | Web POS | public | 2017-02-27 12:04 | 2017-03-24 11:01 |
|
| Reporter | adrianromero | |
| Assigned To | mario_castello | |
| Priority | urgent | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR17Q2 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035364: [SER-QA 2472] Columns startingcash, totalsales, totalreturns, amounttokeep must by not null and default 0 |
| Description | The columns startingcash, totalsales, totalreturns, amounttokeep of obpos_paymentmethodcashup must be defined at database level and openbravo level as not null and with default 0.
Also, in order to fix posible wrong data, the following sql sentences must be executed:
update obpos_paymentmethodcashup set amounttokeep = 0 where amounttokeep is null;
update obpos_paymentmethodcashup set startingcash = 0 where startingcash is null;
update obpos_paymentmethodcashup set totalsales = 0 where totalsales is null;
update obpos_paymentmethodcashup set totalreturns = 0 where totalreturns is null; |
| Steps To Reproduce | N/A |
| Proposed Solution | |
| Additional Information | |
| Tags | SER-QA |
| Relationships | | related to | defect | 0035472 | | closed | mario_castello | API Change: Columns startingcash, totalsales, totalreturns, amounttokeep must by not null and default 0 |
|
| Attached Files |  7875.patch (5,090) 2017-02-28 17:29
https://issues.openbravo.com/file_download.php?file_id=10516&type=bug
modulescript35364.patch (4,816) 2017-03-09 21:29
https://issues.openbravo.com/file_download.php?file_id=10549&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-02-27 12:04 | adrianromero | New Issue | |
| 2017-02-27 12:04 | adrianromero | Assigned To | => Retail |
| 2017-02-27 12:04 | adrianromero | Resolution time | => 1489359600 |
| 2017-02-27 12:04 | adrianromero | Triggers an Emergency Pack | => No |
| 2017-02-27 12:05 | adrianromero | Tag Attached: SER-QA | |
| 2017-02-28 16:36 | mario_castello | Assigned To | Retail => mario_castello |
| 2017-02-28 17:03 | mario_castello | Status | new => acknowledged |
| 2017-02-28 17:29 | mario_castello | File Added: 7875.patch | |
| 2017-03-09 17:37 | mario_castello | Relationship added | related to 0035472 |
| 2017-03-09 17:37 | mario_castello | Status | acknowledged => scheduled |
| 2017-03-09 21:29 | mario_castello | File Added: modulescript35364.patch | |
| 2017-03-13 22:50 | hgbot | Checkin | |
| 2017-03-13 22:50 | hgbot | Note Added: 0094985 | |
| 2017-03-13 22:50 | hgbot | Status | scheduled => resolved |
| 2017-03-13 22:50 | hgbot | Resolution | open => fixed |
| 2017-03-13 22:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3e1d00c844d3c91f1f5ea548c188dd8a01e99e6 [^] |
| 2017-03-14 00:33 | hgbot | Checkin | |
| 2017-03-14 00:33 | hgbot | Note Added: 0094987 | |
| 2017-03-16 21:11 | hgbot | Checkin | |
| 2017-03-16 21:11 | hgbot | Note Added: 0095347 | |
| 2017-03-16 21:12 | mario_castello | Note Edited: 0095347 | bug_revision_view_page.php?bugnote_id=0095347#r14842 |
| 2017-03-17 12:53 | marvintm | Note Added: 0095377 | |
| 2017-03-17 12:53 | marvintm | Status | resolved => new |
| 2017-03-17 12:53 | marvintm | Resolution | fixed => open |
| 2017-03-20 15:53 | mario_castello | Status | new => scheduled |
| 2017-03-21 15:14 | hgbot | Checkin | |
| 2017-03-21 15:14 | hgbot | Note Added: 0095473 | |
| 2017-03-21 15:14 | hgbot | Status | scheduled => resolved |
| 2017-03-21 15:14 | hgbot | Resolution | open => fixed |
| 2017-03-21 15:14 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3e1d00c844d3c91f1f5ea548c188dd8a01e99e6 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d88634bec142b4c5fc0ef30065ad37d043061e66 [^] |
| 2017-03-24 11:01 | marvintm | Review Assigned To | => marvintm |
| 2017-03-24 11:01 | marvintm | Status | resolved => closed |
| 2017-03-24 11:01 | marvintm | Fixed in Version | => RR17Q2 |
|
Notes |
|
|
(0094985)
|
|
hgbot
|
|
2017-03-13 22:50
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d3e1d00c844d3c91f1f5ea548c188dd8a01e99e6
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 08 14:42:31 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3e1d00c844d3c91f1f5ea548c188dd8a01e99e6 [^]
Fixed issue 0035364: [SER-QA 2472] Columns startingcash, totalsales, totalreturns, amounttokeep must by not null and default 0
- Set default value 0 for columns startingcash, totalsales, totalreturns, amounttokeep
---
M src-db/database/model/tables/OBPOS_PAYMENTMETHODCASHUP.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
|
|
|
|
(0094987)
|
|
hgbot
|
|
2017-03-14 00:33
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eda11b75aa26e1776f5d6759eb47e432e5e465b1
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Mar 09 11:25:32 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda11b75aa26e1776f5d6759eb47e432e5e465b1 [^]
Related to issue 35364: Added new modulescript to fix data
---
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.java
---
|
|
|
|
(0095347)
|
|
hgbot
|
2017-03-16 21:11
(edited on: 2017-03-16 21:12) |
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 145f4f1e3b544f844032c6128461b344e16e3987
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 15 07:56:56 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/145f4f1e3b544f844032c6128461b344e16e3987 [^]
Verifies issue 35364: Fixed module script FixDataIssue35364
- Refactor modulescript class to fix problems in oracle
---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.java
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.class
---
|
|
|
|
|
The fix itself is correct.
The modulescript queries are also correct, but they should be moved to an xsql file, so that there is no risk of leaking open prepared statements. Alternatively, the prepared statements could be manually closed, but it would be better if xsql is used, like in other modulescripts. |
|
|
|
(0095473)
|
|
hgbot
|
|
2017-03-21 15:14
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d88634bec142b4c5fc0ef30065ad37d043061e66
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Mar 17 09:17:34 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d88634bec142b4c5fc0ef30065ad37d043061e66 [^]
Fixed issue 35364: Refactor modulescript FixDataIssue35364
- Moved the queries to an xsql file
---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364.java
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364Data.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue35364_Data.xsql
---
|
|