Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035334Openbravo ERPA. Platformpublic2017-02-22 10:552017-03-15 20:20
Reportermaite 
Assigned Toinigosanchez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2016-09-08
Regression introduced in release3.0PR16Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b4a8ad7a445ff946888867836f3c3c80cb988f2a [^]
Triggers an Emergency PackNo
Summary0035334: Callout problem when working with comma (,) as decimal separator
DescriptionCallout calculations are wrong when Format.xml is configured with comma (,) as decimal separator
Steps To Reproduce1. Edit config/Format.xml file to set comma as decimal separator for all references
2. Compile application using: ant smartbuild
3. Register new Sales Invoice record for "España" org and any BP. Add any line
4. Access to "Exchange Rate" tab, create new record setting USD, set "Foreign Amount"= 5 and realize that "Rate" field has not been properly calculated

Problem is also reproducible in Financial Account window, Transactions tab:
0. Access Financial Account window, Payment Method tab and modify Transferencia to leave it as "Automatic Deposit"=NO
1. Access Payment In window, set "Alimentos y Supermercados, S.A" and any decimal amount
2. Run "Add details" process and pay pending invoice with already set amount, Select "Process payment" option
3. Access Transactions tab in financial account "cuenta de banco", create new record. select previously created payment in "payment" selector and realize that Deposit Amount is not correct
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035213 closed inigosanchez Callout problem when working with comma (,) as decimal separator for euro references defined in format.xml 
depends on backport 00353493.0PR17Q1 closed inigosanchez Callout problem when working with comma (,) as decimal separator 
depends on backport 00353503.0PR16Q4.3 closed inigosanchez Callout problem when working with comma (,) as decimal separator 
caused by design defect 00323663.0PR16Q4 closed inigosanchez callout invocation ineficiencies 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-22 10:55maiteNew Issue
2017-02-22 10:55maiteAssigned To => platform
2017-02-22 10:55maiteModules => Core
2017-02-22 10:55maiteResolution time => 1488150000
2017-02-22 10:55maiteTriggers an Emergency Pack => No
2017-02-22 10:55maiteRelationship addedrelated to 0035213
2017-02-22 10:55maiteIssue Monitored: networkb
2017-02-22 10:56jfrancesIssue Monitored: jfrances
2017-02-22 11:18inigosanchezStatusnew => scheduled
2017-02-22 11:18inigosanchezAssigned Toplatform => inigosanchez
2017-02-23 16:13inigosanchezRelationship addedcaused by 0032366
2017-02-23 16:16inigosanchezRegression level => Packaging and release
2017-02-23 16:16inigosanchezRegression date => 2016-09-08
2017-02-23 16:16inigosanchezRegression introduced in release => 3.0PR16Q4
2017-02-23 16:16inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b4a8ad7a445ff946888867836f3c3c80cb988f2a [^]
2017-02-23 16:19inigosanchezStatusscheduled => acknowledged
2017-02-23 16:20inigosanchezStatusacknowledged => scheduled
2017-02-23 16:25inigosanchezRegression levelPackaging and release => Production - QA Approved
2017-02-23 17:01inigosanchezNote Added: 0094579
2017-02-27 10:42hgbotCheckin
2017-02-27 10:42hgbotNote Added: 0094626
2017-02-27 10:42hgbotStatusscheduled => resolved
2017-02-27 10:42hgbotResolutionopen => fixed
2017-02-27 10:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e7630e80f729dd6a8740250bae5ab6769f0780b0 [^]
2017-02-27 11:29inigosanchezReview Assigned To => caristu
2017-02-27 13:44inigosanchezNote Added: 0094640
2017-03-03 15:33caristuNote Added: 0094750
2017-03-03 15:33caristuStatusresolved => closed
2017-03-03 15:33caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:20hudsonbotCheckin
2017-03-15 20:20hudsonbotNote Added: 0095236

Notes
(0094579)
inigosanchez   
2017-02-23 17:01   
Added Test suite in TestLink > Platform > Format > [SSC] Separators & SimpleCallouts.
(0094626)
hgbot   
2017-02-27 10:42   
Repository: erp/devel/pi
Changeset: e7630e80f729dd6a8740250bae5ab6769f0780b0
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Feb 27 10:40:30 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e7630e80f729dd6a8740250bae5ab6769f0780b0 [^]

Fixed issue 35334:Callout problem when working with comma as decimal separator

The problem was raised when a default format were switched, it means, when
decimal and group separator were switched. In this situation, when
SimpleCalloutInformationProvider class was used to obtain the current element
value and this current element was a BigDecimal, the format was not managed
properly. This occurred because getCurrentElementValue method always retrieved
a String element instead of Object element, in tyhis case BigDecimal.

In this situation, managesUpdatedValuesForCallout method of FIC class compare
if element is a String or not. If a BigDecimal is retrieved as String element,
in this part of the code the format is not managed properly when decimal separator
is comma. The code manage the comma separator as group separator and removed it.

When the decimal separator is dot (.) the format is managed as expected although
this method retrieves a String object (e.g. "1.23"). When decimal separator is
comma (,) this BigDecimal (e.g. 1,24) is retrieved by getCurrentElementValue method
as String value and the format is missed.

This problem has been fixed by take into account type of current element inside
getCurrentElementValue method. Now this method retrieves an object value. In this
case, a BigDecimal is retrieved. Now the format is managed properly.

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
---
(0094640)
inigosanchez   
2017-02-27 13:44   
Added automated tests in pi-smoke-platform: https://code.openbravo.com/tools/automation/pi-smoke-platform/rev/365692ebd32b [^]
(0094750)
caristu   
2017-03-03 15:33   
Code reviewed + tested OK in pi@e349ce84e231
(0095236)
hudsonbot   
2017-03-15 20:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test