Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035325 | Retail Modules | Web POS | public | 2017-02-21 13:20 | 2017-06-26 11:29 |
|
| Reporter | mtaal | |
| Assigned To | mtaal | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RR17Q3 | Fixed in Version | RR17Q3 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035325: Support basic authentication in mobile service calls |
| Description | When a client calls an Openbravo webservice it is common to use basic authentication. The client can be for example SoapUI or java code. In java code one can implement basic authentication in the client side with snippet like this [1].
The way basic authentication works is that a request is done in a standard way. If the request returns a 401 then the client side code will react by sending basic authentication credentials (possibly asking the user to enter them). In the java code below the getPasswordAuthentication is called for the second request.
However, in our case we were not always forcing a basic authentication. So external tools like soap ui do not work.
[1]
Authenticator.setDefault(new Authenticator() {
@Override
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(getLogin(), getPassword().toCharArray());
}
});
|
| Steps To Reproduce | Implement a webservice call using code as shown in the test case:
https://code.openbravo.com/tools/automation/pi-mobile/file/06f84e282873/src-test/org/openbravo/test/mobile/retail/mobilecore/webservice/WebServicesHelper.java#l226 [^]
|
| Proposed Solution | Return basic authentication header in case of a 401. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | feature request | 0035326 | 3.0PR17Q2 | closed | mtaal | Openbravo ERP | Support basic authentication | | related to | feature request | 0036238 | 3.0PR17Q3 | closed | mtaal | Openbravo ERP | Support basic authentication: if a stateless request has an invalid login then set the status code to unauthorized |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-02-21 13:20 | mtaal | New Issue | |
| 2017-02-21 13:20 | mtaal | Assigned To | => mtaal |
| 2017-02-21 13:20 | mtaal | OBNetwork customer | => No |
| 2017-02-21 13:20 | mtaal | Triggers an Emergency Pack | => No |
| 2017-02-21 13:21 | mtaal | Summary | Support double request approach of basic authentication => Support basic authentication in mobile service calls |
| 2017-02-21 13:21 | mtaal | Review Assigned To | => marvintm |
| 2017-02-21 13:24 | mtaal | Relationship added | related to 0035326 |
| 2017-02-21 13:39 | mtaal | Note Added: 0094507 | |
| 2017-02-21 13:49 | hgbot | Checkin | |
| 2017-02-21 13:49 | hgbot | Note Added: 0094510 | |
| 2017-02-21 13:49 | hgbot | Status | new => resolved |
| 2017-02-21 13:49 | hgbot | Resolution | open => fixed |
| 2017-02-21 13:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/10bfabca502a30ceedf966720a7528ba2b1cb7df [^] |
| 2017-02-21 13:53 | hgbot | Checkin | |
| 2017-02-21 13:53 | hgbot | Note Added: 0094511 | |
| 2017-02-24 09:44 | mtaal | Status | resolved => new |
| 2017-02-24 09:44 | mtaal | Resolution | fixed => open |
| 2017-02-24 09:49 | hgbot | Checkin | |
| 2017-02-24 09:49 | hgbot | Note Added: 0094595 | |
| 2017-02-24 09:51 | hgbot | Checkin | |
| 2017-02-24 09:51 | hgbot | Note Added: 0094597 | |
| 2017-03-29 13:43 | AugustoMauch | Target Version | RR17Q2 => RR17Q3 |
| 2017-06-12 23:39 | mtaal | Relationship added | related to 0036238 |
| 2017-06-12 23:43 | mtaal | Status | new => scheduled |
| 2017-06-12 23:43 | mtaal | Note Added: 0097336 | |
| 2017-06-12 23:43 | mtaal | Status | scheduled => resolved |
| 2017-06-12 23:43 | mtaal | Fixed in Version | => RR17Q3 |
| 2017-06-12 23:43 | mtaal | Resolution | open => fixed |
| 2017-06-26 11:29 | marvintm | Status | resolved => closed |
|
Notes |
|
|
(0094507)
|
|
mtaal
|
|
2017-02-21 13:39
|
|
|
|
|
(0094510)
|
|
hgbot
|
|
2017-02-21 13:49
|
|
|
|
|
(0094511)
|
|
hgbot
|
|
2017-02-21 13:53
|
|
Repository: tools/automation/pi-mobile
Changeset: 1e44a524fa1fbfe6529e3392c919b309d99c728c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Feb 21 13:53:08 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1e44a524fa1fbfe6529e3392c919b309d99c728c [^]
Related to issue 35325, related to issue 35326
Comment out the headers which pass directly basic auth information. Are not needed anymore.
Keep commented code for later usage/reference
---
M src-test/org/openbravo/test/mobile/retail/mobilecore/webservice/WebServicesHelper.java
---
|
|
|
|
(0094595)
|
|
hgbot
|
|
2017-02-24 09:49
|
|
Repository: tools/automation/pi-mobile
Changeset: e346994c7452dcb03ce1b3667be01809f26a3633
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Feb 24 09:49:36 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e346994c7452dcb03ce1b3667be01809f26a3633 [^]
Related to issue 35325, related to issue 35326
Backout of changeset as it causes several offline tests to fail
---
M src-test/org/openbravo/test/mobile/retail/mobilecore/webservice/WebServicesHelper.java
---
|
|
|
|
(0094597)
|
|
hgbot
|
|
2017-02-24 09:51
|
|
|
|
|
(0097336)
|
|
mtaal
|
|
2017-06-12 23:43
|
|
|
Accidentally pushed all changes in related ERP core issue |
|