Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035318Openbravo ERPA. Platformpublic2017-02-20 18:402017-02-24 09:58
Reportermalsasua 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-04-18
Regression introduced in release3.0PR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
Triggers an Emergency PackNo
Summary0035318: invoice PDF is not attached from "email" button in sales invoice window
Descriptionin sales invoice window, it is possible to send one email with the PDF invoice, clicking in "email" button (in toolbar).

From 16Q3, the email is sent, but the PDF is not attached
Steps To Reproducein "Client" window, "Email Configuration" tab, configure it
in Sales Invoice window, select one record, and click in "email" button. Click in option "attached document" (see attachment)
sent email

the email is sent, but PDF is not attached to the email
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035313 closed caristu invoice PDF is not attached from "email" button in sales invoice window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-21 09:34caristuTypedefect => backport
2017-02-21 09:34caristuTarget Version => 3.0PR17Q1
2017-02-21 14:17hgbotCheckin
2017-02-21 14:17hgbotNote Added: 0094515
2017-02-21 14:17hgbotStatusscheduled => resolved
2017-02-21 14:17hgbotResolutionopen => fixed
2017-02-21 14:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/d074c8f621ffef441a3823a2f5720ccbb3f9b017 [^]
2017-02-21 16:01caristuReview Assigned To => alostale
2017-02-21 16:03caristuAssigned Toplatform => caristu
2017-02-24 09:58alostaleNote Added: 0094601
2017-02-24 09:58alostaleStatusresolved => closed
2017-02-24 09:58alostaleFixed in Version => 3.0PR17Q1

Notes
(0094515)
hgbot   
2017-02-21 14:17   
Repository: erp/backports/3.0PR17Q1
Changeset: d074c8f621ffef441a3823a2f5720ccbb3f9b017
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 21 14:16:33 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/d074c8f621ffef441a3823a2f5720ccbb3f9b017 [^]

fixes issue 35318: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

---
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0094601)
alostale   
2017-02-24 09:58   
code reviewed + tested