Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035317Openbravo ERPA. Platformpublic2017-02-20 18:402017-02-24 09:57
malsasua 
caristu 
immediateminoralways
closedfixed 
5
 
3.0PR16Q3.63.0PR16Q3.6 
alostale
Core
Production - Confirmed Stable
2016-04-18
3.0PR16Q3
https://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
No
0035317: invoice PDF is not attached from "email" button in sales invoice window
in sales invoice window, it is possible to send one email with the PDF invoice, clicking in "email" button (in toolbar).

From 16Q3, the email is sent, but the PDF is not attached
in "Client" window, "Email Configuration" tab, configure it
in Sales Invoice window, select one record, and click in "email" button. Click in option "attached document" (see attachment)
sent email

the email is sent, but PDF is not attached to the email
No tags attached.
blocks defect 0035313 closed caristu invoice PDF is not attached from "email" button in sales invoice window 
Issue History
2017-02-21 09:34caristuTypedefect => backport
2017-02-21 09:34caristuTarget Version => 3.0PR17Q2
2017-02-21 14:14caristuTarget Version3.0PR17Q2 => 3.0PR16Q3.6
2017-02-21 14:16hgbotCheckin
2017-02-21 14:16hgbotNote Added: 0094514
2017-02-21 14:16hgbotStatusscheduled => resolved
2017-02-21 14:16hgbotResolutionopen => fixed
2017-02-21 14:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q3.6/rev/745542ecf038ba20363018388c5d3c63c311c7ed [^]
2017-02-21 16:02caristuReview Assigned To => alostale
2017-02-21 16:03caristuAssigned Toplatform => caristu
2017-02-24 09:57alostaleNote Added: 0094599
2017-02-24 09:57alostaleStatusresolved => closed
2017-02-24 09:57alostaleFixed in Version => 3.0PR16Q3.6

Notes
(0094514)
hgbot   
2017-02-21 14:16   
Repository: erp/backports/3.0PR16Q3.6
Changeset: 745542ecf038ba20363018388c5d3c63c311c7ed
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 21 14:15:24 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q3.6/rev/745542ecf038ba20363018388c5d3c63c311c7ed [^]

fixes issue 35317: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

---
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0094599)
alostale   
2017-02-24 09:57   
code reviewed + tested